From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E20C433F5 for ; Thu, 16 Sep 2021 01:06:19 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9797661157 for ; Thu, 16 Sep 2021 01:06:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9797661157 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 562EF60764; Thu, 16 Sep 2021 01:06:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cY7fvhmyfnOu; Thu, 16 Sep 2021 01:06:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id BDF38606BD; Thu, 16 Sep 2021 01:06:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A30BDC0011; Thu, 16 Sep 2021 01:06:17 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 62318C000D for ; Thu, 16 Sep 2021 01:06:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 50383606C5 for ; Thu, 16 Sep 2021 01:06:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jvQCV29vxj1d for ; Thu, 16 Sep 2021 01:06:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 57158606BD for ; Thu, 16 Sep 2021 01:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631754372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x63Yqn0DtCTzc9ERFDPUQ+PBwhc7qmVzV00IKh6bfhQ=; b=c/GApsqdARBmroNR4jjrWjgJ+udzzUrbBINKGM+j0JL6gPrduNQ5HkNtTeONrReir8HtpP rfGQJW3q+pg5K4XXv3nnX5n2bLBhsyeNOsHFhDmYWVrQR8tbYDW5IvxF7sLwenfQA5xQUr 8aJjSPa71uaYv5ScWvyk9o3D7tsAmFM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-UpBFhKX4MeSUhJBHOTw7aQ-1; Wed, 15 Sep 2021 21:06:11 -0400 X-MC-Unique: UpBFhKX4MeSUhJBHOTw7aQ-1 Received: by mail-lf1-f72.google.com with SMTP id g4-20020a19ac04000000b003eb3973e4e2so2360251lfc.17 for ; Wed, 15 Sep 2021 18:06:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x63Yqn0DtCTzc9ERFDPUQ+PBwhc7qmVzV00IKh6bfhQ=; b=AHI/Vi0OGnuf+Wlijnwp8ol74N6jTOEs2um80OHs3AkHHHtGf4k0WZggM513MycXr7 ZijmLOMfhO1CFwbwiIcYaoEIqlfJxL+cmjGtgdFK6pjqMfpX3N9IloRFyXiKFtK/tSPv WL5cR3v9SZImB+6ekmGPxP7t/4d+QwD276Gy8x50wy7s4lBIoENqAaya0+ltJL76IWId Jtd+VDc7cO6koTn2z41npvhx8eUnAuYNP7F7JvA2joidcmx5LfoWs2rDrAaItjgJaOb1 E4QnXOZUI9/9igKH01Mt9EBdEr6eU33wOsuOpHq86lQksr4ewQuz+EU31ex0E5rPfm1e wuOA== X-Gm-Message-State: AOAM531ytnRSlriSo834fJK3q5Y5pELsNzBlQGcR9GjgVw63KdlDnspv klpiC5EGY2pd9vPuhoeZJBYy9L8Y9w4zkWXqHz6rcxKEA3eufKZdUkW8DeHDLdkFIPbKlqNMCuQ BgWnjFC5kgdsVmv06bEJpdL4f2qmIqARXp9frolPk+wqAl2a+HsYh0tviAQ== X-Received: by 2002:ac2:5fb2:: with SMTP id s18mr2084341lfe.580.1631754369476; Wed, 15 Sep 2021 18:06:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLREPTBZ+yEpea8lnS1iCiKbHI40pQquw5U16RGNn37qtYRldzDq0hnokb3vg/CzcUr8urYy8bPv7gWMmHLFo= X-Received: by 2002:ac2:5fb2:: with SMTP id s18mr2084329lfe.580.1631754369221; Wed, 15 Sep 2021 18:06:09 -0700 (PDT) MIME-Version: 1.0 References: <834528d24c839080215b2e077f100e9ed5073edc.1631621507.git.wuzongyong@linux.alibaba.com> <20210914085711-mutt-send-email-mst@kernel.org> <20210915033756-mutt-send-email-mst@kernel.org> <20210915070805-mutt-send-email-mst@kernel.org> In-Reply-To: <20210915070805-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Thu, 16 Sep 2021 09:05:58 +0800 Message-ID: Subject: Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1 To: "Michael S. Tsirkin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: wei.yang1@linux.alibaba.com, Wu Zongyong , linux-kernel , virtualization X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Sep 15, 2021 at 7:09 PM Michael S. Tsirkin wrote: > > On Wed, Sep 15, 2021 at 04:06:57PM +0800, Jason Wang wrote: > > On Wed, Sep 15, 2021 at 3:38 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Sep 15, 2021 at 11:18:06AM +0800, Jason Wang wrote: > > > > On Tue, Sep 14, 2021 at 8:58 PM Michael S. Tsirkin wrote: > > > > > > > > > > On Tue, Sep 14, 2021 at 08:24:51PM +0800, Wu Zongyong wrote: > > > > > > This new attribute advertises whether the vdpa device is legacy or not. > > > > > > Users can pick right virtqueue size if the vdpa device is legacy which > > > > > > doesn't support to change virtqueue size. > > > > > > > > > > > > Signed-off-by: Wu Zongyong > > > > > > > > > > So if we are bothering with legacy, > > > > > > > > I think we'd better not. I guess the following may work: > > > > > > > > 1) disable the driver on BE host > > > > 2) present VERSION_1 with ACCESS_PLATFORM in get_features() > > > > 3) extend the management to advertise max_queue_size and > > > > min_queue_size, for ENI they are the same so management layer knows it > > > > needs to set the queue_size correctly during launching qemu > > > > > > > > Thoughts? > > > > > > > > Thanks > > > > > > There are other subtle differences such as header size without > > > mergeable buffers for net. > > > > This can be solved by mandating the feature of a mergeable buffer? > > > > Thanks > > PXE and some dpdk versions are only some of the guests that > disable mergeable buffers feature. True, but consider 1) the legacy stuffs requires changes in several software layers 2) it is how virtio 1.0 works e.g device can fail the feature negotiation 3) it is not supported since day 0 4) management API can be extended to advertise the mandated features It looks affordable. Thanks > > > > > > > > > > > > I think there are > > > > > several things to do when building the interface > > > > > - support transitional devices, that is allow userspace > > > > > to tell device it's in legacy mode > > > > > - support reporting/setting supporting endian-ness > > > > > > > > > > > --- > > > > > > drivers/vdpa/vdpa.c | 6 ++++++ > > > > > > drivers/virtio/virtio_vdpa.c | 7 ++++++- > > > > > > include/uapi/linux/vdpa.h | 1 + > > > > > > 3 files changed, 13 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c > > > > > > index 1dc121a07a93..533d7f589eee 100644 > > > > > > --- a/drivers/vdpa/vdpa.c > > > > > > +++ b/drivers/vdpa/vdpa.c > > > > > > @@ -12,6 +12,7 @@ > > > > > > #include > > > > > > #include > > > > > > #include > > > > > > +#include > > > > > > #include > > > > > > #include > > > > > > > > > > > > @@ -494,6 +495,7 @@ vdpa_dev_fill(struct vdpa_device *vdev, struct sk_buff *msg, u32 portid, u32 seq > > > > > > u16 max_vq_size; > > > > > > u32 device_id; > > > > > > u32 vendor_id; > > > > > > + u64 features; > > > > > > void *hdr; > > > > > > int err; > > > > > > > > > > > > @@ -508,6 +510,7 @@ vdpa_dev_fill(struct vdpa_device *vdev, struct sk_buff *msg, u32 portid, u32 seq > > > > > > device_id = vdev->config->get_device_id(vdev); > > > > > > vendor_id = vdev->config->get_vendor_id(vdev); > > > > > > max_vq_size = vdev->config->get_vq_num_max(vdev); > > > > > > + features = vdev->config->get_features(vdev); > > > > > > > > > > > > err = -EMSGSIZE; > > > > > > if (nla_put_string(msg, VDPA_ATTR_DEV_NAME, dev_name(&vdev->dev))) > > > > > > @@ -520,6 +523,9 @@ vdpa_dev_fill(struct vdpa_device *vdev, struct sk_buff *msg, u32 portid, u32 seq > > > > > > goto msg_err; > > > > > > if (nla_put_u16(msg, VDPA_ATTR_DEV_MAX_VQ_SIZE, max_vq_size)) > > > > > > goto msg_err; > > > > > > + if (features & BIT_ULL(VIRTIO_F_VERSION_1) && > > > > > > + nla_put_flag(msg, VDPA_ATTR_DEV_VERSION_1)) > > > > > > + goto msg_err; > > > > > > > > > > > > genlmsg_end(msg, hdr); > > > > > > return 0; > > > > > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > > > > > > index 72eaef2caeb1..1cba957c4cdc 100644 > > > > > > --- a/drivers/virtio/virtio_vdpa.c > > > > > > +++ b/drivers/virtio/virtio_vdpa.c > > > > > > @@ -7,6 +7,7 @@ > > > > > > * > > > > > > */ > > > > > > > > > > > > +#include "linux/virtio_config.h" > > > > > > #include > > > > > > #include > > > > > > #include > > > > > > @@ -145,6 +146,7 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index, > > > > > > /* Assume split virtqueue, switch to packed if necessary */ > > > > > > struct vdpa_vq_state state = {0}; > > > > > > unsigned long flags; > > > > > > + bool may_reduce_num = false; > > > > > > u32 align, num; > > > > > > int err; > > > > > > > > > > > > @@ -169,10 +171,13 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index, > > > > > > goto error_new_virtqueue; > > > > > > } > > > > > > > > > > > > + if (ops->get_features(vdpa) & BIT_ULL(VIRTIO_F_VERSION_1)) > > > > > > + may_reduce_num = true; > > > > > > + > > > > > > /* Create the vring */ > > > > > > align = ops->get_vq_align(vdpa); > > > > > > vq = vring_create_virtqueue(index, num, align, vdev, > > > > > > - true, true, ctx, > > > > > > + true, may_reduce_num, ctx, > > > > > > virtio_vdpa_notify, callback, name); > > > > > > if (!vq) { > > > > > > err = -ENOMEM; > > > > > > diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h > > > > > > index 66a41e4ec163..ce0b74276a5b 100644 > > > > > > --- a/include/uapi/linux/vdpa.h > > > > > > +++ b/include/uapi/linux/vdpa.h > > > > > > @@ -32,6 +32,7 @@ enum vdpa_attr { > > > > > > VDPA_ATTR_DEV_VENDOR_ID, /* u32 */ > > > > > > VDPA_ATTR_DEV_MAX_VQS, /* u32 */ > > > > > > VDPA_ATTR_DEV_MAX_VQ_SIZE, /* u16 */ > > > > > > + VDPA_ATTR_DEV_VERSION_1, /* flag */ > > > > > > > > > > > > /* new attributes must be added above here */ > > > > > > VDPA_ATTR_MAX, > > > > > > -- > > > > > > 2.31.1 > > > > > > > > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization