From: Jason Wang <jasowang@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Yongji Xie <xieyongji@bytedance.com>,
"lingshan.zhu@intel.com" <lingshan.zhu@intel.com>,
Eli Cohen <elic@nvidia.com>
Subject: Re: [PATCH v2 2/3] vdpa: Add a device object for vdpa management device
Date: Mon, 23 May 2022 11:41:11 +0800 [thread overview]
Message-ID: <CACGkMEvrekJFMFLpgUHZ7HOTed7oRSt4Mv2ASUHLNC3ZCs-NEA@mail.gmail.com> (raw)
In-Reply-To: <PH0PR12MB54817B6BE5796E237A50FB2FDCD49@PH0PR12MB5481.namprd12.prod.outlook.com>
On Mon, May 23, 2022 at 10:00 AM Parav Pandit <parav@nvidia.com> wrote:
>
>
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Wednesday, May 18, 2022 4:32 AM
> >
> > 在 2022/5/18 07:03, Parav Pandit 写道:
> > >>> And regarding vduse_dev_release() and existing empty release
> > >>> function,
> > >> they can be dynamically allocated.
> > >>> This is because they are really the struct device.
> > >> I do not understand this statement, sorry.
> > > It was bad sentence, my bad.
> > >
> > > What I wanted to say is, probably better explained with real patch below.
> > > In context of [1], struct vduse_mgmtdev empty release function can be
> > avoided by below inline patch [2].
> > >
> > > [1]https://www.spinics.net/lists/linux-virtualization/msg56371.html
> > >
> > > [2] patch:
> >
> >
> > Ok, if we go this way (looks more like mdev_parent). I think we need at least
> > rename the vdpa_mgmt_device, maybe vdpa_parent (like mdev_parent)?
> >
> It can be.
> Parent is also a device. So...
How about "vdpa_parent_data"? Not a native speaker but it's better to
remove "device" from the name anhow.
Thanks
> Since there are no further comments on the inline patch, I will send it as separate patch this week.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-23 3:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220516060342.106-1-xieyongji@bytedance.com>
2022-05-16 6:13 ` [PATCH v2 1/3] vduse: Pass management device pointer to vduse_dev_init_vdpa() Greg KH
[not found] ` <20220516060342.106-3-xieyongji@bytedance.com>
2022-05-16 6:14 ` [PATCH v2 3/3] Docs/ABI/testing: Add VDUSE sysfs interface ABI document Greg KH
2022-05-16 8:33 ` [PATCH v2 1/3] vduse: Pass management device pointer to vduse_dev_init_vdpa() Michael S. Tsirkin
[not found] ` <20220516060342.106-2-xieyongji@bytedance.com>
2022-05-16 6:13 ` [PATCH v2 2/3] vdpa: Add a device object for vdpa management device Greg KH
2022-05-16 8:32 ` Michael S. Tsirkin
2022-05-16 9:14 ` Jason Wang
[not found] ` <CACycT3uoWjYjogi0H4yrA7GuKnY=djt6BmafoRB-rbmz+8Y4BA@mail.gmail.com>
2022-05-16 9:54 ` Michael S. Tsirkin
[not found] ` <CACycT3sqEJ7JSYV646m6CLVH5tKpfbTUV4Oz+XcfXTe4ApEE1w@mail.gmail.com>
2022-05-16 10:34 ` Michael S. Tsirkin
2022-05-16 11:54 ` Greg KH
2022-05-17 6:29 ` Jason Wang
2022-05-17 6:38 ` Greg KH
2022-05-16 20:06 ` Parav Pandit via Virtualization
[not found] ` <CACycT3sRc4bk+3oq7FLzpBMCG_XRN7tOaeEAtNg69o3h8c3=EA@mail.gmail.com>
2022-05-17 12:21 ` Parav Pandit via Virtualization
2022-05-17 13:54 ` gregkh
2022-05-17 23:03 ` Parav Pandit via Virtualization
2022-05-18 8:31 ` Jason Wang
2022-05-23 2:00 ` Parav Pandit via Virtualization
2022-05-23 3:41 ` Jason Wang [this message]
2022-05-24 1:07 ` Parav Pandit via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACGkMEvrekJFMFLpgUHZ7HOTed7oRSt4Mv2ASUHLNC3ZCs-NEA@mail.gmail.com \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=lingshan.zhu@intel.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).