RE: [PATCH v3 net-next 1/3] net: update comments for SKB_GSO_TCP_ECN and SKB_GSO_TCP_ACCECN

["Chia-Yu Chang (Nokia)" <chia-yu.chang@nokia-bell-labs.com>]

> -----Original Message-----
> From: Parav Pandit <parav@nvidia.com> 
> Sent: Wednesday, February 4, 2026 3:54 AM
> To: Chia-Yu Chang (Nokia) <chia-yu.chang@nokia-bell-labs.com>; Tariq Toukan <tariqt@nvidia.com>; linux-rdma@vger.kernel.org; shaojijie@huawei.com; shenjian15@huawei.com; salil.mehta@huawei.com; Mark Bloch <mbloch@nvidia.com>; Saeed Mahameed <saeedm@nvidia.com>; leon@kernel.org; eperezma@redhat.com; brett.creeley@amd.com; jasowang@redhat.com; virtualization@lists.linux.dev; mst@redhat.com; xuanzhuo@linux.alibaba.com; pabeni@redhat.com; edumazet@google.com; linux-doc@vger.kernel.org; corbet@lwn.net; horms@kernel.org; dsahern@kernel.org; kuniyu@google.com; bpf@vger.kernel.org; netdev@vger.kernel.org; dave.taht@gmail.com; jhs@mojatatu.com; kuba@kernel.org; stephen@networkplumber.org; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; andrew+netdev@lunn.ch; donald.hunter@gmail.com; ast@fiberby.net; liuhangbin@gmail.com; shuah@kernel.org; linux-kselftest@vger.kernel.org; ij@kernel.org; ncardwell@google.com; Koen De Schepper (Nokia) <koen.de_schepper@nokia-bell-labs.com>; g.white@cablelabs.com; ingemar.s.johansson@ericsson.com; mirja.kuehlewind@ericsson.com; cheshire@apple.com; rs.ietf@gmx.at; Jason_Livingood@comcast.com; vidhi_goel@apple.com
> Subject: RE: [PATCH v3 net-next 1/3] net: update comments for SKB_GSO_TCP_ECN and SKB_GSO_TCP_ACCECN
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> 
> 
> 
> > From: chia-yu.chang@nokia-bell-labs.com 
> > <chia-yu.chang@nokia-bell-labs.com>
> > Sent: 03 February 2026 09:41 PM
> > Cc: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
> > Subject: [PATCH v3 net-next 1/3] net: update comments for 
> > SKB_GSO_TCP_ECN and SKB_GSO_TCP_ACCECN
> >
> > From: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
> >
> > This patch updates the documentation of ECN‑related GSO flags, it 
> > clarifies the limitations of SKB_GSO_TCP_ECN and explains how to 
> > preserve the CWR flag (part of the ACE signal) in the Rx path.
> >
> > For Tx, SKB_GSO_TCP_ECN and SKB_GSO_TCP_ACCECN are used respectively 
> > for
> > RFC3168 ECN and AccECN (RFC9768). SKB_GSO_TCP_ECN indicates that the 
> > first segment has CWR set, while subsequent segments have CWR cleared.
> > In contrast, SKB_GSO_TCP_ACCECN means that the segment uses AccECN and 
> > therefore its CWR flag must not be modified durging segmentation.
> >
> > For RX, SKB_GSO_TCP_ECN shall NOT be used, because the stack cannot 
> > know whether the connection uses RFC3168 ECN or AccECN, whereas 
> > RFC3168 ECN offload may clear CWR flag and thus corrupts the ACE 
> > signal. Instead, any segment that arrives with CWR set must use the 
> > SKB_GSO_TCP_ACCECN flag to prevent RFC3168 ECN offload logic from clearing the CWR flag.
> >
> > Co-developed-by: Ilpo Järvinen <ij@kernel.org>
> > Signed-off-by: Ilpo Järvinen <ij@kernel.org>
> > Signed-off-by: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
> >
> > ---
> > v3:
> > - Update commit messages and documentation for clarity
> > ---
> >  include/linux/skbuff.h | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 
> > 8b399ddf1b9b..c59f0ce414d9 100644
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -671,7 +671,13 @@ enum {
> >       /* This indicates the skb is from an untrusted source. */
> >       SKB_GSO_DODGY = 1 << 1,
> >
> > -     /* This indicates the tcp segment has CWR set. */
> > +     /* For Tx, this indicates that the first TCP segment has CWR set, and
> > +      * any subsequent segment in the same skb has CWR cleared. This flag
> > +      * must not be used in Rx, because the connection to which the segment
> > +      * belongs is not tracked to use RFC3168 or AccECN. Using RFC3168 ECN
> > +      * offload may clear CWR and corrupt ACE signal (CWR is part of it).
> > +      * Instead, SKB_GSO_TCP_ACCECN shall be used to avoid CWR corruption.
> > +      */
> Above part of the patch belongs to net with Fixes tag. Not sure how important it is to have fixes tag for comment.
> But the next patch of hns and mlx5 surely needs to have Fixes tag and in net.
> So can you please split this patch along with hns and mlx5 patch in the net branch instead of net-next?
> 
> >       SKB_GSO_TCP_ECN = 1 << 2,
> >
> 
> >       __SKB_GSO_TCP_FIXEDID = 1 << 3,
> > @@ -706,6 +712,13 @@ enum {
> >
> >       SKB_GSO_FRAGLIST = 1 << 18,
> >
> > +     /* For TX, this indicates that the TCP segment uses the CWR flag as part
> > +      * of the ACE signal, and the CWR flag must not be modified in the skb.
> > +      * For RX, any incoming segment with CWR set must use this flag so that
> > +      * no RFC3168 ECN offload can clear the CWR flag. This is essential for
> > +      * preserving ACE signal correceness (CWR is part of it) in a forwarding
> > +      * scenario, e.g., from virtio_net RX to GSO TX.
> > +      */
> Better to have this comment not linked to any device type as virtio-net. It can be from one to other netdev as generic example.

Hi Parav,

Sure, I will split the last virtio-net patch into individual series into net-next.

And re-send the first 2 patches (with the suggested change to not linked to any device type) to net.

Thanks.

Chia-Yu