From: Hugh Dickins <hugh@veritas.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Linus Torvalds <torvalds@linux-foundation.or>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, xen-devel <xen-devel@lists.xensource.com>,
Thomas Gleixner <tglx@linutronix.de>,
Zachary Amsden <zach@vmware.com>,
kvm-devel <kvm-devel@lists.sourceforge.net>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction
Date: Mon, 16 Jun 2008 19:13:48 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0806161906490.19564@blonde.site> (raw)
In-Reply-To: <alpine.LFD.1.10.0806161028080.2949@woody.linux-foundation.org>
On Mon, 16 Jun 2008, Linus Torvalds wrote:
> On Mon, 16 Jun 2008, Jeremy Fitzhardinge wrote:
> >
> > ptep_modify_prot_start() returns the current pte value, and puts the
> > pte entry into a state where either the hardware will not update the
> > pte, or if it does, the updates will be preserved on commit.
> >
> > ptep_modify_prot_commit() writes back the updated pte, makes sure that
> > any hardware updates made since ptep_modify_prot_start() are
> > preserved.
>
> Ok, I'm fine with this now that it's renamed to be clearly about just
> protection bits.
>
> So
>
> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
And seems very reasonable (and exceptionally well described) to me too.
Acked-by: Hugh Dickins <hugh@veritas.com>
next prev parent reply other threads:[~2008-06-16 18:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 11:29 [PATCH 0 of 4] mm+paravirt+xen: add pte read-modify-write abstraction (take 2) Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction Jeremy Fitzhardinge
2008-06-16 17:29 ` Linus Torvalds
2008-06-16 18:13 ` Hugh Dickins [this message]
2008-06-16 18:49 ` Ingo Molnar
2008-06-18 23:23 ` Benjamin Herrenschmidt
2008-06-18 23:59 ` Jeremy Fitzhardinge
2008-06-19 0:15 ` Jeremy Fitzhardinge
2008-06-19 0:24 ` Linus Torvalds
2008-06-19 0:37 ` Jeremy Fitzhardinge
2008-06-19 0:49 ` Linus Torvalds
2008-06-19 4:03 ` Linus Torvalds
2008-06-19 11:58 ` Ingo Molnar
2008-06-19 12:03 ` Ingo Molnar
2008-06-19 12:20 ` Akinobu Mita
2008-06-19 16:30 ` Linus Torvalds
2008-06-19 16:47 ` Ingo Molnar
2008-06-20 10:10 ` Ingo Molnar
2008-06-20 19:06 ` Jeremy Fitzhardinge
2008-06-20 19:15 ` Linus Torvalds
2008-06-20 19:56 ` Ingo Molnar
2008-06-20 20:03 ` Linus Torvalds
2008-06-20 20:16 ` Jeremy Fitzhardinge
2008-06-20 20:22 ` Jeremy Fitzhardinge
2008-06-21 6:06 ` Ingo Molnar
2008-06-20 20:05 ` Jeremy Fitzhardinge
2008-06-19 0:39 ` Benjamin Herrenschmidt
2008-06-19 5:03 ` Jeremy Fitzhardinge
2008-06-19 7:20 ` Benjamin Herrenschmidt
2008-06-19 17:57 ` Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_start/commit Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 3 of 4] xen: implement ptep_modify_prot_start/commit Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 4 of 4] xen: add mechanism to extend existing multicalls Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2008-05-31 0:04 [PATCH 0 of 4] mm+paravirt+xen: add pte read-modify-write abstraction (take 2) Jeremy Fitzhardinge
2008-05-31 0:04 ` [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction Jeremy Fitzhardinge
2008-06-02 11:13 ` Ingo Molnar
2008-06-02 11:57 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806161906490.19564@blonde.site \
--to=hugh@veritas.com \
--cc=a.p.zijlstra@chello.nl \
--cc=jeremy@goop.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.or \
--cc=virtualization@lists.osdl.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).