virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter-Jan Gootzen <peter-jan@gootzen.net>
Cc: virtualization@lists.linux-foundation.org,
	Jonas Pfefferle <JPF@zurich.ibm.com>,
	vgoyal@redhat.com, miklos@szeredi.hu
Subject: Re: virtio-fs: adding support for multi-queue
Date: Tue, 7 Feb 2023 14:45:39 -0500	[thread overview]
Message-ID: <Y+KqY3Nse0pVhd3X@fedora> (raw)
In-Reply-To: <2fd99bc2-0414-0b85-2bff-3a84ae6c23bd@gootzen.net>


[-- Attachment #1.1: Type: text/plain, Size: 1487 bytes --]

On Tue, Feb 07, 2023 at 11:14:46AM +0100, Peter-Jan Gootzen wrote:
> Hi,
> 
> For my MSc thesis project in collaboration with IBM
> (https://github.com/IBM/dpu-virtio-fs) we are looking to improve the
> performance of the virtio-fs driver in high throughput scenarios. We think
> the main bottleneck is the fact that the virtio-fs driver does not support
> multi-queue (while the spec does). A big factor in this is that our setup on
> the virtio-fs device-side (a DPU) does not easily allow multiple cores to
> tend to a single virtio queue.
> 
> We are therefore looking to implement multi-queue functionality in the
> virtio-fs driver. The request queues seem to already get created at probe,
> but left unused afterwards. The current plan is to select the queue for a
> request based on the current smp processor id and set the virtio queue
> interrupt affinity for each core accordingly at probe.
> 
> This is my first time contributing to the Linux kernel so I am here to ask
> what the maintainers' thoughts are about this plan.

Hi,
Sounds good. Assigning vqs round-robin is the strategy that virtio-net
and virtio-blk use. virtio-blk could be an interesting example as it's
similar to virtiofs. The Linux multiqueue block layer and core virtio
irq allocation handle CPU affinity in the case of virtio-blk.

Which DPU are you targetting?

Stefan

> 
> Best,
> Peter-Jan Gootzen
> MSc student at VU University Amsterdam & IBM Research Zurich
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

       reply	other threads:[~2023-02-07 19:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2fd99bc2-0414-0b85-2bff-3a84ae6c23bd@gootzen.net>
2023-02-07 19:45 ` Stefan Hajnoczi [this message]
2023-02-07 19:53   ` virtio-fs: adding support for multi-queue Vivek Goyal
2023-02-07 21:32     ` Stefan Hajnoczi
2023-02-07 21:57       ` Vivek Goyal
2023-02-08  8:33         ` Peter-Jan Gootzen via Virtualization
2023-02-08 10:43           ` Stefan Hajnoczi
2023-02-08 16:29             ` Peter-Jan Gootzen via Virtualization
2023-02-08 20:23               ` Vivek Goyal
2023-02-22 14:32               ` Stefan Hajnoczi
2023-03-07 19:43                 ` Peter-Jan Gootzen via Virtualization
2023-03-07 22:26                   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+KqY3Nse0pVhd3X@fedora \
    --to=stefanha@redhat.com \
    --cc=JPF@zurich.ibm.com \
    --cc=miklos@szeredi.hu \
    --cc=peter-jan@gootzen.net \
    --cc=vgoyal@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).