From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B38CC3DA78 for ; Tue, 17 Jan 2023 12:23:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 14D4F400D0; Tue, 17 Jan 2023 12:23:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 14D4F400D0 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=T37/fdyH X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YtigNqdjd4Ra; Tue, 17 Jan 2023 12:23:04 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id B5B9F4014D; Tue, 17 Jan 2023 12:23:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B5B9F4014D Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6F13CC0033; Tue, 17 Jan 2023 12:23:03 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id CBB6BC002D for ; Tue, 17 Jan 2023 12:23:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9FECE60B31 for ; Tue, 17 Jan 2023 12:23:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9FECE60B31 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=T37/fdyH X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rF3N9fzZ05M9 for ; Tue, 17 Jan 2023 12:23:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DD9C660784 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id DD9C660784 for ; Tue, 17 Jan 2023 12:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KPcxEANcwfX3iqDYXrP0qaBKg/IIzvrkL1jXD2O4/YU=; b=T37/fdyH3s0FoXrIwst2EWKWW2 gWZV1W+E91gwq1HK6a/49VgIdqo+idZ6XnC5EolsKpR9J6SEA4x5mV228YM4nl/LqVkHXAv87cJHg AJE7gQpSpVbHwcysQlQQvz5d2KUQpnTwfNRun33w361Zbw4/eNEQqe1AbkaGLU75oBwowWHcS0HL7 nP1LPydHLx7ZFZlAjm46I9fu01OOn1589OFzsMSMprpw34deb7I+GBxJa0tA8ywqvRqcbv45sYaHp huG6eQ3fAi/BuUQkxeMmOF/vQ/aRRDhp9PWAihhrUxezDkp53guytzHb8K3MN5IuPYzM0htYLo7Ra DUtJsC+g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHkzP-009fbF-JC; Tue, 17 Jan 2023 12:22:55 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 361363005C9; Tue, 17 Jan 2023 13:22:41 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 15B9420B1647C; Tue, 17 Jan 2023 13:22:41 +0100 (CET) Date: Tue, 17 Jan 2023 13:22:41 +0100 From: Peter Zijlstra To: "Srivatsa S. Bhat" Subject: Re: [PATCH] x86/paravirt: merge activate_mm and dup_mmap callbacks Message-ID: References: <20230112152132.4399-1-jgross@suse.com> <3fcb5078-852e-0886-c084-7fb0cfa5b757@csail.mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3fcb5078-852e-0886-c084-7fb0cfa5b757@csail.mit.edu> Cc: Juergen Gross , Dave Hansen , Alexey Makhalov , VMware PV-Drivers Reviewers , x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , Boris Ostrovsky X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Sun, Jan 15, 2023 at 08:27:50PM -0800, Srivatsa S. Bhat wrote: > I see that's not an issue right now since there is no other actual > user for these callbacks. But are we sure that merging the callbacks > just because the current user (Xen PV) has the same implementation for > both is a good idea? IIRC the pv_ops are part of the PARAVIRT_ME_HARDER (also spelled as _XXL) suite of ops and they are only to be used by Xen PV, no new users of these must happen. The moment we can drop Xen PV (hopes and dreams etc..) all these things go in the bin right along with it. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization