From: Matthew Wilcox <willy@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: michel@lespinasse.org, nvdimm@lists.linux.dev, heiko@sntech.de,
leewalsh@google.com, dri-devel@lists.freedesktop.org,
perex@perex.cz, jglisse@google.com, arjunroy@google.com,
m.szyprowski@samsung.com, linux-arch@vger.kernel.org,
qianweili@huawei.com, linux-samsung-soc@vger.kernel.org,
aneesh.kumar@linux.ibm.com, chenhuacai@kernel.org,
kasan-dev@googlegroups.com, linux-acpi@vger.kernel.org,
rientjes@google.com, xen-devel@lists.xenproject.org,
devel@lists.orangefs.org, robdclark@gmail.com,
minchan@google.com, robert.jarzmik@free.fr,
linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org,
npiggin@gmail.com, viro@zeniv.linux.org.uk, luto@kernel.org,
gthelen@google.com, tglx@linutronix.de, ldufour@linux.ibm.com,
linux-sgx@vger.kernel.org, martin.petersen@oracle.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
linux-media@vger.kernel.org, freedreno@lists.freedesktop.org,
joelaf@google.com, linux-aio@kvack.org,
linux-fbdev@vger.kernel.org, linux-ia64@vger.kernel.org,
dave.hansen@linux.intel.com,
virtualization@lists.linux-foundation.org, edumazet@google.com,
target-devel@vger.kernel.org, punit.agrawal@bytedance.com,
linux-s390@vger.kernel.org, dave@stgolabs.net, deller@gmx.de,
hughd@google.com, andrii@kernel.org,
patrik.r.jakobsson@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-rockchip@lists.infradead.org,
linux-graphics-maintainer@vmware.com, kernel-team@android.com,
jayalk@intworks.biz, soheil@google.com, selinux@vger.kernel.org,
linux-arm-msm@vger.kernel.org, mripard@kernel.org,
shakeelb@google.com, haojian.zhuang@gmail.com,
loongarch@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
tytso@mit.edu, nico@fluxnic.net, muchun.song@linux.dev,
hjc@rock-chips.com, mcoquelin.stm32@gmail.com,
tatashin@google.com, mike.kravetz@oracle.com,
songliubraving@fb.com, alsa-devel@alsa-project.org,
linux-tegra@vger.kernel.org, will@kernel.org,
dmaengine@vger.kernel.org, bhe@redhat.com, miklos@szeredi.hu,
linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev,
amd-gfx@lists.freedesktop.org, gurua@google.com,
dgilbert@interlog.com, xiang@kernel.org, pabeni@redhat.com,
jejb@linux.ibm.com, quic_abhinavk@quicinc.com, bp@alien8.de,
mchehab@kernel.org, linux-ext4@vger.kernel.org, tomba@kernel.org,
hughlynch@google.com, sre@kernel.org, tfiga@chromium.org,
linux-xfs@vger.kernel.org, zhangfei.gao@linaro.org,
wangzhou1@hisilicon.com, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-erofs@lists.ozlabs.org,
davem@davemloft.net, mhocko@suse.com, kvm@vger.kernel.org,
mst@redhat.com, Peter Zijlstra <peterz@infradead.org>,
bigeasy@linutronix.de, alexandre.torgue@foss.st.com,
dhowells@redhat.com, linux-mm@kvack.org, ray.huang@amd.com,
adilger.kernel@dilger.ca, kuba@kernel.org,
sparclinux@vger.kernel.org, airlied@gmail.com,
anton.ivanov@cambridgegreys.com, herbert@gondor.apana.org.au,
linux-scsi@vger.kernel.org, richard@nod.at, x86@kernel.org,
vkoul@kernel.org, mingo@redhat.com, axelrasmussen@google.com,
intel-gfx@lists.freedesktop.org, daniel@ffwll.ch,
paulmck@kernel.org, jannh@google.com, chao@kernel.org,
maarten.lankhorst@linux.intel.com, liam.howlett@oracle.com,
hdegoede@redhat.com, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, vbabka@suse.cz, dimitri.sivanich@hpe.com,
posk@google.com, lstoakes@gmail.com, peterjung1337@gmail.com,
yoshfuji@linux-ipv6.org, linuxppc-dev@lists.ozlabs.org,
dsahern@kernel.org, kent.overstreet@linux.dev,
kexec@lists.infradead.org, tiwai@suse.com,
krzysztof.kozlowski@linaro.org, tzimmermann@suse.de,
hannes@cmpxchg.org, dmitry.baryshkov@linaro.org,
johannes@sipsolutions.net, mgorman@techsingularity.net,
linux-accelerators@lists.ozlabs.org, l.stach@pengutronix.de
Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions
Date: Wed, 25 Jan 2023 18:37:36 +0000 [thread overview]
Message-ID: <Y9F28J9njAtwifuL@casper.infradead.org> (raw)
In-Reply-To: <CAJuCfpEcVCZaCGzc-Wim25eaV5e6YG1YJAAdKwZ6JHViB0z8aw@mail.gmail.com>
On Wed, Jan 25, 2023 at 08:49:50AM -0800, Suren Baghdasaryan wrote:
> On Wed, Jan 25, 2023 at 1:10 AM Peter Zijlstra <peterz@infradead.org> wrote:
> > > + /*
> > > + * Flags, see mm.h.
> > > + * WARNING! Do not modify directly.
> > > + * Use {init|reset|set|clear|mod}_vm_flags() functions instead.
> > > + */
> > > + unsigned long vm_flags;
> >
> > We have __private and ACCESS_PRIVATE() to help with enforcing this.
>
> Thanks for pointing this out, Peter! I guess for that I'll need to
> convert all read accesses and provide get_vm_flags() too? That will
> cause some additional churt (a quick search shows 801 hits over 248
> files) but maybe it's worth it? I think Michal suggested that too in
> another patch. Should I do that while we are at it?
Here's a trick I saw somewhere in the VFS:
union {
const vm_flags_t vm_flags;
vm_flags_t __private __vm_flags;
};
Now it can be read by anybody but written only by those using
ACCESS_PRIVATE.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-01-25 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230125083851.27759-1-surenb@google.com>
[not found] ` <20230125083851.27759-2-surenb@google.com>
2023-01-25 9:09 ` [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions Peter Zijlstra
[not found] ` <CAJuCfpEcVCZaCGzc-Wim25eaV5e6YG1YJAAdKwZ6JHViB0z8aw@mail.gmail.com>
2023-01-25 18:37 ` Matthew Wilcox [this message]
2023-01-25 18:33 ` Matthew Wilcox
[not found] ` <Y9JFFYjfJf9uDijE@kernel.org>
[not found] ` <Y9KTUw/04FmBVplw@kernel.org>
2023-01-26 15:09 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9F28J9njAtwifuL@casper.infradead.org \
--to=willy@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrii@kernel.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arjunroy@google.com \
--cc=axelrasmussen@google.com \
--cc=bhe@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=chao@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=devel@lists.orangefs.org \
--cc=dgilbert@interlog.com \
--cc=dhowells@redhat.com \
--cc=dimitri.sivanich@hpe.com \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=etnaviv@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gthelen@google.com \
--cc=gurua@google.com \
--cc=hannes@cmpxchg.org \
--cc=haojian.zhuang@gmail.com \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=hjc@rock-chips.com \
--cc=hughd@google.com \
--cc=hughlynch@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jannh@google.com \
--cc=jayalk@intworks.biz \
--cc=jejb@linux.ibm.com \
--cc=jglisse@google.com \
--cc=joelaf@google.com \
--cc=johannes@sipsolutions.net \
--cc=kasan-dev@googlegroups.com \
--cc=kent.overstreet@linux.dev \
--cc=kernel-team@android.com \
--cc=kexec@lists.infradead.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=l.stach@pengutronix.de \
--cc=ldufour@linux.ibm.com \
--cc=leewalsh@google.com \
--cc=liam.howlett@oracle.com \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lstoakes@gmail.com \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=michel@lespinasse.org \
--cc=mike.kravetz@oracle.com \
--cc=miklos@szeredi.hu \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=mripard@kernel.org \
--cc=mst@redhat.com \
--cc=muchun.song@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=npiggin@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=paulmck@kernel.org \
--cc=perex@perex.cz \
--cc=peterjung1337@gmail.com \
--cc=peterz@infradead.org \
--cc=posk@google.com \
--cc=punit.agrawal@bytedance.com \
--cc=qianweili@huawei.com \
--cc=quic_abhinavk@quicinc.com \
--cc=ray.huang@amd.com \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=robdclark@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=selinux@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=soheil@google.com \
--cc=songliubraving@fb.com \
--cc=sparclinux@vger.kernel.org \
--cc=sre@kernel.org \
--cc=surenb@google.com \
--cc=target-devel@vger.kernel.org \
--cc=tatashin@google.com \
--cc=tfiga@chromium.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=tomba@kernel.org \
--cc=tytso@mit.edu \
--cc=tzimmermann@suse.de \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiang@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).