From: Jiri Pirko <jiri@resnulli.us>
To: Parav Pandit <parav@nvidia.com>
Cc: "hawk@kernel.org" <hawk@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"mst@redhat.com" <mst@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH 2/2] virtio-net: Maintain reverse cleanup order
Date: Thu, 2 Feb 2023 16:46:39 +0100 [thread overview]
Message-ID: <Y9va33VLJ/eRPUbW@nanopsycho> (raw)
In-Reply-To: <PH0PR12MB5481C0C7E46B5DFF85178792DCD69@PH0PR12MB5481.namprd12.prod.outlook.com>
Thu, Feb 02, 2023 at 04:10:56PM CET, parav@nvidia.com wrote:
>
>> From: Jiri Pirko <jiri@resnulli.us>
>> Sent: Thursday, February 2, 2023 7:26 AM
>>
>> Thu, Feb 02, 2023 at 06:00:38AM CET, parav@nvidia.com wrote:
>> >To easily audit the code, better to keep the device stop() sequence to
>> >be mirror of the device open() sequence.
>> >
>> >Signed-off-by: Parav Pandit <parav@nvidia.com>
>>
>> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>>
>> If this is not fixing bug (which I believe is the case), you should target it to net-
>> next ([patch net-next] ..).
>>
>Yes. Right. First one was fix for net-rc, second was for net-next. And 2nd depends on the first to avoid merge conflicts.
>So, I was unsure how to handle it.
>Can you please suggest?
1) Send the fix to -net
2) Wait until -net is merged into -net-next
3) Send the second patch to -net-next
>
>
>>
>> >---
>> > drivers/net/virtio_net.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index
>> >b7d0b54c3bb0..1f8168e0f64d 100644
>> >--- a/drivers/net/virtio_net.c
>> >+++ b/drivers/net/virtio_net.c
>> >@@ -2279,9 +2279,9 @@ static int virtnet_close(struct net_device *dev)
>> > cancel_delayed_work_sync(&vi->refill);
>> >
>> > for (i = 0; i < vi->max_queue_pairs; i++) {
>> >+ virtnet_napi_tx_disable(&vi->sq[i].napi);
>> > napi_disable(&vi->rq[i].napi);
>> > xdp_rxq_info_unreg(&vi->rq[i].xdp_rxq);
>> >- virtnet_napi_tx_disable(&vi->sq[i].napi);
>> > }
>> >
>> > return 0;
>> >--
>> >2.26.2
>> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-02-02 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 5:00 [PATCH 0/2] virtio-net: close() to follow mirror of open() Parav Pandit via Virtualization
2023-02-02 5:00 ` [PATCH 1/2] virtio-net: Keep stop() to follow mirror sequence " Parav Pandit via Virtualization
2023-02-02 12:23 ` Jiri Pirko
2023-02-02 5:00 ` [PATCH 2/2] virtio-net: Maintain reverse cleanup order Parav Pandit
2023-02-02 12:26 ` Jiri Pirko
2023-02-02 15:10 ` Parav Pandit via Virtualization
2023-02-02 15:46 ` Jiri Pirko [this message]
2023-02-02 16:33 ` Parav Pandit via Virtualization
2023-02-02 10:56 ` [PATCH 0/2] virtio-net: close() to follow mirror of open() Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9va33VLJ/eRPUbW@nanopsycho \
--to=jiri@resnulli.us \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).