From: Dan Carpenter <dan.carpenter@oracle.com>
To: jasowang@redhat.com
Cc: virtualization@lists.linux-foundation.org
Subject: [bug report] vdpa: introduce virtio pci driver
Date: Thu, 25 Feb 2021 09:49:43 +0300 [thread overview]
Message-ID: <YDdIh3XRctsOAUkQ@mwanda> (raw)
Hello Jason Wang,
The patch 010eee82c84e: "vdpa: introduce virtio pci driver" from Feb
23, 2021, leads to the following static checker warning:
drivers/vdpa/virtio_pci/vp_vdpa.c:168 vp_vdpa_request_irq()
warn: inconsistent indenting
drivers/vdpa/virtio_pci/vp_vdpa.c
154 goto err;
155 }
156 vp_modern_queue_vector(mdev, i, i);
157 vp_vdpa->vring[i].irq = irq;
158 }
159
160 snprintf(vp_vdpa->msix_name, VP_VDPA_NAME_SIZE, "vp-vdpa[%s]-config\n",
161 pci_name(pdev));
162 irq = pci_irq_vector(pdev, queues);
163 ret = devm_request_irq(&pdev->dev, irq, vp_vdpa_config_handler, 0,
164 vp_vdpa->msix_name, vp_vdpa);
165 if (ret) {
166 dev_err(&pdev->dev,
167 "vp_vdpa: fail to request irq for vq %d\n", i);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Is this error message right?
168 goto err;
^^^^^^^^
indented too far
169 }
170 vp_modern_config_vector(mdev, queues);
171 vp_vdpa->config_irq = irq;
172
173 return 0;
174 err:
175 vp_vdpa_free_irq(vp_vdpa);
176 return ret;
177 }
regards,
dan carpenter
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
reply other threads:[~2021-02-25 6:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDdIh3XRctsOAUkQ@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jasowang@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).