From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0480C43460 for ; Thu, 15 Apr 2021 15:15:43 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55A0B6137D for ; Thu, 15 Apr 2021 15:15:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55A0B6137D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 198D5606FF; Thu, 15 Apr 2021 15:15:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bJl10FIyIX-0; Thu, 15 Apr 2021 15:15:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id B289E605E6; Thu, 15 Apr 2021 15:15:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9721EC000B; Thu, 15 Apr 2021 15:15:41 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id A17ECC000B for ; Thu, 15 Apr 2021 15:15:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8C8B4606FF for ; Thu, 15 Apr 2021 15:15:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TV9417KFhqNO for ; Thu, 15 Apr 2021 15:15:39 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by smtp3.osuosl.org (Postfix) with ESMTPS id BD084605E6 for ; Thu, 15 Apr 2021 15:15:39 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id v6so36121403ejo.6 for ; Thu, 15 Apr 2021 08:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QxiyvjJPiB2Y4EOeSIHNj8hpwn+sjnpoz3M6C8GXS3M=; b=O0nkOIGnpFaRAssZYNEIk81uAcj99Wr6/y7tBtzmDgplIx/bG+w0m5HpylOM7zKfbN uHn3xqBih8pNE6ArUg4Om7atp077ctzsa6CyhHJyhQiKgVR1YIyCqNZ2zJawoqZQknLM 0YNfVLQZibhE9gFjjIVn7ofmIVksXMbNlN1Fy59tLK9s0qzJvzEq1AnF21zJi/qW1RJq RggL57CInaeyYR+eDcRv42ciOo3LqmEDz9yohXCxuqgNXmaPFpDM2lIf8DrKkSrdEaSX z6gagP0hCqZ6QwMu8Jq0c5d5WVXasijwcqUBZl5c5Xo2PkimylvP68S576x+mLVNFtkT dPqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QxiyvjJPiB2Y4EOeSIHNj8hpwn+sjnpoz3M6C8GXS3M=; b=MwvXy2EWhUEZ7tS2OCWi6J8OaXZHUbhu/QiaD7xDsZ/PJPJHxfhs1pKRA6M36K3jFC descLU5YE92ZhCIVFJhfNCLLNZLtO6qUgFKnknq+SosAHqr21paoRUiLKZzEUOQrH9CX GGzyJkQ46NCmxHYX8djDHRec5lNuOtgJ9i/fym3xzYBbNqdERbYRFWw/oedBYhAxo8OE hgJBlGB5Wc1bQdkOGzjA76gFEB5Ll4Snlg7tilO0gKAJX6kAHopi9EVYwCiqhHTemxWF gAIP6Rj9P3+e+w2PKUOVR+PKBTzDFc7gc5Yvtg1DRWaIOdNxBq9UdrEYtxfDZTSzttzo Q4VQ== X-Gm-Message-State: AOAM530YrXa1wFx29J2Lx4rtf6csgqDb5nzUVotAQflR7y4He4RH5OW6 bmkGVfEHvpIwWJwVQBkCb8athw== X-Google-Smtp-Source: ABdhPJyfZaSsTEBlsYQzvBqBRq9S0zR0zrehiJ7ShidHNrcB2Rr4w/1VJiSlSEIhmoaqHLlfzben7g== X-Received: by 2002:a17:906:944c:: with SMTP id z12mr3857507ejx.398.1618499738021; Thu, 15 Apr 2021 08:15:38 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id bs10sm2854236edb.8.2021.04.15.08.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 08:15:37 -0700 (PDT) Date: Thu, 15 Apr 2021 17:15:18 +0200 From: Jean-Philippe Brucker To: "Michael S. Tsirkin" Subject: Re: [PATCH 3/3] iommu/virtio: Enable x86 support Message-ID: References: <20210316191652.3401335-1-jean-philippe@linaro.org> <20210316191652.3401335-4-jean-philippe@linaro.org> <20210318142709-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210318142709-mutt-send-email-mst@kernel.org> Cc: lorenzo.pieralisi@arm.com, eric.auger@redhat.com, robin.murphy@arm.com, joro@8bytes.org, rjw@rjwysocki.net, virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com, will@kernel.org, lenb@kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Mar 18, 2021 at 02:28:02PM -0400, Michael S. Tsirkin wrote: > On Tue, Mar 16, 2021 at 08:16:54PM +0100, Jean-Philippe Brucker wrote: > > With the VIOT support in place, x86 platforms can now use the > > virtio-iommu. > > > > The arm64 Kconfig selects IOMMU_DMA, while x86 IOMMU drivers select it > > themselves. > > > > Signed-off-by: Jean-Philippe Brucker > > Acked-by: Michael S. Tsirkin > > > --- > > drivers/iommu/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index 2819b5c8ec30..ccca83ef2f06 100644 > > --- a/drivers/iommu/Kconfig > > +++ b/drivers/iommu/Kconfig > > @@ -400,8 +400,9 @@ config HYPERV_IOMMU > > config VIRTIO_IOMMU > > tristate "Virtio IOMMU driver" > > depends on VIRTIO > > - depends on ARM64 > > + depends on (ARM64 || X86) > > select IOMMU_API > > + select IOMMU_DMA if X86 > > Would it hurt to just select unconditionally? Seems a bit cleaner > ... Yes I think I'll do this for the moment Thanks, Jean > > > select INTERVAL_TREE > > select ACPI_VIOT if ACPI > > help > > -- > > 2.30.2 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization