From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 675B3C433EF for ; Mon, 1 Nov 2021 16:21:35 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FD1361165 for ; Mon, 1 Nov 2021 16:21:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FD1361165 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E27D780C6D; Mon, 1 Nov 2021 16:21:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c8Bt4GGwFnHv; Mon, 1 Nov 2021 16:21:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id A7DC180C43; Mon, 1 Nov 2021 16:21:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 813AFC001E; Mon, 1 Nov 2021 16:21:33 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 91DEEC000E for ; Mon, 1 Nov 2021 16:21:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7382A80C7E for ; Mon, 1 Nov 2021 16:21:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NvlJu4MXAbAN for ; Mon, 1 Nov 2021 16:21:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id DA99080C43 for ; Mon, 1 Nov 2021 16:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=g4IfObkWcAJ4mvs2ONiuidAZEUQaazQjSNNGt8XybxZMaR43u+xuMeCJYHlhIKnnq77A5w MEX43WJiPTdk3PwDDLmghGTPtNAolYml7lStetlnKRDPVXEFQ8UY+YVQ1LYQskZpB3oGgJ 0d10ClBng5lXnwOVzd3jOk460xZ2GP8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-TcJVN5j3P3G6fgj8qYJNxw-1; Mon, 01 Nov 2021 12:21:28 -0400 X-MC-Unique: TcJVN5j3P3G6fgj8qYJNxw-1 Received: by mail-qv1-f71.google.com with SMTP id z8-20020a0cd788000000b00384d92a0f11so16739476qvi.17 for ; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=BwjIv2bz4+m8CgKS6f0rOl5F15+SSNHcwAiKfFH5P//Guwlu2WZ86FxllvG5pjYcG6 FCW4l5gvzaconWOJM3OBP8vGpV6A0dsUBMntXmei+AykiW/FqzN17ZpCArAzieQeneRD E3HH5VF2R+pMyfhqZ4ZjPZcI602uIK3a+jGNnPIWU6UnH+JtQ99Dow71c7btWg9MdZZS JrX+6vpHMSVPuG0mz3xt7odWgAc9z/LSVe1babJGaYIyWUW7f2remhsDOYxaPDaKToss gLg+lIN3catcCt932vokSV2cNt8LYoVGg3fkRXtQHEFpKnjhAXmq64zR6dUsFijGc5SW 75FA== X-Gm-Message-State: AOAM531d/bJg1yxGe20smI+TA6HtGIsf4DyblaahVfVwJUbWp9bKL6Xx K1lPNvwD3pNucUmK8fTci8nJaHBEnd+nv8tae/Bnd3KlWaj7UE132M5bYSzCAgpobKiIhRSsQtt 7Lusq/naAd+h/UkF0tdlxlKnK2v7eweHyQsnJK97C X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472041qtb.183.1635783688259; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXhGf8N2V91WU2Co6WJDyYs4GGgkn9JXnS/oEwWuG4J0RZNo7zMUQJUBh2KgjI9ZclpX5QJg== X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472009qtb.183.1635783688071; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id bj3sm2670847qkb.75.2021.11.01.09.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:21:27 -0700 (PDT) Date: Mon, 1 Nov 2021 12:21:26 -0400 From: Mike Snitzer To: Dan Williams Subject: Re: [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper Message-ID: References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-11-hch@lst.de> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=snitzer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Linux NVDIMM , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Oct 27 2021 at 9:41P -0400, Dan Williams wrote: > On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > > > Add a helper to perform the entire remapping for DAX accesses. This > > helper open codes bdev_dax_pgoff given that the alignment checks have > > already been done by the submitting file system and don't need to be > > repeated. > > Again, looks good. Kind of embarrassing when the open-coded version is > less LOC than using the helper. > > Mike, ack? Acked-by: Mike Snitzer _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization