From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB36FC433F5 for ; Mon, 29 Nov 2021 15:43:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 81F144019E; Mon, 29 Nov 2021 15:43:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 80Co5FV_MsJ2; Mon, 29 Nov 2021 15:43:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5DACE4010C; Mon, 29 Nov 2021 15:43:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 30D7BC0012; Mon, 29 Nov 2021 15:43:25 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 36FE7C000A for ; Mon, 29 Nov 2021 15:43:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2023A60A72 for ; Mon, 29 Nov 2021 15:43:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tjADVIc0PeRh for ; Mon, 29 Nov 2021 15:43:21 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5DC7560A81 for ; Mon, 29 Nov 2021 15:43:21 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id l16so37756694wrp.11 for ; Mon, 29 Nov 2021 07:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c1tPtK4234RzEJWdk1WuLUNOshhLfQVugRr+E/JBV7g=; b=g2iBnLzqE+SGysyAa+bTZmQuY2vqxlkuegiDpA1TflrERCuQyPkBS/gcIY+OW8xC97 aI8V/5mGz8nis/fl1rwHHXcq5+7Cj8DnrqKVyXHv+5X6f4nqiOOmYctZLU9wEIVh9jI9 y339j2x5j+cp3EvWpj1Xegqk2EYEWeeWw2b/R2u7GkJdrMetyUq+/DqvfgOtGSVHTEnQ 064lBcZ4X3h+G4+/lHPwG4biBSxXcuEWwKDzKjia2MbY04zt8+0sfr0XoQAMNyyYNI+G Et7XRWkzVbCYJt3ICPCTvZcbmuZkJ7KdWqun7A3PEECN8TJ4pPejUMPBXxqT03KH+Wd3 tJzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c1tPtK4234RzEJWdk1WuLUNOshhLfQVugRr+E/JBV7g=; b=jGx/oRqd3S3LXBuv3fyAugx/gKtsQQmYLdWeRB/KSZPsYO4TGqbf2Kt2nqmj+jFBR8 fOhe7JOWMQ1KWNi9JI4/6l/U53C1pfB6Z8xYT6ZCcnMtKmkweDjlVC/QFIY0mRBUTzP9 bkUplYWGv1T5S2eGkf7k2bSrLahTxT6h1y2pOKHQySTslxFp0YG/Af1PZR1wIyODhfsD 4xicwG4wv5lN0w7/aY310KPuppnNH1RROObEwPDPiRL1f33pbSAWkXGnpiGgZ7R/u/j+ erJjKka/1dvlWyiZ1cyBKXZv4jZUFQ2/P7i/748ntjw5ENjl4JvO1p17dHig/AOer54V NT2Q== X-Gm-Message-State: AOAM532s2d2epfcjwpcPrkijWzhHXn+fP7PIAuoKDJZPb/QqjGIJDAn3 o3XEUPAbjVYzxFWVtf+HTF095Q== X-Google-Smtp-Source: ABdhPJwKBmo1MmuxbifKQZpvxvwmsEEyZ57GieBhblMgmCSXKl2ODJEBwBMGXXvNmg5uMFFU0yAMbw== X-Received: by 2002:a05:6000:188b:: with SMTP id a11mr33970909wri.326.1638200599356; Mon, 29 Nov 2021 07:43:19 -0800 (PST) Received: from myrica (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id p5sm14473848wrd.13.2021.11.29.07.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 07:43:18 -0800 (PST) Date: Mon, 29 Nov 2021 15:42:56 +0000 From: Jean-Philippe Brucker To: "Michael S. Tsirkin" Subject: Re: [PATCH v2 4/5] iommu/virtio: Pass end address to viommu_add_mapping() Message-ID: References: <20211123155301.1047943-1-jean-philippe@linaro.org> <20211123155301.1047943-5-jean-philippe@linaro.org> <7b79fe9b-9d51-8bda-2868-b48781f07fc9@redhat.com> <20211127180742-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211127180742-mutt-send-email-mst@kernel.org> Cc: joro@8bytes.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, pasic@linux.ibm.com, Eric Auger , iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com, will@kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Sat, Nov 27, 2021 at 06:09:56PM -0500, Michael S. Tsirkin wrote: > > > -static int viommu_add_mapping(struct viommu_domain *vdomain, unsigned long iova, > > > - phys_addr_t paddr, size_t size, u32 flags) > > > +static int viommu_add_mapping(struct viommu_domain *vdomain, u64 iova, u64 end, > > > + phys_addr_t paddr, u32 flags) > > > { > > > unsigned long irqflags; > > > struct viommu_mapping *mapping; > > I am worried that API changes like that will cause subtle > bugs since types of arguments change but not their > number. If we forgot to update some callers it will all be messed up. > > How about passing struct Range instead? I gave struct range a try but it looks messier overall since it would only be used to pass arguments. I think the update is safe enough because there is one caller for viommu_add_mapping() and two for viommu_del_mappings(), at the moment. Thanks, Jean _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization