Linux virtualization list
 help / color / mirror / Atom feed
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: mst@redhat.com, joro@8bytes.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, pasic@linux.ibm.com,
	iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com,
	will@kernel.org
Subject: Re: [PATCH v2 1/5] iommu/virtio: Add definitions for VIRTIO_IOMMU_F_BYPASS_CONFIG
Date: Mon, 29 Nov 2021 15:33:08 +0000	[thread overview]
Message-ID: <YaTytI6P3/HEwVrQ@myrica> (raw)
In-Reply-To: <b9068111-bc1e-cc0a-155d-04585d6f4138@redhat.com>

Hi Eric,

On Sat, Nov 27, 2021 at 08:59:25AM +0100, Eric Auger wrote:
> > @@ -36,6 +37,8 @@ struct virtio_iommu_config {
> >  	struct virtio_iommu_range_32		domain_range;
> >  	/* Probe buffer size */
> >  	__le32					probe_size;
> > +	__u8					bypass;
> > +	__u8					reserved[7];
> in [PATCH v3] virtio-iommu: Rework the bypass feature I see
> 
> +  u8 bypass;
> +  u8 reserved[3];
> 
> What was exactly voted?

Good catch, this should be 3. It brings the config struct to 40 bytes,
which is the size compilers generate when there is no reserved field.

Thanks,
Jean
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2021-11-29 15:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 15:52 [PATCH v2 0/5] iommu/virtio: Add identity domains Jean-Philippe Brucker
2021-11-23 15:52 ` [PATCH v2 1/5] iommu/virtio: Add definitions for VIRTIO_IOMMU_F_BYPASS_CONFIG Jean-Philippe Brucker
2021-11-27  7:59   ` Eric Auger
2021-11-29 15:33     ` Jean-Philippe Brucker [this message]
2021-11-23 15:52 ` [PATCH v2 2/5] iommu/virtio: Support bypass domains Jean-Philippe Brucker
2021-11-27 16:18   ` Eric Auger
2021-11-29 15:36     ` Jean-Philippe Brucker
2021-11-23 15:53 ` [PATCH v2 3/5] iommu/virtio: Sort reserved regions Jean-Philippe Brucker
2021-11-27 17:09   ` Eric Auger
2021-11-23 15:53 ` [PATCH v2 4/5] iommu/virtio: Pass end address to viommu_add_mapping() Jean-Philippe Brucker
2021-11-27 17:09   ` Eric Auger
2021-11-27 23:09     ` Michael S. Tsirkin
2021-11-29 15:42       ` Jean-Philippe Brucker
2021-11-23 15:53 ` [PATCH v2 5/5] iommu/virtio: Support identity-mapped domains Jean-Philippe Brucker
2021-11-27 17:09   ` Eric Auger
2021-11-29 15:44     ` Jean-Philippe Brucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaTytI6P3/HEwVrQ@myrica \
    --to=jean-philippe@linaro.org \
    --cc=eric.auger@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=sebastien.boeuf@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox