* Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
[not found] <20211229004913.513372-1-kuba@kernel.org>
@ 2021-12-29 1:33 ` Florian Fainelli
[not found] ` <20211229092012.635e9f2b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
2021-12-29 14:05 ` Stefano Garzarella
2021-12-29 16:51 ` Alexei Starovoitov
2 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2021-12-29 1:33 UTC (permalink / raw)
To: Jakub Kicinski, ast, daniel
Cc: andrew, mustafa.ismail, linux-wireless, ath11k, pablo, andrii,
george.mccollister, anthony.l.nguyen, ralf, linux-hams, hawk,
steffen.klassert, linux-s390, pkshih, herbert, leon,
linux-bluetooth, linux-rdma, bridge, john.fastabend, kadlec, jgg,
dledford, coreteam, intel-wired-lan, nikolay, habetsm.xilinx,
yzaikin, vivien.didelot, wg, woojung.huh, johan.hedberg, arnd,
marcel, jhs, linux-can, wenjia, Marc Kleine-Budde, viro,
luiz.dentz, jiri, xiyou.wangcong, michael.chan, virtualization,
shiraz.saleem, trond.myklebust, kvalo, linux-nfs, wintera,
keescook, netdev, dsahern, linux-decnet-user, fw, tariqt, kgraul,
ecree.xilinx, mcgrof, netfilter-devel, jreuter, linux-fsdevel,
bpf, olteanv, saeedm, anna.schumaker, ap420073
On 12/28/2021 4:49 PM, Jakub Kicinski wrote:
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
>
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
It would be nice if we used the number of files rebuilt because of a
header file change as another metric that the kernel is evaluated with
from release to release (or even on a commit by commit basis). Food for
thought.
--
Florian
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
[not found] <20211229004913.513372-1-kuba@kernel.org>
2021-12-29 1:33 ` [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Florian Fainelli
@ 2021-12-29 14:05 ` Stefano Garzarella
2021-12-29 16:51 ` Alexei Starovoitov
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2021-12-29 14:05 UTC (permalink / raw)
To: Jakub Kicinski
Cc: wintera, andrew, mustafa.ismail, pablo, ast, andrii,
george.mccollister, anthony.l.nguyen, ralf, linux-hams, hawk,
steffen.klassert, linux-s390, pkshih, f.fainelli, herbert, daniel,
linux-bluetooth, linux-rdma, bridge, john.fastabend, kadlec, jgg,
dledford, coreteam, intel-wired-lan, nikolay, linux-wireless,
habetsm.xilinx, yzaikin, vivien.didelot, wg, ath11k, woojung.huh,
johan.hedberg, arnd, marcel, jhs, linux-can, wenjia,
Marc Kleine-Budde, viro, luiz.dentz, jiri, xiyou.wangcong,
michael.chan, virtualization, shiraz.saleem, trond.myklebust,
kvalo, linux-nfs, leon, keescook, netdev, dsahern,
linux-decnet-user, fw, tariqt, kgraul, ecree.xilinx, mcgrof,
netfilter-devel, jreuter, linux-fsdevel, bpf, olteanv, saeedm,
anna.schumaker, ap420073
On Tue, Dec 28, 2021 at 04:49:13PM -0800, Jakub Kicinski wrote:
>sock.h is pretty heavily used (5k objects rebuilt on x86 after
>it's touched). We can drop the include of filter.h from it and
>add a forward declaration of struct sk_filter instead.
>This decreases the number of rebuilt objects when bpf.h
>is touched from ~5k to ~1k.
>
>There's a lot of missing includes this was masking. Primarily
>in networking tho, this time.
>
>Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>---
>v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/
> - fix build in bond on ia64
> - fix build in ip6_fib with randconfig
For AF_VSOCK:
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
[not found] <20211229004913.513372-1-kuba@kernel.org>
2021-12-29 1:33 ` [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Florian Fainelli
2021-12-29 14:05 ` Stefano Garzarella
@ 2021-12-29 16:51 ` Alexei Starovoitov
2 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2021-12-29 16:51 UTC (permalink / raw)
To: Jakub Kicinski
Cc: wintera, Andrew Lunn, mustafa.ismail, Pablo Neira Ayuso, ath11k,
Alexei Starovoitov, Andrii Nakryiko, george.mccollister,
anthony.l.nguyen, Ralf Baechle, linux-hams,
Jesper Dangaard Brouer, Steffen Klassert, linux-s390, pkshih,
Florian Fainelli, Herbert Xu, Daniel Borkmann, linux-bluetooth,
linux-rdma, moderated list:ETHERNET BRIDGE, John Fastabend,
Jozsef Kadlecsik, Jason Gunthorpe, Doug Ledford, coreteam,
intel-wired-lan, nikolay, linux-wireless, habetsm.xilinx,
Iurii Zaikin, vivien.didelot, wg, woojung.huh, johan.hedberg,
Arnd Bergmann, marcel, Jamal Hadi Salim, linux-can, wenjia,
Marc Kleine-Budde, Alexander Viro, luiz.dentz, jiri, Cong Wang,
Michael Chan, virtualization, shiraz.saleem, trond.myklebust,
kvalo, linux-nfs, Leon Romanovsky, Kees Cook, Network Development,
David Ahern, linux-decnet-user, Florian Westphal, Tariq Toukan,
kgraul, ecree.xilinx, Luis R. Rodriguez, netfilter-devel, jreuter,
Linux-Fsdevel, bpf, olteanv, saeedm, anna.schumaker, Taehee Yoo
On Tue, Dec 28, 2021 at 4:49 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
>
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/
> - fix build in bond on ia64
> - fix build in ip6_fib with randconfig
Nice! Applied. Thanks
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
[not found] ` <20211229092012.635e9f2b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
@ 2022-01-04 15:42 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-01-04 15:42 UTC (permalink / raw)
To: Jakub Kicinski, mingo
Cc: linux-s390, linux-nfs, Florian Fainelli, netfilter-devel, daniel,
linux-rdma, netdev, bridge, linux-wireless, ast, linux-can,
linux-bluetooth, coreteam, intel-wired-lan, linux-fsdevel,
linux-hams, bpf, virtualization, ath11k, linux-decnet-user
On Wed, Dec 29, 2021 at 09:20:12AM -0800, Jakub Kicinski wrote:
> On Tue, 28 Dec 2021 17:33:39 -0800 Florian Fainelli wrote:
> > It would be nice if we used the number of files rebuilt because of a
> > header file change as another metric that the kernel is evaluated with
> > from release to release (or even on a commit by commit basis). Food for
> > thought.
>
> Maybe Andy has some thoughts, he has been working on dropping
> unnecessary includes of kernel.h, it seems.
With this [1] announcement I believe Ingo is the best to tell you if this is a
right direction.
> It'd be cool to plug something that'd warn us about significant
> increases in dependencies into the patchwork build bot.
>
> I have one more small series which un-includes uapi/bpf.h from
> netdevice.h at which point I hope we'll be largely in the clear
> from build bot performance perspective.
[1]: https://lore.kernel.org/lkml/YdIfz+LMewetSaEB@gmail.com/T/#u
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-04 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211229004913.513372-1-kuba@kernel.org>
2021-12-29 1:33 ` [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Florian Fainelli
[not found] ` <20211229092012.635e9f2b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
2022-01-04 15:42 ` Andy Shevchenko
2021-12-29 14:05 ` Stefano Garzarella
2021-12-29 16:51 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).