From: Luis Chamberlain <mcgrof@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
mst@redhat.com, jasowang@redhat.com, xieyongji@bytedance.com,
dan.carpenter@oracle.com, elic@nvidia.com, parav@nvidia.com,
guanjun@linux.alibaba.com
Cc: Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org, lkp@lists.01.org,
Julius Hemanth Pitti <jpitti@cisco.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Johannes Weiner <hannes@cmpxchg.org>,
kernel test robot <oliver.sang@intel.com>,
Ingo Molnar <mingo@elte.hu>, Iurii Zaikin <yzaikin@google.com>,
Eli Cohen <elic@nvidia.com>,
lkp@intel.com
Subject: Re: [proc/sysctl] 1dd38979b2: BUG:kernel_NULL_pointer_dereference,address
Date: Mon, 25 Apr 2022 21:24:56 -0700 [thread overview]
Message-ID: <Ymd0GIf3Ieh3DRcg@bombadil.infradead.org> (raw)
In-Reply-To: <Ymc1Zn8BbQMbjb58@bombadil.infradead.org>
On Mon, Apr 25, 2022 at 04:57:26PM -0700, Luis Chamberlain wrote:
> On Mon, Apr 25, 2022 at 04:34:34PM -0700, Andrew Morton wrote:
> > On Mon, 25 Apr 2022 16:08:57 -0700 Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > > On Mon, Apr 25, 2022 at 02:46:07PM -0700, Andrew Morton wrote:
> > > > On Mon, 25 Apr 2022 12:00:21 -0700 Luis Chamberlain <mcgrof@kernel.org> wrote:
> > > >
> > > > > Andrew, can we drop this patch for now?
> > > >
> > > > I've been sitting on (ie, forgotten about) this patch
> > > > (https://lore.kernel.org/all/20200709235115.56954-1-jpitti@cisco.com/T/#u)
> > >
> > > Jesh, yeah I see.
> > >
> > > > for two years. Evidently waiting for you/Kees/Ingo to provide
> > > > guidance. So sure, the need seems very unurgent so I can drop it.
> > >
> > > Well Keew as OK with it, but I yeah I can't decipher the issue at this
> > > point in time.
> > >
> > > > However I fail to see how that patch could have caused this crash. I'm
> > > > suspecting a bisection error?
> > > >
> > > > Maybe something is unwell in drivers/vdpa/vdpa_user/vduse_dev.c.
> > >
> > > At a quick glance, yes it could very well by vduse_init() is messy and
> > > races somehow with init, but if a race does lurk here my instincts tell
> > > me this can't be the only place.
> > >
> > > Not sure if leaving a patch in place more time to see how else things
> > > can explode is worth it.
> >
> > Confused. Are you thinking that the above-linked patch was somehow
> > involved in this crash? If so, but how? All it does it to permit
> > unprivileged reads to four ints via proc_dointvec_minmax()?
>
> If the priv allows for it access to dereferencing a pointer is allowed.
> How that race happens though, indeed is beyond the patch's fault.
Even so, I am 99.99% sure this is a driver bug then. And so if enabling
this patch just enables more driver bugs so be it.
So driver maintainers: please take a look, I tried to check but
the driver bug is not obvious to me yet.
Luis
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
parent reply other threads:[~2022-04-26 4:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <Ymc1Zn8BbQMbjb58@bombadil.infradead.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymd0GIf3Ieh3DRcg@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=elic@nvidia.com \
--cc=guanjun@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=jasowang@redhat.com \
--cc=jpitti@cisco.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=oliver.sang@intel.com \
--cc=parav@nvidia.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).