From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4E4BC433F5 for ; Mon, 2 May 2022 19:41:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 458B46059E; Mon, 2 May 2022 19:41:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VHAexRQ-K42h; Mon, 2 May 2022 19:41:36 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id AF116600CB; Mon, 2 May 2022 19:41:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 846F9C0032; Mon, 2 May 2022 19:41:35 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 018D9C002D for ; Mon, 2 May 2022 19:41:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D48BF4015D for ; Mon, 2 May 2022 19:41:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=ideasonboard.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CU0bxwkAHXKc for ; Mon, 2 May 2022 19:41:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by smtp2.osuosl.org (Postfix) with ESMTPS id 34C0040133 for ; Mon, 2 May 2022 19:41:32 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E27C1484; Mon, 2 May 2022 21:41:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1651520489; bh=7fS1iDiQS0BFHXb6Blv7uJsVuEU2kQ6EnwifQcIZAzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L6vTOnaYs7l4Xlv3+utCAZq5wLz1L8z9dE5E8+De/yg2+Pma+zdmoo/867c5Ze76+ exCdf2KgzXrGOkXEsHqhG4eyuJpbCE1tqzVXQPVbHV8+oMRr0hcpp/eZbX9GD6wYiL rZ001sxYlJkkZ4F/yveoIbAQI0FZ6+DVNlid2hh0= Date: Mon, 2 May 2022 22:41:28 +0300 From: Laurent Pinchart To: Javier Martinez Canillas Subject: Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() Message-ID: References: <20220502153900.408522-1-javierm@redhat.com> <20220502153900.408522-2-javierm@redhat.com> <5dd80287-1b09-d02c-9f67-5a0bb0a4566c@redhat.com> <21db3772-b85a-59ff-df17-9056b3099977@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <21db3772-b85a-59ff-df17-9056b3099977@redhat.com> Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann , virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, May 02, 2022 at 09:28:45PM +0200, Javier Martinez Canillas wrote: > On 5/2/22 20:36, Laurent Pinchart wrote: > > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: > >> On 5/2/22 18:55, Javier Martinez Canillas wrote: > >> > >> [snip] > >> > >>>> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME > >>>> comment in drm_fbdev_generic_setup() that could be related. > >>> > >>> A FIXME makes sense, I'll add that to when posting a v3. > >> > >> There's actually a FIXME already in drm_fbdev_generic_setup(), so it's > >> a documented issue [0]: > > > > That's what I meant by "there's a FIXME" :-) It doesn't have to be > > addressed by this series, but it would be good to fix it. > > doh, I misread your original email. Yes, it's the same issue as you > said and something that I plan to look at some point as a follow-up. > > I hope that we could just replace fbcon with a kms/systemd-consoled/foo > user-space implementation before fixing all the stuff in the DRM fbdev > emulation layer :) If you can do that, I'll provide champagne :-) -- Regards, Laurent Pinchart _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization