Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs

Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs

[Stefan Hajnoczi]

[-- Attachment #1.1: Type: text/plain, Size: 323 bytes --]

On Thu, Jun 09, 2022 at 10:08:38PM -0400, Deming Wang wrote:
> fs parameter not used. So, it needs to be deleted.
> 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
>  fs/fuse/virtio_fs.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs

[Vivek Goyal]

On Thu, Jun 09, 2022 at 10:08:38PM -0400, Deming Wang wrote:
> fs parameter not used. So, it needs to be deleted.
> 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>

Thanks Deming Wang for the patch. Good cleanup.

Reviewed-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

> ---
>  fs/fuse/virtio_fs.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 8db53fa67359..0991199d19c1 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -741,8 +741,7 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,
>  }
>  
>  /* Free virtqueues (device must already be reset) */
> -static void virtio_fs_cleanup_vqs(struct virtio_device *vdev,
> -				  struct virtio_fs *fs)
> +static void virtio_fs_cleanup_vqs(struct virtio_device *vdev)
>  {
>  	vdev->config->del_vqs(vdev);
>  }
> @@ -895,7 +894,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
>  
>  out_vqs:
>  	virtio_reset_device(vdev);
> -	virtio_fs_cleanup_vqs(vdev, fs);
> +	virtio_fs_cleanup_vqs(vdev);
>  	kfree(fs->vqs);
>  
>  out:
> @@ -927,7 +926,7 @@ static void virtio_fs_remove(struct virtio_device *vdev)
>  	virtio_fs_stop_all_queues(fs);
>  	virtio_fs_drain_all_queues_locked(fs);
>  	virtio_reset_device(vdev);
> -	virtio_fs_cleanup_vqs(vdev, fs);
> +	virtio_fs_cleanup_vqs(vdev);
>  
>  	vdev->priv = NULL;
>  	/* Put device reference on virtio_fs object */
> -- 
> 2.27.0
> 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization