* Re: [PATCH] net: move from strlcpy with unused retval to strscpy
[not found] <20220818210050.7108-1-wsa+renesas@sang-engineering.com>
@ 2022-08-19 15:45 ` Tom Lendacky via Virtualization
2022-08-21 11:39 ` Leon Romanovsky
1 sibling, 0 replies; 2+ messages in thread
From: Tom Lendacky via Virtualization @ 2022-08-19 15:45 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: Andrew Lunn, Shyam Sundar S K, Kevin Brace, David Dillow,
Somnath Kotur, Rafał Miłecki, linux-stm32,
Andy Gospodarek, Wei Liu, Manish Chopra, Samuel Holland,
Michael Ellerman, Madalin Bucur, Christian Lamparter,
Michal Simek, Christophe Leroy, Jose Abreu, Radhey Shyam Pandey,
Franky Lin, Mark Lee, Chris Lee, Nick Child, Jiri Pirko,
Jay Vosburgh, Vinay Kumar Yadav, Arend van Spriel,
Nicholas Piggin, Igor Mitsyanko, Krzysztof Halasa, Shay Agroskin,
linux-omap, Petr Machata, libertas-dev, Rasesh Mody,
Ilias Apalodimas, Douglas Miller, Joakim Zhang, Ralf Baechle,
Vivien Didelot, Ion Badulescu, Hartley Sweeten,
Stanislav Yakovlev, Jon Mason, Vladimir Oltean, Claudiu Beznea,
Christian Benvenuti, Samuel Chessman, linux-usb, Ronak Doshi,
Kunihiko Hayashi, Chris Snook, Denis Kirjanov,
Prashant Sreedharan, virtualization, Daniele Venzano,
Eric Dumazet, Zhu Yanjun, Tony Nguyen, Pantelis Antoniou,
Arthur Kiyanovski, Leon Romanovsky, David S. Miller,
Sergey Matyukevich, Jesse Brandeburg, Rain River,
Veaceslav Falico, Martin Habets, Yisen Zhuang,
Wolfgang Grandegger, Steve Glendinning, Michael Hennerich,
Ido Schimmel, Sean Wang, linuxppc-dev, linux-can,
Siva Reddy Kallam, Claudiu Manoil, Doug Berger, Simon Kelley,
Giuseppe Cavallaro, linux-arm-kernel, Mirko Lindner,
Sriharsha Basavapatna, Nicolas Pitre, David Arinzon,
Rohit Maheshwari, Tariq Toukan, Sudarsana Kalluru, Taras Chornyi,
Maxime Coquelin, linux-mediatek, Heiner Kallweit, linux-wireless,
Ajit Khaparde, Petko Manolov, Andreas Larsson, Kurt Kanzenbach,
linux-hyperv, oss-drivers, netdev, Subbaraya Sundeep,
Hin-Tak Leung, Jassi Brar, Noam Dagan, Stanislaw Gruszka,
Ajay Singh, Florian Fainelli, Dave Jiang, linux-rdma,
Guo-Fu Tseng, Dexuan Cui, Jernej Skrabec, Chen-Yu Tsai,
Broadcom internal kernel review list, b43-dev, Simon Horman,
Paolo Abeni, Allen Hubbe, Shahed Shaikh, Grygorii Strashko,
Byungho An, Haiyang Zhang, Francois Romieu, Hante Meuleman,
Vladimir Zapolskiy, Don Fry, John Crispin, Michael Chan,
Ishizaki Kou, Salil Mehta, GR-Linux-NIC-Dev, linux-parisc,
Geoff Levand, linux-sunxi, Edward Cree, Bryan Whitehead,
Saeed Bishara, Mark Einon, Geetha sowjanya, Oliver Neukum,
Michael S. Tsirkin, VMware PV-Drivers Reviewers, Ioana Ciornei,
Alexandre Torgue, Govindarajulu Varadarajan, Thomas Petazzoni,
Ayush Sawal, UNGLinuxDriver, linux-acenic,
Herton Ronaldo Krzesinski, Rahul Verma, Russell King,
SHA-cyfmac-dev-list, Lino Sanfilippo, intel-wired-lan,
Jakub Kicinski, Steffen Klassert, Sunil Goutham,
Sebastian Hesselbarth, Jes Sorensen, nic_swsd, Ariel Elior,
Jouni Malinen, Kalle Valo, Marc Kleine-Budde, Matthias Brugger,
Marcin Wojtas, brcm80211-dev-list.pdl, Sridhar Samudrala,
David Ahern, linux-mips, Li Yang, Stephen Hemminger, hariprasad,
ntb, Raju Rangoju, Larry Finger, Saeed Mahameed, Felix Fietkau
On 8/18/22 16:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> index 6ceb1cdf6eba..6e83ff59172a 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> @@ -402,8 +402,8 @@ static void xgbe_get_drvinfo(struct net_device *netdev,
> struct xgbe_prv_data *pdata = netdev_priv(netdev);
> struct xgbe_hw_features *hw_feat = &pdata->hw_feat;
>
> - strlcpy(drvinfo->driver, XGBE_DRV_NAME, sizeof(drvinfo->driver));
> - strlcpy(drvinfo->bus_info, dev_name(pdata->dev),
> + strscpy(drvinfo->driver, XGBE_DRV_NAME, sizeof(drvinfo->driver));
> + strscpy(drvinfo->bus_info, dev_name(pdata->dev),
> sizeof(drvinfo->bus_info));
> snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), "%d.%d.%d",
> XGMAC_GET_BITS(hw_feat->version, MAC_VR, USERVER),
For drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net: move from strlcpy with unused retval to strscpy
[not found] <20220818210050.7108-1-wsa+renesas@sang-engineering.com>
2022-08-19 15:45 ` [PATCH] net: move from strlcpy with unused retval to strscpy Tom Lendacky via Virtualization
@ 2022-08-21 11:39 ` Leon Romanovsky
1 sibling, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-08-21 11:39 UTC (permalink / raw)
To: Wolfram Sang
Cc: Andrew Lunn, Shyam Sundar S K, Kevin Brace, David Dillow,
Somnath Kotur, Rafał Miłecki, linux-stm32,
Andy Gospodarek, Wei Liu, Manish Chopra, Samuel Holland,
Michael Ellerman, Madalin Bucur, Christian Lamparter,
Michal Simek, Christophe Leroy, Jose Abreu, Radhey Shyam Pandey,
Franky Lin, Mark Lee, Chris Lee, Nick Child, Jiri Pirko,
Jay Vosburgh, Vinay Kumar Yadav, Arend van Spriel,
Nicholas Piggin, Igor Mitsyanko, Krzysztof Halasa, Shay Agroskin,
linux-omap, Petr Machata, libertas-dev, Rasesh Mody,
Ilias Apalodimas, Douglas Miller, Joakim Zhang, Ralf Baechle,
Vivien Didelot, Ion Badulescu, Hartley Sweeten,
Stanislav Yakovlev, Jon Mason, Vladimir Oltean, Claudiu Beznea,
Christian Benvenuti, Samuel Chessman, linux-usb, Ronak Doshi,
Kunihiko Hayashi, Chris Snook, Denis Kirjanov,
Prashant Sreedharan, linux-kernel, Daniele Venzano, Eric Dumazet,
Zhu Yanjun, Tony Nguyen, Pantelis Antoniou, Arthur Kiyanovski,
David S. Miller, Sergey Matyukevich, Jesse Brandeburg, Rain River,
Veaceslav Falico, Martin Habets, Yisen Zhuang,
Wolfgang Grandegger, Steve Glendinning, Tom Lendacky,
Michael Hennerich, Ido Schimmel, Sean Wang, linuxppc-dev,
linux-can, Siva Reddy Kallam, Claudiu Manoil, Doug Berger,
Simon Kelley, Giuseppe Cavallaro, linux-arm-kernel, Mirko Lindner,
Sriharsha Basavapatna, Nicolas Pitre, David Arinzon,
Rohit Maheshwari, Tariq Toukan, Sudarsana Kalluru, Taras Chornyi,
Maxime Coquelin, linux-mediatek, Heiner Kallweit, linux-wireless,
Ajit Khaparde, Petko Manolov, Andreas Larsson, Kurt Kanzenbach,
linux-hyperv, oss-drivers, netdev, Subbaraya Sundeep,
Hin-Tak Leung, Jassi Brar, Noam Dagan, Stanislaw Gruszka,
Ajay Singh, Florian Fainelli, Dave Jiang, linux-rdma,
Guo-Fu Tseng, Dexuan Cui, Jernej Skrabec, Chen-Yu Tsai,
Broadcom internal kernel review list, b43-dev, Simon Horman,
Paolo Abeni, Allen Hubbe, Shahed Shaikh, Grygorii Strashko,
Byungho An, Haiyang Zhang, Francois Romieu, Hante Meuleman,
Vladimir Zapolskiy, Don Fry, John Crispin, Michael Chan,
virtualization, Ishizaki Kou, Salil Mehta, GR-Linux-NIC-Dev,
linux-parisc, Geoff Levand, linux-sunxi, Edward Cree,
Bryan Whitehead, Saeed Bishara, Mark Einon, Geetha sowjanya,
Oliver Neukum, Michael S. Tsirkin, VMware PV-Drivers Reviewers,
Ioana Ciornei, Alexandre Torgue, Govindarajulu Varadarajan,
Thomas Petazzoni, Ayush Sawal, UNGLinuxDriver, linux-acenic,
Herton Ronaldo Krzesinski, Rahul Verma, Russell King,
SHA-cyfmac-dev-list, Lino Sanfilippo, intel-wired-lan,
Jakub Kicinski, Steffen Klassert, Sunil Goutham,
Sebastian Hesselbarth, Jes Sorensen, nic_swsd, Ariel Elior,
Jouni Malinen, Kalle Valo, Marc Kleine-Budde, Matthias Brugger,
Marcin Wojtas, brcm80211-dev-list.pdl, Sridhar Samudrala,
David Ahern, linux-mips, Li Yang, Stephen Hemminger, hariprasad,
ntb, Raju Rangoju, Larry Finger, Saeed Mahameed, Felix Fietkau
On Thu, Aug 18, 2022 at 11:00:34PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
<...>
> drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +++---
> drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
> .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++--
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
> .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +-
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread