From: Joerg Roedel <joro@8bytes.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: linux-s390@vger.kernel.org, marcan@marcan.st,
mjrosato@linux.ibm.com, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, will@kernel.org, alyssa@rosenzweig.io,
jean-philippe@linaro.org, kvm@vger.kernel.org,
zhang.lyra@gmail.com, jon@solid-run.com, jonathanh@nvidia.com,
iommu@lists.linux.dev, Nicolin Chen <nicolinc@nvidia.com>,
yangyingliang@huawei.com, orsonzhai@gmail.com,
gerald.schaefer@linux.ibm.com, sven@svenpeter.dev,
linux-arm-msm@vger.kernel.org, vdumpa@nvidia.com,
christophe.jaillet@wanadoo.fr, baolin.wang@linux.alibaba.com,
thunder.leizhen@huawei.com, linux-tegra@vger.kernel.org,
tglx@linutronix.de, virtualization@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, dwmw2@infradead.org,
cohuck@redhat.com, shameerali.kolothum.thodi@huawei.com,
robdclark@gmail.com, asahi@lists.linux.dev,
suravee.suthikulpanit@amd.com, robin.murphy@arm.com,
baolu.lu@linux.intel.com
Subject: Re: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group
Date: Wed, 7 Sep 2022 16:06:29 +0200 [thread overview]
Message-ID: <YxilZbRL0WBR97oi@8bytes.org> (raw)
In-Reply-To: <Yxig+zfA2Pr4vk6K@nvidia.com>
On Wed, Sep 07, 2022 at 10:47:39AM -0300, Jason Gunthorpe wrote:
> Would you be happier if we wrote it like
>
> #define IOMMU_EINCOMPATIBLE_DEVICE xx
>
> Which tells "which of the function parameters is actually invalid" ?
Having done some Rust hacking in the last months, I have to say I like
to concept of error handling with Result<> there. Ideally we have a way
to emulate that in our C code without having to change all callers.
What I am proposing is a way this could be emulated here, but I am open
to other suggestions. Still better than re-using random error codes for
special purposes.
Regards,
Joerg
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-09-07 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220815181437.28127-1-nicolinc@nvidia.com>
[not found] ` <20220815181437.28127-2-nicolinc@nvidia.com>
2022-09-07 12:41 ` [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Joerg Roedel
[not found] ` <Yxig+zfA2Pr4vk6K@nvidia.com>
2022-09-07 14:06 ` Joerg Roedel [this message]
[not found] ` <YxjQiVnpU0dr7SHC@nvidia.com>
2022-09-08 13:28 ` Joerg Roedel
[not found] ` <YxoU8lw+qIw9woRL@nvidia.com>
[not found] ` <YxqwQ+3OICPdEtk0@Asurada-Nvidia>
2022-09-09 5:00 ` Tian, Kevin
[not found] ` <YxsshXKlidq8WgT+@nvidia.com>
2022-09-13 2:22 ` Tian, Kevin
2022-09-07 14:23 ` Robin Murphy
[not found] ` <YxjOPo5FFqu2vE/g@nvidia.com>
2022-09-07 19:41 ` Robin Murphy
[not found] ` <Yxk6sR4JiAAn3Jf5@nvidia.com>
2022-09-08 9:30 ` Tian, Kevin
[not found] ` <YxnbRq5vaP/OL0ra@nvidia.com>
[not found] ` <Yx0fVJpaojM5RNR4@Asurada-Nvidia>
2022-09-13 2:24 ` Tian, Kevin
2022-09-08 9:54 ` Tian, Kevin
2022-09-08 10:25 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxilZbRL0WBR97oi@8bytes.org \
--to=joro@8bytes.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=baolu.lu@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=jon@solid-run.com \
--cc=jonathanh@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).