From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: jgross@suse.com, ajay.kaher@broadcom.com,
alexey.amakhalov@broadcom.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com
Cc: x86@kernel.org, virtualization@lists.linux.dev,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/paravirt: Remove unused paravirt_disable_iospace
Date: Mon, 3 Mar 2025 00:16:30 +0000 [thread overview]
Message-ID: <Z8T03pyFFd9HyMB3@gallifrey> (raw)
In-Reply-To: <20250303000830.82968-1-linux@treblig.org>
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The last use of paravirt_disable_iospace() was removed in 2015 by
> commit d1c29465b8a5 ("lguest: don't disable iospace.")
>
> Remove it.
>
> Note the comment above it about 'entry.S' is unrelated to this
> but stayed when intervening code got deleted.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Oops, missed the .h - v2 coming up.
Dave
> ---
> arch/x86/kernel/paravirt.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
> index 1ccaa3397a67..debe92854774 100644
> --- a/arch/x86/kernel/paravirt.c
> +++ b/arch/x86/kernel/paravirt.c
> @@ -90,26 +90,6 @@ void paravirt_set_sched_clock(u64 (*func)(void))
> static_call_update(pv_sched_clock, func);
> }
>
> -/* These are in entry.S */
> -static struct resource reserve_ioports = {
> - .start = 0,
> - .end = IO_SPACE_LIMIT,
> - .name = "paravirt-ioport",
> - .flags = IORESOURCE_IO | IORESOURCE_BUSY,
> -};
> -
> -/*
> - * Reserve the whole legacy IO space to prevent any legacy drivers
> - * from wasting time probing for their hardware. This is a fairly
> - * brute-force approach to disabling all non-virtual drivers.
> - *
> - * Note that this must be called very early to have any effect.
> - */
> -int paravirt_disable_iospace(void)
> -{
> - return request_resource(&ioport_resource, &reserve_ioports);
> -}
> -
> #ifdef CONFIG_PARAVIRT_XXL
> static noinstr void pv_native_write_cr2(unsigned long val)
> {
> --
> 2.48.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2025-03-03 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 0:08 [PATCH] x86/paravirt: Remove unused paravirt_disable_iospace linux
2025-03-03 0:16 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8T03pyFFd9HyMB3@gallifrey \
--to=linux@treblig.org \
--cc=ajay.kaher@broadcom.com \
--cc=alexey.amakhalov@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).