From: Christoph Hellwig <hch@infradead.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH vhost v8 01/12] virtio_ring: split: separate dma codes
Date: Fri, 12 May 2023 08:05:35 -0700 [thread overview]
Message-ID: <ZF5Vv40TWNyFl0IN@infradead.org> (raw)
In-Reply-To: <20230509080902.104619-2-xuanzhuo@linux.alibaba.com>
As said before, please don't try to do weird runtime checks based
on the scatterlist. What you have works for now, but there are
plans to repalce the page + offset tuple in the scatterlist with
just a phys_addr_t. And with that your "clever" scheme will break
instantly.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-05-12 15:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 8:08 [PATCH vhost v8 00/12] virtio core prepares for AF_XDP Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 01/12] virtio_ring: split: separate dma codes Xuan Zhuo
2023-05-12 15:05 ` Christoph Hellwig [this message]
2023-05-15 1:38 ` Jason Wang
2023-05-15 2:00 ` Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 02/12] virtio_ring: packed: " Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 03/12] virtio_ring: packed-indirect: " Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 04/12] virtio_ring: split: support premapped Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 05/12] virtio_ring: packed: " Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 06/12] virtio_ring: packed-indirect: " Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 07/12] virtio_ring: remove unused code Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 08/12] virtio_ring: update document for virtqueue_add_* Xuan Zhuo
2023-05-09 8:08 ` [PATCH vhost v8 09/12] virtio_ring: introduce virtqueue_dma_dev() Xuan Zhuo
2023-05-09 8:09 ` [PATCH vhost v8 10/12] virtio_ring: correct the expression of the description of virtqueue_resize() Xuan Zhuo
2023-05-09 8:09 ` [PATCH vhost v8 11/12] virtio_ring: separate the logic of reset/enable from virtqueue_resize Xuan Zhuo
2023-05-09 8:09 ` [PATCH vhost v8 12/12] virtio_ring: introduce virtqueue_reset() Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF5Vv40TWNyFl0IN@infradead.org \
--to=hch@infradead.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).