From: Christoph Hellwig <hch@infradead.org>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: xuanzhuo@linux.alibaba.com, mst@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, stefanha@redhat.com
Subject: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods
Date: Wed, 17 May 2023 00:39:23 -0700 [thread overview]
Message-ID: <ZGSEq197W8VvOWCc@infradead.org> (raw)
In-Reply-To: <20230517025424.601141-2-pizhenwei@bytedance.com>
On Wed, May 17, 2023 at 10:54:23AM +0800, zhenwei pi wrote:
> All the vring based virtqueue methods could be abstratct in theory,
> MST suggested that add/get bufs and kick functions are quite perfmance
> sensitive, so export these functions from virtio_ring.ko, drivers
> still call them in a fast path.
Who is going to use this? And why do you think every virtio users
would want to pay for indirect calls just for your shiny new feature?
This seems like an amazingly bad idea to me.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-05-17 7:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 2:54 [PATCH v2 0/2] virtio: abstract virtqueue related methods zhenwei pi via Virtualization
2023-05-17 2:54 ` [PATCH v2 1/2] " zhenwei pi via Virtualization
2023-05-17 6:57 ` kernel test robot
2023-05-17 7:10 ` kernel test robot
2023-05-17 7:39 ` Christoph Hellwig [this message]
2023-05-17 7:43 ` zhenwei pi via Virtualization
2023-05-17 7:46 ` Christoph Hellwig
2023-05-17 8:35 ` zhenwei pi via Virtualization
2023-05-17 10:39 ` Michael S. Tsirkin
2023-05-18 0:47 ` zhenwei pi via Virtualization
2023-05-18 10:09 ` Michael S. Tsirkin
2023-05-18 11:01 ` zhenwei pi via Virtualization
2023-05-17 17:59 ` kernel test robot
2023-05-17 2:54 ` [PATCH v2 2/2] tools/virtio: implement virtqueue in test zhenwei pi via Virtualization
2023-05-17 3:46 ` [PATCH v2 0/2] virtio: abstract virtqueue related methods Michael S. Tsirkin
2023-05-17 3:51 ` zhenwei pi via Virtualization
2023-05-17 3:57 ` Michael S. Tsirkin
2023-05-17 4:58 ` zhenwei pi via Virtualization
2023-05-17 6:10 ` Michael S. Tsirkin
2023-05-17 6:21 ` zhenwei pi via Virtualization
2023-05-17 10:13 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGSEq197W8VvOWCc@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).