From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77A6BC77B75 for ; Tue, 23 May 2023 06:03:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D1B8860ECA; Tue, 23 May 2023 06:03:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D1B8860ECA Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Rhaw+64x X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Uwf5tfjZNYdg; Tue, 23 May 2023 06:03:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4AB61607A4; Tue, 23 May 2023 06:03:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4AB61607A4 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 019E9C0036; Tue, 23 May 2023 06:03:01 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 48721C002A for ; Tue, 23 May 2023 06:02:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1D242402D4 for ; Tue, 23 May 2023 06:02:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1D242402D4 Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Rhaw+64x X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eh8Wnz2UG9j1 for ; Tue, 23 May 2023 06:02:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 673C0400C1 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by smtp2.osuosl.org (Postfix) with ESMTPS id 673C0400C1 for ; Tue, 23 May 2023 06:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bU2DX7e2UzcS97thLqd77+ycr3nV003/DwvXqCaVUt8=; b=Rhaw+64xhIzWgD/b/IBn6214AF bn3UuwCH53QNFTnakNqwGQGHh4Edp7Hw76iFkJv7HQ2ESgO75Bfgw6OE10IJ6KjcCl5durWa4PwDc GcbiUz8s8z1WErTRMeHSw2+B3xELch96vnCu5PX9Svu/ZFdXZ9iYamnCBHN2pJN85+aRPYs6ppwn+ ijXSI+gqqr38U2CCVwmJzoDsHN2PFvUJOpkdCYwUj1sUV4S3mVD+E3XqAA/ZypPPmSwmYN7LzfXAo dZ66PtuLt0Lec38MqXJ1XPKggb2Q1cgPmbqiWtsRAsP110T5Kd88ssZ1y+pyDtLvqVmdAGzsC/iFj UYLtlL6g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1L6n-00926Z-2I; Tue, 23 May 2023 06:02:57 +0000 Date: Mon, 22 May 2023 23:02:57 -0700 From: Christoph Hellwig To: Xuan Zhuo Subject: Re: [PATCH vhost v9 01/12] virtio_ring: put mapping error check in vring_map_one_sg Message-ID: References: <20230517022249.20790-1-xuanzhuo@linux.alibaba.com> <20230517022249.20790-2-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230517022249.20790-2-xuanzhuo@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: Christoph Hellwig , "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, May 17, 2023 at 10:22:38AM +0800, Xuan Zhuo wrote: > -static dma_addr_t vring_map_one_sg(const struct vring_virtqueue *vq, > - struct scatterlist *sg, > - enum dma_data_direction direction) > +static int vring_map_one_sg(const struct vring_virtqueue *vq, struct scatterlist *sg, > + enum dma_data_direction direction, static dma_addr_t *addr) Please avoid making this unreadable by adding overly lone lines. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization