* Re: [PATCH] virtio_pmem: do flush synchronously
[not found] <20230620032838.1598793-1-houtao@huaweicloud.com>
@ 2023-06-21 12:13 ` Christoph Hellwig
[not found] ` <20230621134340.878461-1-houtao@huaweicloud.com>
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2023-06-21 12:13 UTC (permalink / raw)
To: Hou Tao
Cc: Jens Axboe, Pankaj Gupta, nvdimm, houtao1, virtualization,
linux-block, Christoph Hellwig, Dan Williams
I think the proper minimal fix is to pass in a REQ_WRITE in addition to
REQ_PREFLUSH. We can than have a discussion on the merits of this
weird async pmem flush scheme separately.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] virtio_pmem: add the missing REQ_OP_WRITE for flush bio
[not found] ` <20230621134340.878461-1-houtao@huaweicloud.com>
@ 2023-06-21 13:15 ` Christoph Hellwig
[not found] ` <20230625022633.2753877-1-houtao@huaweicloud.com>
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2023-06-21 13:15 UTC (permalink / raw)
To: Hou Tao
Cc: Jens Axboe, linux-block, nvdimm, Pankaj Gupta, virtualization,
Christoph Hellwig, houtao1, Dan Williams
Please avoid the overly long line. With that fixe this looks good
to me.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] virtio_pmem: add the missing REQ_OP_WRITE for flush bio
[not found] ` <20230625022633.2753877-1-houtao@huaweicloud.com>
@ 2023-06-26 7:53 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-06-26 7:53 UTC (permalink / raw)
To: Hou Tao
Cc: Jens Axboe, nvdimm, Pankaj Gupta, virtualization,
Christoph Hellwig, linux-block, houtao1, Dan Williams
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-26 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230620032838.1598793-1-houtao@huaweicloud.com>
2023-06-21 12:13 ` [PATCH] virtio_pmem: do flush synchronously Christoph Hellwig
[not found] ` <20230621134340.878461-1-houtao@huaweicloud.com>
2023-06-21 13:15 ` [PATCH v2] virtio_pmem: add the missing REQ_OP_WRITE for flush bio Christoph Hellwig
[not found] ` <20230625022633.2753877-1-houtao@huaweicloud.com>
2023-06-26 7:53 ` [PATCH v3] " Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).