From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-comment@lists.oasis-open.org, stefanha@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: virtio-sound linux driver conformance to spec
Date: Tue, 19 Sep 2023 16:18:57 +0200 [thread overview]
Message-ID: <ZQmt0Z8lbPMuFzR+@fedora> (raw)
In-Reply-To: <20230919054054-mutt-send-email-mst@kernel.org>
On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote:
> On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote:
> > Hello,
> >
> > This email is to report a behavior of the Linux virtio-sound driver that
> > looks like it is not conforming to the VirtIO specification. The kernel
> > driver is moving buffers from the used ring to the available ring
> > without knowing if the content has been updated from the user. If the
> > device picks up buffers from the available ring just after it is
> > notified, it happens that the content is old.
>
> Then, what happens, exactly? Do things still work?
We are currently developing a vhost-user backend for virtio-sound and
what happens is that if the backend implementation decides to copy the
content of a buffer from a request that just arrived to the available
ring, it gets the old content thus reproducing some sections two times.
For example, we observe that when issuing `aplay FrontLeft.wav`, we hear
`Front, front left...`. To fix this issue, our current implementation
delays reading from guest memory just until the audio engine requires.
However, the first implementation shall also work since it is conforming
to the specification.
Matias
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-09-19 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 15:04 virtio-sound linux driver conformance to spec Matias Ezequiel Vara Larsen
2023-09-13 15:50 ` [virtio-comment] " Paolo Bonzini
2023-09-18 11:13 ` Matias Ezequiel Vara Larsen
2023-09-18 11:26 ` Matias Ezequiel Vara Larsen
[not found] ` <CAAjaMXbjRn27fpZHK982m4MyJGXWQTR99WHPAZQfcun+pe3GBw@mail.gmail.com>
2023-09-18 12:50 ` Matias Ezequiel Vara Larsen
2023-09-18 18:20 ` Stefan Hajnoczi
2023-09-19 0:35 ` Anton Yakovlev via Virtualization
2023-09-19 6:58 ` [virtio-comment] " Paolo Bonzini
2023-09-19 15:10 ` Stefan Hajnoczi
2023-09-25 0:37 ` Anton Yakovlev via Virtualization
2023-09-25 0:24 ` Anton Yakovlev via Virtualization
2023-09-19 9:43 ` Michael S. Tsirkin
2023-09-19 14:18 ` Matias Ezequiel Vara Larsen [this message]
2023-09-19 15:52 ` Michael S. Tsirkin
2023-09-20 13:18 ` Matias Ezequiel Vara Larsen
2023-09-25 1:04 ` Anton Yakovlev via Virtualization
2023-09-25 14:33 ` Matias Ezequiel Vara Larsen
2023-09-25 0:55 ` Anton Yakovlev via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQmt0Z8lbPMuFzR+@fedora \
--to=mvaralar@redhat.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox