From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8525F328CB; Thu, 16 Nov 2023 14:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6ce2de8da87so454512a34.1; Thu, 16 Nov 2023 06:36:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700145392; x=1700750192; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hQe83AHexfh3GazMLDTY5AyEL167MohegfRBMKLl7I8=; b=eew6CxPuwDBiLOspPOPPNFv6wx+5Uhf+qvP+98h1oirHQ6Tt5xjpcR6W5RCGCz6rkK ojMtMh8NRAAwg8QA0MyIYB2p/61FhRWyd2MFine3U3Gv+YwkYRl5QIUyAMqAV7k/qZav +DLuNrv9ZXYYBeOQ/4Pn2NShEd3K/KXsFfWUMxw4Ih5K8pOdzDJnm3MdR5IeB9ju20ji ho5MSBLMYcwsr1/UncJUgI3tFOxMjdjcmrpDK9YefqBRmu4czGecUXmlNAj1/xvV1hr0 SPYtHV+ZNFA4JgAAE+w6o1JI1a9OKbzGnRctJiJQcxH7R+LII/nQyV+PfuToD2DwcMYz iqzA== X-Gm-Message-State: AOJu0YyOI/rKbfYARZd5v9Ws+W35y60UCOgaYp9bUqdX6PhkuIznIVy5 H4DpB8K/LIgOViEztWfhTH0= X-Google-Smtp-Source: AGHT+IHU4Lxx+/myT+H5YB5iQwSXHLDIA41zmD2u+pjBktk3mb+GPBhIH+yVJJ2/AO7NCTzQtZy56A== X-Received: by 2002:a05:6830:10c7:b0:6c4:ae52:9599 with SMTP id z7-20020a05683010c700b006c4ae529599mr9476568oto.7.1700145392505; Thu, 16 Nov 2023 06:36:32 -0800 (PST) Received: from localhost ([2600:380:7a60:430d:7a98:972a:884d:31ff]) by smtp.gmail.com with ESMTPSA id l2-20020a9d7082000000b006cd099bb052sm912460otj.1.2023.11.16.06.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 06:36:32 -0800 (PST) Date: Thu, 16 Nov 2023 06:36:30 -0800 From: Moritz Fischer To: Jason Gunthorpe Cc: acpica-devel@lists.linux.dev, Alyssa Rosenzweig , Albert Ou , asahi@lists.linux.dev, Catalin Marinas , Dexuan Cui , devicetree@vger.kernel.org, David Woodhouse , Frank Rowand , Hanjun Guo , Haiyang Zhang , iommu@lists.linux.dev, Jean-Philippe Brucker , Jonathan Hunter , Joerg Roedel , "K. Y. Srinivasan" , Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-tegra@vger.kernel.org, Russell King , Lorenzo Pieralisi , Marek Szyprowski , Hector Martin , Palmer Dabbelt , patches@lists.linux.dev, Paul Walmsley , "Rafael J. Wysocki" , Robert Moore , Rob Herring , Robin Murphy , Sudeep Holla , Suravee Suthikulpanit , Sven Peter , Thierry Reding , Thomas Bogendoerfer , Krishna Reddy , Vineet Gupta , virtualization@lists.linux.dev, Wei Liu , Will Deacon , =?iso-8859-1?Q?Andr=E9?= Draszik , Lu Baolu , Christoph Hellwig , Jerry Snitselaar , Moritz Fischer , Zhenhua Huang , "Rafael J. Wysocki" , Rob Herring Subject: Re: [PATCH v2 12/17] iommu: Make iommu_ops_from_fwnode() static Message-ID: References: <0-v2-36a0088ecaa7+22c6e-iommu_fwspec_jgg@nvidia.com> <12-v2-36a0088ecaa7+22c6e-iommu_fwspec_jgg@nvidia.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12-v2-36a0088ecaa7+22c6e-iommu_fwspec_jgg@nvidia.com> On Wed, Nov 15, 2023 at 10:06:03AM -0400, Jason Gunthorpe wrote: > There are no external callers now. > > Signed-off-by: Jason Gunthorpe Reviewed-by: Moritz Fischer > --- > drivers/iommu/iommu.c | 3 ++- > include/linux/iommu.h | 7 ------- > 2 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 5af98cad06f9ef..ea6aede326131e 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -2928,7 +2928,8 @@ bool iommu_default_passthrough(void) > } > EXPORT_SYMBOL_GPL(iommu_default_passthrough); > > -const struct iommu_ops *iommu_ops_from_fwnode(struct fwnode_handle *fwnode) > +static const struct iommu_ops * > +iommu_ops_from_fwnode(struct fwnode_handle *fwnode) > { > const struct iommu_ops *ops = NULL; > struct iommu_device *iommu; > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 72ec71bd31a376..05c5ad6bad6339 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -831,7 +831,6 @@ static inline void iommu_fwspec_free(struct device *dev) > dev->iommu->fwspec = NULL; > } > int iommu_fwspec_add_ids(struct device *dev, u32 *ids, int num_ids); > -const struct iommu_ops *iommu_ops_from_fwnode(struct fwnode_handle *fwnode); > int iommu_fwspec_append_ids(struct iommu_fwspec *fwspec, u32 *ids, int num_ids); > > static inline struct iommu_fwspec *dev_iommu_fwspec_get(struct device *dev) > @@ -1187,12 +1186,6 @@ static inline int iommu_fwspec_add_ids(struct device *dev, u32 *ids, > return -ENODEV; > } > > -static inline > -const struct iommu_ops *iommu_ops_from_fwnode(struct fwnode_handle *fwnode) > -{ > - return NULL; > -} > - > static inline int > iommu_dev_enable_feature(struct device *dev, enum iommu_dev_features feat) > { > -- > 2.42.0 >