From: Jiri Pirko <jiri@resnulli.us>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
virtualization@lists.linux.dev
Subject: Re: [PATCH net-next v3 2/6] virtio_net: virtnet_send_command supports command-specific-result
Date: Tue, 27 Feb 2024 14:23:36 +0100 [thread overview]
Message-ID: <Zd3iWJut1tMHRIdU@nanopsycho> (raw)
In-Reply-To: <20240227080303.63894-3-xuanzhuo@linux.alibaba.com>
The patch subject should clearly indicate what should be changed,
something like this:
Subject: virtio_net: add support for command-specific-result in virtnet_send_command()
Tue, Feb 27, 2024 at 09:02:59AM CET, xuanzhuo@linux.alibaba.com wrote:
>As the spec https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>
>The virtnet cvq supports to get result from the device.
>This commit implement this.
Again, be imperative to the codebase clearly saying what it should
change. Much easier to read and understand the patch description then.
The code looks ok.
next prev parent reply other threads:[~2024-02-27 13:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 8:02 [PATCH net-next v3 0/6] virtio-net: support device stats Xuan Zhuo
2024-02-27 8:02 ` [PATCH net-next v3 1/6] virtio_net: introduce device stats feature and structures Xuan Zhuo
2024-02-27 13:16 ` Jiri Pirko
2024-02-27 8:02 ` [PATCH net-next v3 2/6] virtio_net: virtnet_send_command supports command-specific-result Xuan Zhuo
2024-02-27 13:23 ` Jiri Pirko [this message]
2024-02-27 8:03 ` [PATCH net-next v3 3/6] virtio_net: support device stats Xuan Zhuo
2024-02-27 14:56 ` Jiri Pirko
2024-02-27 19:19 ` Simon Horman
2024-02-29 10:35 ` kernel test robot
2024-03-07 16:50 ` Jakub Kicinski
2024-03-11 10:48 ` Xuan Zhuo
2024-03-11 15:43 ` Jakub Kicinski
2024-02-27 8:03 ` [PATCH net-next v3 4/6] virtio_net: stats map include driver stats Xuan Zhuo
2024-02-27 15:05 ` Jiri Pirko
2024-02-27 8:03 ` [PATCH net-next v3 5/6] virtio_net: add the total stats field Xuan Zhuo
2024-02-27 14:54 ` Jakub Kicinski
2024-02-27 15:07 ` Jiri Pirko
2024-02-27 15:41 ` Jakub Kicinski
2024-02-27 15:59 ` Jiri Pirko
2024-03-07 9:36 ` Xuan Zhuo
2024-03-07 16:03 ` Jakub Kicinski
2024-02-27 8:03 ` [PATCH net-next v3 6/6] virtio_net: rename stat tx_timeout to timeout Xuan Zhuo
2024-02-27 15:08 ` Jiri Pirko
2024-02-27 13:14 ` [PATCH net-next v3 0/6] virtio-net: support device stats Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd3iWJut1tMHRIdU@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).