From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CE016A92E for ; Wed, 26 Jun 2024 11:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719402670; cv=none; b=CDDkMrBklWxzKzpl1ruocxKiTM6/+QMNvvrHOd5+aYjCIShCiez6tTHiv4vL49JwZm4VsaokdwK6wWWpjsbMI98NlYb9cBMXIuqBAhEizJKvBk91aEiJegbNOCfwhrlillWFrTDNEZHp+EAnJp/KkxWo3pawG70vgitf6Byj+Us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719402670; c=relaxed/simple; bh=3LQoN23WI44iPi2+GuyPErzV/0khWkpYKV5ZVnuwIx4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U9hlfVZLPUd08JOnRhOgbHHhZAdQ20dEg7iXvLSEnkOfC084p1q7pVhPZX1MPgmVyE3VuPOcuoQrk8hVPSLbWDze3b4sgRq6FI+9HNjkAgMavy3ZYLmFv6xXkmJDaknmPEZtYZdLQRQpbwnAeOo45EHVPLw4CzmvNDmYQg4xwdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=SpnEVYoN; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="SpnEVYoN" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-421eab59723so48404575e9.3 for ; Wed, 26 Jun 2024 04:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1719402665; x=1720007465; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fuDkC3caQ7VJLf9N0acshbX2fD3wiC5AX8llZiwDzAU=; b=SpnEVYoNQobY+ToqVBOimbplcRRrQ/hono4Fi3nAJyocRzY9s8TFWclSX86kn70dvi iaAoFdhmtaVWf3W5yMuFIBCKclvU0EjjwUNgMw2mla124GZP/ToIWbC9QqvIw8rWbgcb vhXfEm3Kq4RcDqaI186XnTB9PDz81jX0oLlha+Rw3bWXnn36WNmLl0dhPO1IUBlGCLRm xUziq7eFHbIdJ93m2J0TMVokFI1P8aHFyxLc2Qdm8s0LlcN6bBjaYqgwSA593WTpR67D K/iY3CrTFEln77I8/tJMzCGchR3qFvkt1ktAYSS7BN51MDDU28Lj5MMjPdo8JLKvJvtE I8Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719402665; x=1720007465; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fuDkC3caQ7VJLf9N0acshbX2fD3wiC5AX8llZiwDzAU=; b=vX4KTkb5js1K/P3hhq8aajnt6jMZOYCGNAI3MIbCNDemEGdlU3PGymUZ3BWn+zPs0R Mi1kwKLVA9orHZAv+EmB1W7uroE73uGqLIEszEfuAHrf5Fe2eUT+WATjH8+AHwkXgug7 1EWbVkIaSILvhG0uxfeJHLcuuTqjyEdmXa0Bm99nybfmJk8tigpl3kOWiVQrRberXD6J hoK1XaZQse4jxMhPwCDIAFShjeTH8Imr5IWaELNkXAgMReoN7QkobE1R2SIDfqnlC1UK l5gVlm4T5+zi7NatVS1UzV2JJN59W5YUF86pLhJgRJ6qyoaybYMS2CUd+SY9WBx6ZpJX 35kg== X-Forwarded-Encrypted: i=1; AJvYcCUTsa+tiENSNPY8vvnE3fT7K8a9r81l1Oy+BW1hSlBD2oY02Ac3aPu8dhNuzmAKhi3w9ikGOfqlOjuWxJ6MB6Fyc9Urv7Fzv15nfXjE51Q= X-Gm-Message-State: AOJu0YyuY2DEeSk95WtyIjloqV67XMD8Y4scJjblmXhmoDHo8D9WjWAA S4XloNocV5YTlLZAlCgNzvVx8PIkkpY5M6KzEKznzgKqj3RelaiZtHLpu9LOGh0= X-Google-Smtp-Source: AGHT+IGFl4S14Jjbg273TutmbckTv1CS1SX8kegzuUKztNNNRpEpmFGSMeTBG1qSXNbcQxBW106IZg== X-Received: by 2002:a5d:6487:0:b0:366:e64f:b787 with SMTP id ffacd0b85a97d-366e64fb8a9mr10701070f8f.8.1719402664558; Wed, 26 Jun 2024 04:51:04 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663ada0bdesm15526415f8f.113.2024.06.26.04.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 04:51:03 -0700 (PDT) Date: Wed, 26 Jun 2024 13:51:00 +0200 From: Jiri Pirko To: "Michael S. Tsirkin" Cc: Heng Qi , Jason Wang , netdev@vger.kernel.org, virtualization@lists.linux.dev, Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next v4 2/5] virtio_net: enable irq for the control vq Message-ID: References: <1718877195.0503237-9-hengqi@linux.alibaba.com> <20240620060816-mutt-send-email-mst@kernel.org> <20240620061109-mutt-send-email-mst@kernel.org> <1718879494.952194-11-hengqi@linux.alibaba.com> <20240626040730-mutt-send-email-mst@kernel.org> <20240626045313-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240626045313-mutt-send-email-mst@kernel.org> Wed, Jun 26, 2024 at 11:58:08AM CEST, mst@redhat.com wrote: >On Wed, Jun 26, 2024 at 10:43:11AM +0200, Jiri Pirko wrote: >> Wed, Jun 26, 2024 at 10:08:14AM CEST, mst@redhat.com wrote: >> >On Wed, Jun 26, 2024 at 09:52:58AM +0200, Jiri Pirko wrote: >> >> Thu, Jun 20, 2024 at 12:31:34PM CEST, hengqi@linux.alibaba.com wrote: >> >> >On Thu, 20 Jun 2024 06:11:40 -0400, "Michael S. Tsirkin" wrote: >> >> >> On Thu, Jun 20, 2024 at 06:10:51AM -0400, Michael S. Tsirkin wrote: >> >> >> > On Thu, Jun 20, 2024 at 05:53:15PM +0800, Heng Qi wrote: >> >> >> > > On Thu, 20 Jun 2024 16:26:05 +0800, Jason Wang wrote: >> >> >> > > > On Thu, Jun 20, 2024 at 4:21 PM Jason Wang wrote: >> >> >> > > > > >> >> >> > > > > On Thu, Jun 20, 2024 at 3:35 PM Heng Qi wrote: >> >> >> > > > > > >> >> >> > > > > > On Wed, 19 Jun 2024 17:19:12 -0400, "Michael S. Tsirkin" wrote: >> >> >> > > > > > > On Thu, Jun 20, 2024 at 12:19:05AM +0800, Heng Qi wrote: >> >> >> > > > > > > > @@ -5312,7 +5315,7 @@ static int virtnet_find_vqs(struct virtnet_info *vi) >> >> >> > > > > > > > >> >> >> > > > > > > > /* Parameters for control virtqueue, if any */ >> >> >> > > > > > > > if (vi->has_cvq) { >> >> >> > > > > > > > - callbacks[total_vqs - 1] = NULL; >> >> >> > > > > > > > + callbacks[total_vqs - 1] = virtnet_cvq_done; >> >> >> > > > > > > > names[total_vqs - 1] = "control"; >> >> >> > > > > > > > } >> >> >> > > > > > > > >> >> >> > > > > > > >> >> >> > > > > > > If the # of MSIX vectors is exactly for data path VQs, >> >> >> > > > > > > this will cause irq sharing between VQs which will degrade >> >> >> > > > > > > performance significantly. >> >> >> > > > > > > >> >> >> > > > > >> >> >> > > > > Why do we need to care about buggy management? I think libvirt has >> >> >> > > > > been teached to use 2N+2 since the introduction of the multiqueue[1]. >> >> >> > > > >> >> >> > > > And Qemu can calculate it correctly automatically since: >> >> >> > > > >> >> >> > > > commit 51a81a2118df0c70988f00d61647da9e298483a4 >> >> >> > > > Author: Jason Wang >> >> >> > > > Date: Mon Mar 8 12:49:19 2021 +0800 >> >> >> > > > >> >> >> > > > virtio-net: calculating proper msix vectors on init >> >> >> > > > >> >> >> > > > Currently, the default msix vectors for virtio-net-pci is 3 which is >> >> >> > > > obvious not suitable for multiqueue guest, so we depends on the user >> >> >> > > > or management tools to pass a correct vectors parameter. In fact, we >> >> >> > > > can simplifying this by calculating the number of vectors on realize. >> >> >> > > > >> >> >> > > > Consider we have N queues, the number of vectors needed is 2*N + 2 >> >> >> > > > (#queue pairs + plus one config interrupt and control vq). We didn't >> >> >> > > > check whether or not host support control vq because it was added >> >> >> > > > unconditionally by qemu to avoid breaking legacy guests such as Minix. >> >> >> > > > >> >> >> > > > Reviewed-by: Philippe Mathieu-Daudé > >> >> > > > Reviewed-by: Stefano Garzarella >> >> >> > > > Reviewed-by: Stefan Hajnoczi >> >> >> > > > Signed-off-by: Jason Wang >> >> >> > > >> >> >> > > Yes, devices designed according to the spec need to reserve an interrupt >> >> >> > > vector for ctrlq. So, Michael, do we want to be compatible with buggy devices? >> >> >> > > >> >> >> > > Thanks. >> >> >> > >> >> >> > These aren't buggy, the spec allows this. So don't fail, but >> >> >> > I'm fine with using polling if not enough vectors. >> >> >> >> >> >> sharing with config interrupt is easier code-wise though, FWIW - >> >> >> we don't need to maintain two code-paths. >> >> > >> >> >Yes, it works well - config change irq is used less before - and will not fail. >> >> >> >> Please note I'm working on such fallback for admin queue. I would Like >> >> to send the patchset by the end of this week. You can then use it easily >> >> for cvq. >> >> >> >> Something like: >> >> /* the config->find_vqs() implementation */ >> >> int vp_find_vqs(struct virtio_device *vdev, unsigned int nvqs, >> >> struct virtqueue *vqs[], vq_callback_t *callbacks[], >> >> const char * const names[], const bool *ctx, >> >> struct irq_affinity *desc) >> >> { >> >> int err; >> >> >> >> /* Try MSI-X with one vector per queue. */ >> >> err = vp_find_vqs_msix(vdev, nvqs, vqs, callbacks, names, >> >> VP_VQ_VECTOR_POLICY_EACH, ctx, desc); >> >> if (!err) >> >> return 0; >> >> /* Fallback: MSI-X with one shared vector for config and >> >> * slow path queues, one vector per queue for the rest. */ >> >> err = vp_find_vqs_msix(vdev, nvqs, vqs, callbacks, names, >> >> VP_VQ_VECTOR_POLICY_SHARED_SLOW, ctx, desc); >> >> if (!err) >> >> return 0; >> >> /* Fallback: MSI-X with one vector for config, one shared for queues. */ >> >> err = vp_find_vqs_msix(vdev, nvqs, vqs, callbacks, names, >> >> VP_VQ_VECTOR_POLICY_SHARED, ctx, desc); >> >> if (!err) >> >> return 0; >> >> /* Is there an interrupt? If not give up. */ >> >> if (!(to_vp_device(vdev)->pci_dev->irq)) >> >> return err; >> >> /* Finally fall back to regular interrupts. */ >> >> return vp_find_vqs_intx(vdev, nvqs, vqs, callbacks, names, ctx); >> >> } >> >> >> >> >> > >> > >> >Well for cvq, we'll need to adjust the API so core >> >knows cvq interrupts are be shared with config not >> >datapath. >> >> Agreed. I was thinking about introducing some info struct and pass array >> of it instead of callbacks[] and names[]. Then the struct can contain >> flag indication. Something like: >> >> struct vq_info { >> vq_callback_t *callback; >> const char *name; >> bool slow_path; >> }; >> > >Yes. Add ctx too? There were attempts at it already btw. Yep, ctx too. I can take a stab at it if noone else is interested. > > >> > >> > >> > >> >> >> >> > >> >> >Thanks. >> >> > >> >> >> >> >> >> > > > >> >> >> > > > Thanks >> >> >> > > > >> >> >> > > > > >> >> >> > > > > > > So no, you can not just do it unconditionally. >> >> >> > > > > > > >> >> >> > > > > > > The correct fix probably requires virtio core/API extensions. >> >> >> > > > > > >> >> >> > > > > > If the introduction of cvq irq causes interrupts to become shared, then >> >> >> > > > > > ctrlq need to fall back to polling mode and keep the status quo. >> >> >> > > > > >> >> >> > > > > Having to path sounds a burden. >> >> >> > > > > >> >> >> > > > > > >> >> >> > > > > > Thanks. >> >> >> > > > > > >> >> >> > > > > >> >> >> > > > > >> >> >> > > > > Thanks >> >> >> > > > > >> >> >> > > > > [1] https://www.linux-kvm.org/page/Multiqueue >> >> >> > > > > >> >> >> > > > > > > >> >> >> > > > > > > -- >> >> >> > > > > > > MST >> >> >> > > > > > > >> >> >> > > > > > >> >> >> > > > >> >> >> >> >> > >> > >