Linux virtualization list
 help / color / mirror / Atom feed
From: Chen Yu <yu.c.chen@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>, "Arnd Bergmann" <arnd@arndb.de>,
	<virtualization@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	Juergen Gross <jgross@suse.com>,
	"Nikolay Borisov" <nik.borisov@suse.com>,
	Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
	"Prem Nath Dey" <prem.nath.dey@intel.com>,
	Xiaoping Zhou <xiaoping.zhou@intel.com>
Subject: Re: [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal
Date: Tue, 30 Jul 2024 02:47:35 +0800	[thread overview]
Message-ID: <Zqfjx6eI9F8sHi/p@chenyu5-mobl2> (raw)
In-Reply-To: <87cymw8j2e.ffs@tglx>

Hi Thomas,

On 2024-07-29 at 14:43:37 +0200, Thomas Gleixner wrote:
> On Mon, Jul 29 2024 at 14:52, Chen Yu wrote:
> >  #ifdef CONFIG_PARAVIRT
> >  /*
> > - * virt_spin_lock_key - enables (by default) the virt_spin_lock() hijack.
> > + * virt_spin_lock_key - disables (by default) the virt_spin_lock() hijack.
> >   *
> >   * Native (and PV wanting native due to vCPU pinning) should disable this key.
> >   * It is done in this backwards fashion to only have a single direction change,
> >   * which removes ordering between native_pv_spin_init() and HV setup.
> 
> This comment is bogus now.
>

Yes, now it could be two direction: enabled first and disabled later. Let me refine
the comments.

thanks,
Chenyu 

  reply	other threads:[~2024-07-29 18:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29  6:52 [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal Chen Yu
2024-07-29 12:43 ` Thomas Gleixner
2024-07-29 18:47   ` Chen Yu [this message]
2024-07-30  1:21 ` maobibo
2024-07-30  8:46   ` Chen Yu
2024-07-30  9:39     ` maobibo
2024-08-01  8:00 ` maobibo
2024-08-01 14:40   ` Chen Yu
2024-08-02  1:27     ` maobibo
2024-08-02  7:56       ` Chen Yu
2024-08-02  8:13         ` maobibo
2024-08-02 13:52           ` Chen Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zqfjx6eI9F8sHi/p@chenyu5-mobl2 \
    --to=yu.c.chen@intel.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nik.borisov@suse.com \
    --cc=prem.nath.dey@intel.com \
    --cc=qiuxu.zhuo@intel.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux.dev \
    --cc=xiaoping.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox