From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F0C01411E0 for ; Mon, 19 Aug 2024 18:23:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724091799; cv=none; b=TmtoI3yA/eq4rogclyKNx0UujIMe6wZJxy+mDNaaOQcMUSBFRPybTdlczZ3niYuF0lCZeJ4EdFsZbamDqIDfeJ9yBkjEZIojiLdA9bTBJo6DQohjBf/glc2JSwDgRu0TFvYXTSruBrdtPJ9a8JdAsFr5RbYVm1l9WDctXxUySpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724091799; c=relaxed/simple; bh=rYHYVjwNltxRc0NQfhGa9cxFkidpIwmC1FrntLAkVdM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MxMdQipq37eXJvbaO9zr2V6UOUvynoWciy5rlAX/Ls1e4IJYCdS6YxBrgfYGDeW+S86tchleT7QXx1rNOEyhyaKkych6Etk/wbL/xKoa2vSCWiRVGDkUaf/7AWBdC/esw5jaQ41SD10s37LsfvF9DbMTvirjK8kJ7SXalKCunHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: 2Z5XhG1kTvuFFj+LJNotwg== X-CSE-MsgGUID: XIED86MKQomZozVx0KTp2w== X-IronPort-AV: E=McAfee;i="6700,10204,11169"; a="21978727" X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="21978727" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 11:23:17 -0700 X-CSE-ConnectionGUID: XkARKoIRTcORDaYxqpbKFQ== X-CSE-MsgGUID: VphTfyoEQBOqHmf0XrYtig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="65145870" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 11:23:09 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sg720-0000000H2GW-3cCJ; Mon, 19 Aug 2024 21:23:04 +0300 Date: Mon, 19 Aug 2024 21:23:04 +0300 From: Andy Shevchenko To: Philipp Stanner Cc: onathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , David Lechner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Cameron , Hannes Reinecke , Damien Le Moal , Chaitanya Kulkarni , "Martin K. Petersen" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH 6/9] ethernet: cavium: Replace deprecated PCI functions Message-ID: References: <20240819165148.58201-2-pstanner@redhat.com> <20240819165148.58201-8-pstanner@redhat.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819165148.58201-8-pstanner@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Aug 19, 2024 at 06:51:46PM +0200, Philipp Stanner wrote: > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by > the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"). > > Replace these functions with the function pcim_iomap_region(). ... cavium_ptp_probe() > - pcim_iounmap_regions(pdev, 1 << PCI_PTP_BAR_NO); > + pcim_iounmap_region(pdev, PCI_PTP_BAR_NO); > > error_free: > devm_kfree(dev, clock); Both are questionable. Why do we need either of them? -- With Best Regards, Andy Shevchenko