From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE56189528 for ; Mon, 19 Aug 2024 18:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724092335; cv=none; b=Gxfl/wk59ha7oSQHG335ingCr7oBiPX/2ukFPY9gqx+2ezOlZLk6+sm0eJ9XX7MN0avmqJq3ov7vOqrSj23UMvKIRZk8gmTQ0TA9yMVtHQjjSmqllbCdvNtdwa7MJZcrVTkifJtWt4ly1rjMngaMYqQkuMBcdzlV2hZ70lvXK4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724092335; c=relaxed/simple; bh=rtd2oKSROMxwpdH8HLDaSnEdSnaSDrRN61pn9MW5gNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZaTuR+c+FtFnjLFSJnPLEsdq9cY14m6PbU5OYK2CVJC+jqoAS5O+Fpp71fzvmGNR4R3rj4hOnQdwS2JMXKHdJDZHdoMSLeIrYmrdxk66LbC2zy3Q/vaLwjx8TNsH9uW30IRuo3BZ/T8rtldbIu30Hj2OVv0eLAgUq1QEUJC/YiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: QycvdkYJT4+CUJTuWy5sAQ== X-CSE-MsgGUID: vmh49PGjRqChAeCTZ0dUsw== X-IronPort-AV: E=McAfee;i="6700,10204,11169"; a="25262287" X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="25262287" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 11:32:13 -0700 X-CSE-ConnectionGUID: unP6c30QShqG8DAeLj6ypQ== X-CSE-MsgGUID: SuOqqpoaRYS2gC4EwtVmfg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="61238502" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 11:32:04 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sg7Ae-0000000H2PV-0kWc; Mon, 19 Aug 2024 21:32:00 +0300 Date: Mon, 19 Aug 2024 21:31:59 +0300 From: Andy Shevchenko To: Philipp Stanner Cc: onathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , David Lechner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Cameron , Hannes Reinecke , Damien Le Moal , Chaitanya Kulkarni , "Martin K. Petersen" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH 8/9] vdap: solidrun: Replace deprecated PCI functions Message-ID: References: <20240819165148.58201-2-pstanner@redhat.com> <20240819165148.58201-10-pstanner@redhat.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819165148.58201-10-pstanner@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Aug 19, 2024 at 06:51:48PM +0200, Philipp Stanner wrote: > solidrun utilizes pcim_iomap_regions(), which has been deprecated by the > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"), among other > things because it forces usage of quite a complicated bitmask mechanism. > The bitmask handling code can entirely be removed by replacing > pcim_iomap_regions() and pcim_iomap_table(). > > Replace pcim_iomap_regions() and pcim_iomap_table() with > pci_iomap_region(). ... > - int ret, i, mask = 0; > + int i; Make it signed? ... > for (i = 0; i < PCI_STD_NUM_BARS; i++) { > + if (pci_resource_len(pdev, i)) { > + psnet->bars[i] = pcim_iomap_region(pdev, i, name); > + if (IS_ERR(psnet->bars[i])) { > + SNET_ERR(pdev, "Failed to request and map PCI BARs\n"); > + return PTR_ERR(psnet->bars[i]); > + } > + } > Blank line leftover. > } -- With Best Regards, Andy Shevchenko