From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B79515575C for ; Tue, 24 Sep 2024 09:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727171633; cv=none; b=F2SeE7zBtrSrLG8iOKtyl4tPtSNV/V5Wu6dkaqAOjLDvGDcdQgpyIDaJwNWl93WGmf1n2/rSfdMHQlbWDQLu6vjLw7UJbvYeoTtX7tyVVe/Qwb8biRpvd1xlAcZT301gi+oEUGaXhPGzsI8VRgch4mz+D+5bgfPudHlZfdGHbKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727171633; c=relaxed/simple; bh=xUlVvlA3J6T3XUmGP6wOK0M7qflsdynl7PV3ve4Xp2w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A4Wy82pTPMrbwTeJthyFIlaMbwbXe9h/qeB2K2uVeWekMqcpCGHTmv+D+A+kNu4/t5e+iyxjxRDr7LLTDc4FrqlindcVSyrMBzt1IDW4lA04Irlq11raaUtcMuB4J11IuUYsZoV/lIPh2Vpcdo0KXjFq9AgCKwgZszily+q0CWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TPrfZvUN; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TPrfZvUN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727171631; x=1758707631; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xUlVvlA3J6T3XUmGP6wOK0M7qflsdynl7PV3ve4Xp2w=; b=TPrfZvUN1jhKJEJE7+2V9m2pZE9UDgY79q5s9/lH080Tdjo1sIOpaL7M CHmECT6FudmhKZ8GvUs7S8YckUOmoa7X6CHPbHDuu0tSdO+UM12UAzsN+ 6fJLhO50xD5be+w5wdNCzx3EkC4wjHor6PcIMIx0KKk+U8PethrRNMj3l N/75EeSDJZmZoFYMvIakR92uc/QKPr/lgsJfmYIfVkM4YuYP1+4pse2yR hLSvXOMm9IdUFPq1aKQzW6cObVt70myBjAsWBYMpE7Dy/W7Hiv5LEhNsR g9ywFBlEADQKs8UDEdQ7Kgb0eKiWDJ8/UAi65yf8e55pptWj2Je8/vZ1y w==; X-CSE-ConnectionGUID: o3i5qqE1ThyCCQ7m8FH38A== X-CSE-MsgGUID: gnHymoo5QhGRX1gBBXrXPw== X-IronPort-AV: E=McAfee;i="6700,10204,11204"; a="43674226" X-IronPort-AV: E=Sophos;i="6.10,254,1719903600"; d="scan'208";a="43674226" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2024 02:53:50 -0700 X-CSE-ConnectionGUID: KwYZeJ4GQDSYfjYoREQzeg== X-CSE-MsgGUID: htUOPwTXTRywBsMSNeygMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,254,1719903600"; d="scan'208";a="108819373" Received: from ly-workstation.sh.intel.com (HELO ly-workstation) ([10.239.161.23]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2024 02:53:48 -0700 Date: Tue, 24 Sep 2024 17:52:41 +0800 From: "Lai, Yi" To: Miklos Szeredi Cc: Joanne Koong , Miklos Szeredi , linux-fsdevel@vger.kernel.org, Peter-Jan Gootzen , Jingbo Xu , Stefan Hajnoczi , Yoray Zack , Vivek Goyal , virtualization@lists.linux.dev, yi1.lai@intel.com Subject: Re: [PATCH] fuse: cleanup request queuing towards virtiofs Message-ID: References: <20240529155210.2543295-1-mszeredi@redhat.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Miklos, After applying your attached patch on top of linux-next next-20240924 tag, issue cannot be reproduced running the same repro binary. Regards, Yi Lai On Tue, Sep 24, 2024 at 10:58:31AM +0200, Miklos Szeredi wrote: > On Tue, 24 Sept 2024 at 01:48, Joanne Koong wrote: > > So maybe just clear_bit(FR_PENDING, &req->flags) before we call > > fuse_request_end() is the best. > > Agreed. Attached patch should fix it. > > Yi, can you please verify? > > Thanks, > Miklos > From fcd2d9e1fdcd7cada612f2e8737fb13a2bce7d0e Mon Sep 17 00:00:00 2001 > From: Miklos Szeredi > Date: Tue, 24 Sep 2024 10:47:23 +0200 > Subject: fuse: clear FR_PENDING if abort is detected when sending request > > The (!fiq->connected) check was moved into the queuing method resulting in > the following: > > Fixes: 5de8acb41c86 ("fuse: cleanup request queuing towards virtiofs") > Reported-by: Lai, Yi > Closes: https://lore.kernel.org/all/ZvFEAM6JfrBKsOU0@ly-workstation/ > Signed-off-by: Miklos Szeredi > --- > fs/fuse/dev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c > index cdf925e0b317..53c4569d85a4 100644 > --- a/fs/fuse/dev.c > +++ b/fs/fuse/dev.c > @@ -295,6 +295,7 @@ static void fuse_dev_queue_req(struct fuse_iqueue *fiq, struct fuse_req *req) > } else { > spin_unlock(&fiq->lock); > req->out.h.error = -ENOTCONN; > + clear_bit(FR_PENDING, &req->flags); > fuse_request_end(req); > } > } > -- > 2.46.0 >