virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Si-Wei Liu <si-wei.liu@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: lvivier@redhat.com, virtualization@lists.linux-foundation.org,
	eperezma@redhat.com, elic@nvidia.com
Subject: Re: [PATCH 0/3] fixes for mlx5_vdpa multiqueue support
Date: Fri, 14 Jan 2022 01:24:08 -0800	[thread overview]
Message-ID: <a1b0ca78-c255-3317-61dc-e80dfcbfa159@oracle.com> (raw)
In-Reply-To: <20220113020125-mutt-send-email-mst@kernel.org>



On 1/12/2022 11:03 PM, Michael S. Tsirkin wrote:
> On Thu, Jan 13, 2022 at 12:10:48AM -0500, Si-Wei Liu wrote:
>> This patchset contains the fixes for a few issues uncovered during the
>> review for the "Allow for configuring max number of virtqueue pairs"
>> series.
>>
>> It is based on Eli's fixes:
>> 2e4cda633a22 ("vdpa/mlx5: Fix tracking of current number of VQs")
>> in the vhost tree.
> It's really cleanups more than fixes. I'm not sure about the
> code changes (the vdpa change looks ok, mlx5 ones need review
> by nvidia folks) but from documentation POV this patchset needs
> more work.
Yeah, this changeset is aiming to tighten the lose end found during code 
review.  Will try to improve commit message/comment and get back.

There will be another set that I am working on for real issues. Stay tuned.

-Siwei
>
>> Si-Wei Liu (3):
>>    vdpa: factor out vdpa_set_features_unlocked for vdpa internal use
>>    vdpa/mlx5: set_features should nack MQ if no CTRL_VQ
>>    vdpa/mlx5: validate the queue pair value from driver
>>
>>   drivers/vdpa/mlx5/net/mlx5_vnet.c | 26 +++++++++++++++++++++++---
>>   drivers/vdpa/vdpa.c               |  2 +-
>>   drivers/vhost/vdpa.c              |  2 +-
>>   drivers/virtio/virtio_vdpa.c      |  2 +-
>>   include/linux/vdpa.h              | 18 ++++++++++++------
>>   5 files changed, 38 insertions(+), 12 deletions(-)
>>
>> -- 
>> 1.8.3.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

      reply	other threads:[~2022-01-14  9:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13  5:10 [PATCH 0/3] fixes for mlx5_vdpa multiqueue support Si-Wei Liu
2022-01-13  5:10 ` [PATCH 1/3] vdpa: factor out vdpa_set_features_unlocked for vdpa internal use Si-Wei Liu
2022-01-13  6:46   ` Michael S. Tsirkin
2022-01-13  5:10 ` [PATCH 2/3] vdpa/mlx5: set_features should nack MQ if no CTRL_VQ Si-Wei Liu
2022-01-13  6:57   ` Michael S. Tsirkin
2022-01-14  8:51     ` Si-Wei Liu
2022-01-14 12:53       ` Michael S. Tsirkin
     [not found]   ` <20220113080914.GB1312@mtl-vdi-166.wap.labs.mlnx>
2022-01-14  6:08     ` Jason Wang
2022-01-13  5:10 ` [PATCH 3/3] vdpa/mlx5: validate the queue pair value from driver Si-Wei Liu
2022-01-13  7:00   ` Michael S. Tsirkin
2022-01-14  9:19     ` Si-Wei Liu
2022-01-13  7:03 ` [PATCH 0/3] fixes for mlx5_vdpa multiqueue support Michael S. Tsirkin
2022-01-14  9:24   ` Si-Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1b0ca78-c255-3317-61dc-e80dfcbfa159@oracle.com \
    --to=si-wei.liu@oracle.com \
    --cc=elic@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).