From: Hannes Reinecke <hare@suse.de>
To: Aaron Conole <aconole@redhat.com>,
virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org
Cc: Victor Kaplansky <vkaplans@redhat.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v10] virtio-net: add Max MTU configuration field
Date: Wed, 14 Sep 2016 08:21:01 +0200 [thread overview]
Message-ID: <a79e0939-b0ca-e312-9320-dbfc4a40f2ee@suse.de> (raw)
In-Reply-To: <1473779892-6234-1-git-send-email-aconole@redhat.com>
On 09/13/2016 05:18 PM, Aaron Conole wrote:
> It is helpful for a host to indicate it's MTU to be set on guest NICs
> other than the assumed 1500 byte value. This helps in situations where
> the host network is using Jumbo Frames, or aiding in PMTU discovery by
> configuring a homogenous network. It is also helpful for sizing receive
> buffers correctly.
>
> The change adds a new field to configuration area of network
> devices. It will be used to pass a maximum MTU from the device to
> the driver. This will be used by the driver as a maximum value for
> packet sizes during transmission, without segmentation offloading.
>
> In addition, in order to support backward and forward compatibility,
> we introduce a new feature bit called VIRTIO_NET_F_MTU.
>
> VIRTIO-152
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Cc: Victor Kaplansky <victork@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
Very good. I'm needing this for my FCoE over virtio work.
Reviewed-by: Hannes Reiencke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2016-09-14 6:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1473779892-6234-1-git-send-email-aconole@redhat.com>
2016-09-13 15:58 ` [PATCH v10] virtio-net: add Max MTU configuration field Michael S. Tsirkin
2016-09-13 21:17 ` Michael S. Tsirkin
2016-09-14 6:21 ` Hannes Reinecke [this message]
[not found] ` <20160914000341-mutt-send-email-mst@kernel.org>
2016-09-14 7:18 ` [virtio-dev] " Cornelia Huck
2016-09-13 15:18 Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a79e0939-b0ca-e312-9320-dbfc4a40f2ee@suse.de \
--to=hare@suse.de \
--cc=aconole@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkaplans@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).