From: Christoph Hellwig <hch@infradead.org>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
hch@infradead.org, xieyongji@bytedance.com
Subject: Re: [PATCH 0/9] Refine virtio mapping API
Date: Thu, 3 Jul 2025 01:57:07 -0700 [thread overview]
Message-ID: <aGZF4025JPO3wgnm@infradead.org> (raw)
In-Reply-To: <CACGkMEtr+Rwu+imU1rLtLLQxY50sNzCC8gi8sE4xVhCoDphJwg@mail.gmail.com>
On Tue, Jul 01, 2025 at 04:00:31PM +0800, Jason Wang wrote:
> Actually not, it doesn't change how things work for the device that
> does DMA already like:
>
> If device has its specific mapping ops
> go for device specific mapping ops
> else
> go for DMA API
>
> VDUSE is the only user now, and extra indirection has been used for
> VDUSE even without this series (via abusing DMA API). This series
> switch from:
>
> virtio core -> DMA API -> VDUSE DMA API -> iova domain ops
>
> to
>
> virtio core -> virtio map ops -> VDUSE map ops -> iova domain ops
And that's exaxctly how it should be done.
Thanks for doing the work! I'll go through if I find some nitpicks,
but the concept is the only right one here.
prev parent reply other threads:[~2025-07-03 8:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 1:13 [PATCH 0/9] Refine virtio mapping API Jason Wang
2025-07-01 1:13 ` [PATCH 1/9] virtio_ring: constify virtqueue pointer for DMA helpers Jason Wang
2025-07-01 1:13 ` [PATCH 2/9] virtio_ring: switch to use dma_{map|unmap}_page() Jason Wang
2025-07-01 1:13 ` [PATCH 3/9] virtio: rename dma helpers Jason Wang
2025-07-01 1:13 ` [PATCH 4/9] virtio: rename dma_dev to map_token Jason Wang
2025-07-01 1:13 ` [PATCH 5/9] virtio_ring: rename dma_handle to map_handle Jason Wang
2025-07-01 1:13 ` [PATCH 6/9] virtio: introduce map ops in virtio core Jason Wang
2025-07-01 1:13 ` [PATCH 7/9] vdpa: rename dma_dev to map_token Jason Wang
2025-07-01 21:25 ` kernel test robot
2025-07-01 1:14 ` [PATCH 8/9] vdpa: introduce map ops Jason Wang
2025-07-02 5:20 ` kernel test robot
2025-07-02 6:59 ` Jason Wang
2025-07-01 1:14 ` [PATCH 9/9] vduse: switch to use virtio map API instead of DMA API Jason Wang
2025-07-01 7:50 ` Michael S. Tsirkin
2025-07-01 8:11 ` Jason Wang
2025-07-01 7:04 ` [PATCH 0/9] Refine virtio mapping API Michael S. Tsirkin
2025-07-01 8:00 ` Jason Wang
2025-07-03 8:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGZF4025JPO3wgnm@infradead.org \
--to=hch@infradead.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox