* [PATCH] vsock/test: Remove redundant semicolons
@ 2025-08-12 4:01 Liao Yuanhong
2025-08-12 17:45 ` Joe Damato
0 siblings, 1 reply; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-12 4:01 UTC (permalink / raw)
To: Stefano Garzarella, Paolo Abeni, Konstantin Shkolnyy,
open list:VM SOCKETS (AF_VSOCK), open list:VM SOCKETS (AF_VSOCK),
open list
Cc: Liao Yuanhong
Remove unnecessary semicolons.
Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
tools/testing/vsock/util.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
index 7b861a8e997a..d843643ced6b 100644
--- a/tools/testing/vsock/util.c
+++ b/tools/testing/vsock/util.c
@@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
fail:
fprintf(stderr, "%s val %llu\n", errmsg, val);
exit(EXIT_FAILURE);
-;
}
/* Set "int" socket option and check that it's indeed set */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] vsock/test: Remove redundant semicolons
2025-08-12 4:01 [PATCH] vsock/test: Remove redundant semicolons Liao Yuanhong
@ 2025-08-12 17:45 ` Joe Damato
2025-08-13 6:56 ` Liao Yuanhong
0 siblings, 1 reply; 4+ messages in thread
From: Joe Damato @ 2025-08-12 17:45 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Stefano Garzarella, Paolo Abeni, Konstantin Shkolnyy,
open list:VM SOCKETS (AF_VSOCK), open list:VM SOCKETS (AF_VSOCK),
open list
On Tue, Aug 12, 2025 at 12:01:15PM +0800, Liao Yuanhong wrote:
> Remove unnecessary semicolons.
>
> Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> tools/testing/vsock/util.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
> index 7b861a8e997a..d843643ced6b 100644
> --- a/tools/testing/vsock/util.c
> +++ b/tools/testing/vsock/util.c
> @@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
> fail:
> fprintf(stderr, "%s val %llu\n", errmsg, val);
> exit(EXIT_FAILURE);
> -;
> }
This isn't a fixes since it doesn't fix a bug; it's cleanup so I'd probably
target net-next and drop the fixes tag.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vsock/test: Remove redundant semicolons
2025-08-12 17:45 ` Joe Damato
@ 2025-08-13 6:56 ` Liao Yuanhong
2025-08-27 7:45 ` Stefano Garzarella
0 siblings, 1 reply; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-13 6:56 UTC (permalink / raw)
To: Joe Damato
Cc: Stefano Garzarella, Paolo Abeni, Konstantin Shkolnyy,
open list:VM SOCKETS (AF_VSOCK), open list:VM SOCKETS (AF_VSOCK),
open list
On 8/13/2025 1:45 AM, Joe Damato wrote:
> [You don't often get email from joe@dama.to. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Tue, Aug 12, 2025 at 12:01:15PM +0800, Liao Yuanhong wrote:
>> Remove unnecessary semicolons.
>>
>> Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
>> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
>> ---
>> tools/testing/vsock/util.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
>> index 7b861a8e997a..d843643ced6b 100644
>> --- a/tools/testing/vsock/util.c
>> +++ b/tools/testing/vsock/util.c
>> @@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
>> fail:
>> fprintf(stderr, "%s val %llu\n", errmsg, val);
>> exit(EXIT_FAILURE);
>> -;
>> }
> This isn't a fixes since it doesn't fix a bug; it's cleanup so I'd probably
> target net-next and drop the fixes tag.
Do you need me to resend the v2 version without the fixes tag?
Thanks,
Liao
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vsock/test: Remove redundant semicolons
2025-08-13 6:56 ` Liao Yuanhong
@ 2025-08-27 7:45 ` Stefano Garzarella
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2025-08-27 7:45 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Joe Damato, Paolo Abeni, Konstantin Shkolnyy,
open list:VM SOCKETS (AF_VSOCK), open list:VM SOCKETS (AF_VSOCK),
open list
On Wed, 13 Aug 2025 at 08:57, Liao Yuanhong <liaoyuanhong@vivo.com> wrote:
>
> On 8/13/2025 1:45 AM, Joe Damato wrote:
>
> > [You don't often get email from joe@dama.to. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > On Tue, Aug 12, 2025 at 12:01:15PM +0800, Liao Yuanhong wrote:
> >> Remove unnecessary semicolons.
> >>
> >> Fixes: 86814d8ffd55f ("vsock/test: verify socket options after setting them")
> >> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> >> ---
> >> tools/testing/vsock/util.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
> >> index 7b861a8e997a..d843643ced6b 100644
> >> --- a/tools/testing/vsock/util.c
> >> +++ b/tools/testing/vsock/util.c
> >> @@ -756,7 +756,6 @@ void setsockopt_ull_check(int fd, int level, int optname,
> >> fail:
> >> fprintf(stderr, "%s val %llu\n", errmsg, val);
> >> exit(EXIT_FAILURE);
> >> -;
> >> }
> > This isn't a fixes since it doesn't fix a bug; it's cleanup so I'd probably
> > target net-next and drop the fixes tag.
>
> Do you need me to resend the v2 version without the fixes tag?
Yes, please.
Also target net-next:
https://docs.kernel.org/process/maintainer-netdev.html#indicating-target-tree
Thanks,
Stefano
>
>
> Thanks,
>
> Liao
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-27 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 4:01 [PATCH] vsock/test: Remove redundant semicolons Liao Yuanhong
2025-08-12 17:45 ` Joe Damato
2025-08-13 6:56 ` Liao Yuanhong
2025-08-27 7:45 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox