public inbox for virtualization@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Francesco Valla <francesco@valla.it>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Harald Mommer <harald.mommer@oss.qualcomm.com>,
	Matias Ezequiel Vara Larsen <mvaralar@redhat.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Mikhail Golubev-Ciuchea
	<mikhail.golubev-ciuchea@oss.qualcomm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	linux-can@vger.kernel.org, virtualization@lists.linux.dev,
	Wolfgang Grandegger <wg@grandegger.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>
Subject: Re: [PATCH v6] can: virtio: Add virtio CAN driver
Date: Tue, 6 Jan 2026 21:39:35 +0100	[thread overview]
Message-ID: <aV1zB_fYQE_OBZm2@bywater> (raw)
In-Reply-To: <4cf222cb-e6e3-4d09-a7d8-bc64b8e148bd@hartkopp.net>

Hello Harald, Oliver,

On Tue, Jan 06, 2026 at 08:43:42PM +0100, Oliver Hartkopp wrote:
> 
> 
> On 06.01.26 17:50, Harald Mommer wrote:
> > > With the plain 'cangen' you are not really flooding the interface, since
> > > you are only sending a random CAN frame every 200ms. The only way I can
> > > reproduce this behaviour in a consistent manner is running from the host:
> > > 
> > >      while true; do cansend vcan0 134#00; done
> > > 
> > > which seems to generate the maximum amount of traffic.
> > > 
> > > This is not of course a realistic bus load, but is leading the system
> > > (at least on my setup) to a corner case somewhere.
> > 
> > I have no idea how long the shell needs for a loop, always used cangen -g 0 to stress the setup which is most probably faster than the shell interpreter, and sometimes did this for both directions (RX and TX).
> > 
> > Full load is a realistic setup. And even if it was not, if something stopped working or worse crashes torturing the setup this was a problem.
> > 
> 
> Yes. cangen -g 0 -i <interface> creates full load - even on real CAN
> interfaces. You can also generate fixed content if you want to omit the
> generation of randomized content. 'cangen -?' prints a help text.
> 

I agree with both of you - I was simply arguing that a plain 'cangen'
with no parameters is not really loading the interface.

For some reason, I was only able to trigger the unwanted behavior with
cansend in a while loop and not with cangen -g 0, even with fixed ID and
payload. However, I suspect the issue is a matter of timing and
coincidences rather than load level.

> Best regards,
> Oliver
> 

Regards,
Francesco


  reply	other threads:[~2026-01-07  2:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 17:40 [PATCH v6] can: virtio: Add virtio CAN driver Matias Ezequiel Vara Larsen
2025-11-03 21:37 ` Francesco Valla
2025-12-11 17:52   ` Matias Ezequiel Vara Larsen
2025-12-14 15:25     ` Francesco Valla
2025-12-18 19:51       ` Harald Mommer
2025-12-18 23:07         ` Francesco Valla
2026-01-06 17:20           ` Harald Mommer
2025-12-21 13:01         ` Michael S. Tsirkin
2025-12-26 19:45         ` Matias Ezequiel Vara Larsen
2025-12-26 15:08       ` Francesco Valla
2026-01-07 16:14         ` Matias Ezequiel Vara Larsen
2026-01-07 18:55           ` Francesco Valla
2026-01-07 23:00             ` Francesco Valla
2026-01-07 23:21               ` Matias Ezequiel Vara Larsen
2026-01-08 20:21                 ` Matias Ezequiel Vara Larsen
2026-01-09 16:58                   ` Francesco Valla
2025-12-26 20:52       ` Matias Ezequiel Vara Larsen
2025-12-26 22:22         ` Francesco Valla
2025-12-29 15:47           ` Matias Ezequiel Vara Larsen
2025-12-29 18:53       ` Matias Ezequiel Vara Larsen
2025-12-29 20:55         ` Francesco Valla
2025-12-31 21:08           ` Matias Ezequiel Vara Larsen
2026-01-06 18:17             ` Matias Ezequiel Vara Larsen
2026-01-06 16:50           ` Harald Mommer
2026-01-06 19:43             ` Oliver Hartkopp
2026-01-06 20:39               ` Francesco Valla [this message]
2026-01-07 15:42                 ` Oliver Hartkopp
2026-01-07 16:01                   ` Matias Ezequiel Vara Larsen
2025-12-12 15:35   ` Matias Ezequiel Vara Larsen
2025-12-14  7:20     ` Michael S. Tsirkin
2025-12-14 14:24       ` Francesco Valla
2025-11-17  9:49 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aV1zB_fYQE_OBZm2@bywater \
    --to=francesco@valla.it \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=harald.mommer@oss.qualcomm.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=mikhail.golubev-ciuchea@oss.qualcomm.com \
    --cc=mkl@pengutronix.de \
    --cc=mst@redhat.com \
    --cc=mvaralar@redhat.com \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=socketcan@hartkopp.net \
    --cc=virtualization@lists.linux.dev \
    --cc=wg@grandegger.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox