From: Stefano Garzarella <sgarzare@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
AVKrasnov@sberdevices.ru, edumazet@google.com,
eperezma@redhat.com, jasowang@redhat.com, kuba@kernel.org,
leonardi@redhat.com, stefanha@redhat.com,
virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com,
stable-commits@vger.kernel.org, stable@vger.kernel.org
Subject: Re: Patch "vsock/virtio: fix potential unbounded skb queue" has been added to the 6.6-stable tree
Date: Tue, 16 Jun 2026 09:52:32 +0200 [thread overview]
Message-ID: <ajD_FBEak8hKNdIK@sgarzare-redhat> (raw)
In-Reply-To: <2026061624-harbor-capture-a5bf@gregkh>
On Tue, Jun 16, 2026 at 10:17:31AM +0530, Greg KH wrote:
>On Thu, May 21, 2026 at 03:15:54PM +0200, Stefano Garzarella wrote:
>> On Sun, May 17, 2026 at 09:33:06AM -0400, Sasha Levin wrote:
>> > > > What's the status of that fix?
>> > >
>> > > Stefano posted v3 and is working on v4.
>> > >
>> > > > Should it be reverted elsewhere?
>> > >
>> > > Donnu. With the change we have no DoS but the socket gets silently
>> > > broken. Eric felt given the brokenness is upstream already it's better
>> > > to work on a fix on top, not revert.
>> >
>> > Dropped from the 6.6, 6.12, 6.18, and 7.0 queues. We'll pick up Stefano's
>> > follow-up once it lands upstream.
>>
>> FYI v4 is now merged in the net tree, so I guess they will land upstream
>> soon. I CCed stable on both patches:
>>
>> a4f0b001782b ("vsock/virtio: reset connection on receiving queue overflow")
>> c6087c5aaad6 ("vsock/virtio: fix skb overhead accounting to preserve full
>> buf_alloc")
>>
>> Both are related, but the second is the main fix of this patch.
>
>THe second one doesn't apply at all :(
>
The second one is the fix of the patch originally added to stable queue
by this thread, so should be applied on top of it (commit 059b7dbd20a6
("vsock/virtio: fix potential unbounded skb queue")).
I'm working on improving memory management, but for now I think it makes
sense to backport all three to the stable branches.
So, in summary:
059b7dbd20a6 ("vsock/virtio: fix potential unbounded skb queue")
a4f0b001782b ("vsock/virtio: reset connection on receiving queue overflow")
c6087c5aaad6 ("vsock/virtio: fix skb overhead accounting to preserve full buf_alloc")
Thanks,
Stefano
next prev parent reply other threads:[~2026-06-16 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 15:21 Patch "vsock/virtio: fix potential unbounded skb queue" has been added to the 6.6-stable tree gregkh
2026-05-15 15:36 ` Michael S. Tsirkin
2026-05-15 15:41 ` Greg KH
2026-05-15 15:47 ` Michael S. Tsirkin
2026-05-17 13:33 ` Sasha Levin
2026-05-21 13:15 ` Stefano Garzarella
2026-06-16 4:47 ` Greg KH
2026-06-16 7:52 ` Stefano Garzarella [this message]
2026-06-16 7:59 ` Greg KH
2026-06-16 8:36 ` Stefano Garzarella
2026-06-16 9:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajD_FBEak8hKNdIK@sgarzare-redhat \
--to=sgarzare@redhat.com \
--cc=AVKrasnov@sberdevices.ru \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=leonardi@redhat.com \
--cc=mst@redhat.com \
--cc=sashal@kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox