From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: RE: [PATCH 1/2] hyperv: implement hv_get_tsc_page() Date: Thu, 9 Feb 2017 21:14:25 +0100 (CET) Message-ID: References: <20170209141052.18694-1-vkuznets@redhat.com> <20170209141052.18694-2-vkuznets@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Stephen Hemminger Cc: Haiyang Zhang , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Ingo Molnar , "H. Peter Anvin" , "devel@linuxdriverproject.org" , "virtualization@lists.linux-foundation.org" List-Id: virtualization@lists.linuxfoundation.org On Thu, 9 Feb 2017, Stephen Hemminger wrote: > The actual code looks fine, but the style police will not like you. > { should be at start of line on functions. > And #else should be at start of line, > > But maybe this was just more of exchange mangling the mail. Looks like. > +struct ms_hyperv_tsc_page *hv_get_tsc_page(void) { > + return tsc_pg; > +} > + That's how it reads in a proper mail client connected to a proper mail server: > +struct ms_hyperv_tsc_page *hv_get_tsc_page(void) > +{ > + return tsc_pg; > +} :)