From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH RFC V6 0/11] Paravirtualized ticketlocks Date: Sat, 31 Mar 2012 01:04:41 +0200 (CEST) Message-ID: References: <20120321102041.473.61069.sendpatchset@codeblue.in.ibm.com> <4F7616F5.4070000@zytor.com> <20120330221836.GN17822@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120330221836.GN17822@one.firstfloor.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Andi Kleen Cc: the arch/x86 maintainers , KVM , Konrad Rzeszutek Wilk , Peter Zijlstra , Stefano Stabellini , Raghavendra K T , LKML , Xen Devel , Srivatsa Vaddagiri , Avi Kivity , Jeremy Fitzhardinge , "H. Peter Anvin" , Attilio Rao , Ingo Molnar , Virtualization , Linus Torvalds , Stephan Diestelhorst List-Id: virtualization@lists.linuxfoundation.org On Sat, 31 Mar 2012, Andi Kleen wrote: > > So if a guest exits due to an external event it's easy to inspect the > > state of that guest and avoid to schedule away when it was interrupted > > in a spinlock held section. That guest/host shared state needs to be > > On a large system under high contention sleeping can perform surprisingly > well. pthread mutexes have a tendency to beat kernel spinlocks there. > So avoiding sleeping locks completely (that is what pv locks are > essentially) is not necessarily that good. Care to back that up with numbers and proper trace evidence instead of handwaving? I've stared at RT traces and throughput problems on _LARGE_ machines long enough to know what I'm talking about and I can provide evidence in a split second. > Your proposal is probably only a good idea on low contention > and relatively small systems. Sigh, you have really no fcking clue what you are talking about. On RT we observed scalabilty problems way before hardware was available to expose them. So what's your point? Put up or shut up, really! tglx