* [PATCH] virtio_ccw: remove unsued variable
@ 2014-10-20 10:48 Sebastian Ott
2014-10-20 11:05 ` Cornelia Huck
2014-10-20 14:19 ` Michael S. Tsirkin
0 siblings, 2 replies; 8+ messages in thread
From: Sebastian Ott @ 2014-10-20 10:48 UTC (permalink / raw)
To: Rusty Russell, Michael S. Tsirkin; +Cc: virtualization
[-- Attachment #1: Type: TEXT/PLAIN, Size: 984 bytes --]
Hi,
016c98c6f virtio: unify config_changed handling
introduced a warning in virtio_ccw which is fixed by the following patch.
Regards,
Sebastian
---
virtio_ccw: remove unsued variable
Fix this warning:
drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
struct virtio_driver *drv;
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
---
drivers/s390/kvm/virtio_ccw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
index 6cbe6ef..bda52f1 100644
--- a/drivers/s390/kvm/virtio_ccw.c
+++ b/drivers/s390/kvm/virtio_ccw.c
@@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
int i;
struct virtqueue *vq;
- struct virtio_driver *drv;
if (!vcdev)
return;
--
1.8.4.2
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] virtio_ccw: remove unsued variable
2014-10-20 10:48 [PATCH] virtio_ccw: remove unsued variable Sebastian Ott
@ 2014-10-20 11:05 ` Cornelia Huck
2014-10-20 14:19 ` Michael S. Tsirkin
1 sibling, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2014-10-20 11:05 UTC (permalink / raw)
To: Sebastian Ott, Rusty Russell; +Cc: virtualization, Michael S. Tsirkin
On Mon, 20 Oct 2014 12:48:18 +0200 (CEST)
Sebastian Ott <sebott@linux.vnet.ibm.com> wrote:
> Hi,
>
> 016c98c6f virtio: unify config_changed handling
>
> introduced a warning in virtio_ccw which is fixed by the following patch.
>
> Regards,
> Sebastian
> ---
> virtio_ccw: remove unsued variable
>
> Fix this warning:
> drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
> drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
> struct virtio_driver *drv;
>
> Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> ---
> drivers/s390/kvm/virtio_ccw.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Rusty: Will you take this through the virtio tree, or should I push
this through the kvm/s390 tree?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio_ccw: remove unsued variable
2014-10-20 10:48 [PATCH] virtio_ccw: remove unsued variable Sebastian Ott
2014-10-20 11:05 ` Cornelia Huck
@ 2014-10-20 14:19 ` Michael S. Tsirkin
2014-10-28 15:39 ` Sebastian Ott
1 sibling, 1 reply; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-10-20 14:19 UTC (permalink / raw)
To: Sebastian Ott; +Cc: virtualization
On Mon, Oct 20, 2014 at 12:48:18PM +0200, Sebastian Ott wrote:
> Hi,
>
> 016c98c6f virtio: unify config_changed handling
>
> introduced a warning in virtio_ccw which is fixed by the following patch.
>
> Regards,
> Sebastian
> ---
> virtio_ccw: remove unsued variable
s/unsued/unused/
>
> Fix this warning:
> drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
> drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
> struct virtio_driver *drv;
>
> Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> ---
> drivers/s390/kvm/virtio_ccw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
> index 6cbe6ef..bda52f1 100644
> --- a/drivers/s390/kvm/virtio_ccw.c
> +++ b/drivers/s390/kvm/virtio_ccw.c
> @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
> struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
> int i;
> struct virtqueue *vq;
> - struct virtio_driver *drv;
>
> if (!vcdev)
> return;
> --
> 1.8.4.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio_ccw: remove unsued variable
2014-10-20 14:19 ` Michael S. Tsirkin
@ 2014-10-28 15:39 ` Sebastian Ott
2014-10-28 17:37 ` Michael S. Tsirkin
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Ott @ 2014-10-28 15:39 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtualization
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1355 bytes --]
On Mon, 20 Oct 2014, Michael S. Tsirkin wrote:
> On Mon, Oct 20, 2014 at 12:48:18PM +0200, Sebastian Ott wrote:
> > Hi,
> >
> > 016c98c6f virtio: unify config_changed handling
> >
> > introduced a warning in virtio_ccw which is fixed by the following patch.
> >
> > Regards,
> > Sebastian
> > ---
> > virtio_ccw: remove unsued variable
>
> s/unsued/unused/
>
Totally forgot to send an updated version..sry. Here it is.
Regards,
Sebastian
---
virtio_ccw: remove unused variable
Fix this warning:
drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
struct virtio_driver *drv;
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
drivers/s390/kvm/virtio_ccw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
index 6cbe6ef..bda52f1 100644
--- a/drivers/s390/kvm/virtio_ccw.c
+++ b/drivers/s390/kvm/virtio_ccw.c
@@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
int i;
struct virtqueue *vq;
- struct virtio_driver *drv;
if (!vcdev)
return;
--
1.8.4.2
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] virtio_ccw: remove unsued variable
2014-10-28 15:39 ` Sebastian Ott
@ 2014-10-28 17:37 ` Michael S. Tsirkin
2014-10-30 17:51 ` Cornelia Huck
0 siblings, 1 reply; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-10-28 17:37 UTC (permalink / raw)
To: Sebastian Ott; +Cc: virtualization
On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote:
> On Mon, 20 Oct 2014, Michael S. Tsirkin wrote:
> > On Mon, Oct 20, 2014 at 12:48:18PM +0200, Sebastian Ott wrote:
> > > Hi,
> > >
> > > 016c98c6f virtio: unify config_changed handling
> > >
> > > introduced a warning in virtio_ccw which is fixed by the following patch.
> > >
> > > Regards,
> > > Sebastian
> > > ---
> > > virtio_ccw: remove unsued variable
> >
> > s/unsued/unused/
> >
>
> Totally forgot to send an updated version..sry. Here it is.
>
> Regards,
> Sebastian
>
> ---
> virtio_ccw: remove unused variable
>
> Fix this warning:
> drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
> drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
> struct virtio_driver *drv;
>
> Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/s390/kvm/virtio_ccw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
> index 6cbe6ef..bda52f1 100644
> --- a/drivers/s390/kvm/virtio_ccw.c
> +++ b/drivers/s390/kvm/virtio_ccw.c
> @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
> struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
> int i;
> struct virtqueue *vq;
> - struct virtio_driver *drv;
>
> if (!vcdev)
> return;
> --
> 1.8.4.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio_ccw: remove unsued variable
2014-10-28 17:37 ` Michael S. Tsirkin
@ 2014-10-30 17:51 ` Cornelia Huck
2014-10-31 0:01 ` Rusty Russell
0 siblings, 1 reply; 8+ messages in thread
From: Cornelia Huck @ 2014-10-30 17:51 UTC (permalink / raw)
To: Rusty Russell; +Cc: virtualization, Sebastian Ott, Michael S. Tsirkin
On Tue, 28 Oct 2014 19:37:58 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote:
> > virtio_ccw: remove unused variable
> >
> > Fix this warning:
> > drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
> > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
> > struct virtio_driver *drv;
> >
> > Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> > ---
> > drivers/s390/kvm/virtio_ccw.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
> > index 6cbe6ef..bda52f1 100644
> > --- a/drivers/s390/kvm/virtio_ccw.c
> > +++ b/drivers/s390/kvm/virtio_ccw.c
> > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
> > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
> > int i;
> > struct virtqueue *vq;
> > - struct virtio_driver *drv;
> >
> > if (!vcdev)
> > return;
*pokes Rusty*
Do you want to send this via the virtio tree? Otherwise, I'll queue
this with kvm/s390.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio_ccw: remove unsued variable
2014-10-30 17:51 ` Cornelia Huck
@ 2014-10-31 0:01 ` Rusty Russell
2014-10-31 8:10 ` Cornelia Huck
0 siblings, 1 reply; 8+ messages in thread
From: Rusty Russell @ 2014-10-31 0:01 UTC (permalink / raw)
To: Cornelia Huck; +Cc: virtualization, Sebastian Ott, Michael S. Tsirkin
Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> On Tue, 28 Oct 2014 19:37:58 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote:
>
>> > virtio_ccw: remove unused variable
>> >
>> > Fix this warning:
>> > drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
>> > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
>> > struct virtio_driver *drv;
>> >
>> > Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
>> > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>
>> > ---
>> > drivers/s390/kvm/virtio_ccw.c | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
>> > index 6cbe6ef..bda52f1 100644
>> > --- a/drivers/s390/kvm/virtio_ccw.c
>> > +++ b/drivers/s390/kvm/virtio_ccw.c
>> > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
>> > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
>> > int i;
>> > struct virtqueue *vq;
>> > - struct virtio_driver *drv;
>> >
>> > if (!vcdev)
>> > return;
>
> *pokes Rusty*
>
> Do you want to send this via the virtio tree? Otherwise, I'll queue
> this with kvm/s390.
*Rusty wakes*.
I assumed you would take it when I skimmed the patch, but to be formal:
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Sorry for the delay,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio_ccw: remove unsued variable
2014-10-31 0:01 ` Rusty Russell
@ 2014-10-31 8:10 ` Cornelia Huck
0 siblings, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2014-10-31 8:10 UTC (permalink / raw)
To: Rusty Russell; +Cc: virtualization, Sebastian Ott, Michael S. Tsirkin
On Fri, 31 Oct 2014 10:31:19 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:
> Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> > On Tue, 28 Oct 2014 19:37:58 +0200
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> >> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote:
> >
> >> > virtio_ccw: remove unused variable
> >> >
> >> > Fix this warning:
> >> > drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
> >> > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
> >> > struct virtio_driver *drv;
> >> >
> >> > Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> >> > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> >>
> >> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >>
> >> > ---
> >> > drivers/s390/kvm/virtio_ccw.c | 1 -
> >> > 1 file changed, 1 deletion(-)
> >> >
> >> > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
> >> > index 6cbe6ef..bda52f1 100644
> >> > --- a/drivers/s390/kvm/virtio_ccw.c
> >> > +++ b/drivers/s390/kvm/virtio_ccw.c
> >> > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
> >> > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
> >> > int i;
> >> > struct virtqueue *vq;
> >> > - struct virtio_driver *drv;
> >> >
> >> > if (!vcdev)
> >> > return;
> >
> > *pokes Rusty*
> >
> > Do you want to send this via the virtio tree? Otherwise, I'll queue
> > this with kvm/s390.
>
> *Rusty wakes*.
>
> I assumed you would take it when I skimmed the patch, but to be formal:
>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Applied.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-10-31 8:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-20 10:48 [PATCH] virtio_ccw: remove unsued variable Sebastian Ott
2014-10-20 11:05 ` Cornelia Huck
2014-10-20 14:19 ` Michael S. Tsirkin
2014-10-28 15:39 ` Sebastian Ott
2014-10-28 17:37 ` Michael S. Tsirkin
2014-10-30 17:51 ` Cornelia Huck
2014-10-31 0:01 ` Rusty Russell
2014-10-31 8:10 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).