From: Sebastian Ott <sebott@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: Farhan Ali <alifm@linux.ibm.com>,
linux-s390@vger.kernel.org, Eric Farman <farman@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
kvm@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>,
virtualization@lists.linux-foundation.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Viktor Mihajlovski <mihajlov@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>
Subject: Re: [RFC PATCH 05/12] s390/cio: add protected virtualization support to cio
Date: Thu, 11 Apr 2019 16:15:02 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.21.1904111612160.1809@schleppi> (raw)
In-Reply-To: <20190404231622.52531-6-pasic@linux.ibm.com>
On Fri, 5 Apr 2019, Halil Pasic wrote:
> @@ -1593,20 +1609,29 @@ struct ccw_device * __init ccw_device_create_console(struct ccw_driver *drv)
> return ERR_CAST(sch);
>
> io_priv = kzalloc(sizeof(*io_priv), GFP_KERNEL | GFP_DMA);
> - if (!io_priv) {
> - put_device(&sch->dev);
> - return ERR_PTR(-ENOMEM);
> - }
> + if (!io_priv)
> + goto err_priv;
> + io_priv->dma_area = cio_dma_zalloc(sizeof(*io_priv->dma_area));
This is called very early - the dma pool is not yet initialized.
next prev parent reply other threads:[~2019-04-11 14:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190404231622.52531-1-pasic@linux.ibm.com>
[not found] ` <20190404231622.52531-2-pasic@linux.ibm.com>
2019-04-08 11:01 ` [RFC PATCH 01/12] virtio/s390: use vring_create_virtqueue Cornelia Huck
2019-04-08 12:37 ` Michael S. Tsirkin
[not found] ` <20190404231622.52531-3-pasic@linux.ibm.com>
2019-04-09 9:57 ` [RFC PATCH 02/12] virtio/s390: DMA support for virtio-ccw Cornelia Huck
[not found] ` <20190409132927.5df3bc50@oc2783563651>
2019-04-09 13:01 ` Cornelia Huck
[not found] ` <20190409152313.0296e8f1@oc2783563651>
2019-04-09 15:47 ` Cornelia Huck
[not found] ` <20190404231622.52531-5-pasic@linux.ibm.com>
2019-04-09 10:44 ` [RFC PATCH 04/12] s390/cio: introduce cio DMA pool Cornelia Huck
[not found] ` <20190409141114.7dcce94a@oc2783563651>
2019-04-09 17:14 ` Cornelia Huck
[not found] ` <20190410173148.067555dc@oc2783563651>
2019-04-10 16:07 ` Cornelia Huck
2019-04-11 18:25 ` Sebastian Ott
[not found] ` <20190412132010.3c74cb63@oc2783563651>
2019-04-12 12:12 ` Sebastian Ott
[not found] ` <20190412173017.04b768bb@oc2783563651>
2019-04-16 12:50 ` Sebastian Ott
[not found] ` <20190404231622.52531-4-pasic@linux.ibm.com>
2019-04-09 10:16 ` [RFC PATCH 03/12] s390/mm: force swiotlb for protected virtualization Cornelia Huck
[not found] ` <20190409125416.73713f23@oc2783563651>
2019-04-09 17:18 ` Cornelia Huck
2019-04-09 12:22 ` Christoph Hellwig
[not found] ` <20190404231622.52531-6-pasic@linux.ibm.com>
2019-04-09 17:55 ` [RFC PATCH 05/12] s390/cio: add protected virtualization support to cio Cornelia Huck
[not found] ` <20190410021044.4da3e847@oc2783563651>
2019-04-10 8:25 ` Cornelia Huck
[not found] ` <20190410150225.61b86cd9@oc2783563651>
2019-04-10 16:16 ` Cornelia Huck
2019-04-11 14:15 ` Sebastian Ott [this message]
[not found] ` <20190404231622.52531-8-pasic@linux.ibm.com>
2019-04-10 8:42 ` [RFC PATCH 07/12] virtio/s390: use DMA memory for ccw I/O Cornelia Huck
[not found] ` <20190410164245.53f8b26d@oc2783563651>
2019-04-10 16:21 ` Cornelia Huck
[not found] ` <20190404231622.52531-11-pasic@linux.ibm.com>
2019-04-10 8:46 ` [RFC PATCH 10/12] virtio/s390: consolidate DMA allocations Cornelia Huck
[not found] ` <20190410171254.71206015@oc2783563651>
2019-04-10 16:36 ` Cornelia Huck
[not found] ` <20190410194849.511ecc46@oc2783563651>
2019-04-11 9:24 ` Cornelia Huck
2019-04-10 9:20 ` [RFC PATCH 00/12] s390: virtio: support protected virtualization Cornelia Huck
[not found] ` <20190410175750.0ed0a454@oc2783563651>
2019-04-10 16:24 ` Cornelia Huck
2019-04-12 13:47 ` David Hildenbrand
[not found] ` <20190416131005.6f3e05eb@oc2783563651>
2019-04-16 11:50 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1904111612160.1809@schleppi \
--to=sebott@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mihajlov@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox