From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3BD3DDAE3 for ; Tue, 25 Aug 2026 08:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787646261; cv=none; b=XXXJdGqvi3XxizAKRGoGO09V2SQppeftfl3vPq8CxY31z2mGpwWVzn36RHp/8/uY8aor18NFmR4ERzlrBnpioNjPz7xcG3PlN1tS54NOIpcZHVgHmWheEWaC82uDyZxz7e4A952WgXwDgWxyswcFkdc/CcgpoTKY9RFjsWDByuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787646261; c=relaxed/simple; bh=DZQvgMF9MtoSMKn9/xxgPT3t+kYxUHeBLkPFZwmxGy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CCLQ2OsQdlvNQXBPQSrB3pEuust6mBTTC0qFY9cFJ4CF83bB0ZNAn0M5j3sLmgEKrJzb1BGxCEnffix/bNjLxNokmTUGbz2hDVgRW8tCcF6O+pHW6fW64xuz5Tj+7y+4peg24fQqpKdQ0rjUnJwKgCttxn2UyZ3YVDSChKKSI6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Vfv8ATx5; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Vfv8ATx5" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c1c50c1e29bso719084266b.3 for ; Tue, 25 Aug 2026 01:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1787646255; x=1788251055; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DZQvgMF9MtoSMKn9/xxgPT3t+kYxUHeBLkPFZwmxGy0=; b=Vfv8ATx5myKLdruW2Q6qlyPJhtDXbb+NqHcCEdACWK6rrXfodarpnzkRsnRbUbLTLt W71ELgrloG3Dksjd4q26mj9dkyjrurgaEI06szGtPm0b5fBpyZhr0M/+vKJ9rXhVsaEa CVtfPd0bIA/tLvp8cDdqghEf7S5YWax19Ukdn18pmzvf0ZI2g7KXKaKVC/hwCBhDXGk5 3g0TIjpCV2BEEZld1esKmtUjHrPkXlv+3Thwfn0FJtxVRCgiv/wFjMnXUO1xXj7e03Uh 7qeMS+9/NBhOt/gvmGH5s7l6mJo5lR5u/CnDn02iUmkejX+8uVPoOxQfogXDujC5gY/i ScQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787646255; x=1788251055; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DZQvgMF9MtoSMKn9/xxgPT3t+kYxUHeBLkPFZwmxGy0=; b=aTsZTc0/cNMWSND266wbiYs66M+L/lup28OYwdJztWuQ69ecKTr9C86bbwgY3jwx2p GSvVCZER3fvH6XN44ddhfTyHSXgng5u52RP9Rrcna79eWflvZC93O2a5AHcY2Ib92Ssq GDE4M1dKEb14c+kqc16a6Bw3hVY9dYoSMi560IotQPN2HtXRoojrzwIhyD6TpFRoFmiN mgt5359FWp4gCBgsoPm8N4CSLTijraI5022X/5hAzr+jVwjXNyx/hFYMztLP+NBgmSUW X9006T4zYT5SNNeSKFAtVNdO+9hkXgK8GDskhfzSJZxFmVGNzKUWNpur+hDUt8UKylrH ty1Q== X-Forwarded-Encrypted: i=1; AHgh+RqOd1h089tQX6EpijgnEE8tcrCGFTcwfdVOgq6nC1TYD3rvLX5SBjcBuZI6M5knpMwcuFyvxkdIxsQZ98SDCw==@lists.linux.dev X-Gm-Message-State: AFuF++kD9jkRRreso2HE5ot82w5/mZFmCkmzFD3lqGNqZv+Q6IaGZD2D MyBQRoiBBMH7VoPxDBDTdBvIz3/s0pKjr2YtLWuX4dmdrqmpV2X6wEgwlx7zKQjOkzk= X-Gm-Gg: AR+sD10DSv116Mph4gKWiG67LpVzO06rtY+HYh7fOm4b88F+qGIpNrQtClfMpY2ImOC HGjiBDN/KZCAbuywDdLH/hQ+NZT4hkxNuRlQM9BSrgR5SISU3htEtcsPYWHVdRzwE9My3qlINql Q78S3V/q2+VD7pmqnyUeJBwaU1AhX3GuULgEVfQDebDjw9lJvuNAiOggCRgHIfwFr6dOWZDP1Bf +roAssrx/QzN3FmJhsNz6T1e3AMIQMgiPZP4854MjF6PG63fZlDaTWoR1BlaUoXZyCBNsINKMhM qsY2r7i+qwEaBz6jBwtdHUOXy06kb9/jlJh+4WKDztjnmh8jldjJ9/FrfCOrhgs4bdFnfZ/mGxq ViQuWrH2v+uQnPXg2KEcm+fcInarOY4K44yJGMVm2zEqn6PIalTW2X45DJwtUJdWS16SWSQSUyb zJYh5SjEn9nZHAkfNAwGZJjm13VJ2dyAZrfz5/S22r/oZZmxBpHlglwtqnvFtc7uCDb+dBs/nh/ TMapyLTFouTkLLFm+AZrccpxOQDPy4P1mz56Gi+eDFF+8WsdQ== X-Received: by 2002:a17:907:1c07:b0:c15:f26a:3438 with SMTP id a640c23a62f3a-c24e5c1ffd3mr497229766b.24.1787646255345; Tue, 25 Aug 2026 01:24:15 -0700 (PDT) Received: from localhost (p200300f65f19a904037016a565660d5e.dip0.t-ipconnect.de. [2003:f6:5f19:a904:370:16a5:6566:d5e]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-c24966f9cbcsm1874351966b.29.2026.08.25.01.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 01:24:14 -0700 (PDT) Date: Tue, 25 Aug 2026 10:24:12 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Mauricio Faria de Oliveira Cc: Kees Cook , Joel Granados , Nathan Chancellor , Nicolas Schier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , kernel-dev@igalia.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, fsverity@lists.linux.dev, keyrings@vger.kernel.org, bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-sctp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, bridge@lists.linux.dev, mptcp@lists.linux.dev, rds-devel@oss.oracle.com, virtualization@lists.linux.dev Subject: Re: [PATCH RFC v3 03/13] sysctl, mod_devicetable: add macro MODULE_SYSCTL_TABLE Message-ID: References: <20260819-sysctl-module-aliases-v3-0-aab90569365d@igalia.com> <20260819-sysctl-module-aliases-v3-3-aab90569365d@igalia.com> <4e3eaf1d3419e808be046035f114bf6c@igalia.com> <4aa22e41e8ff4bab6638cf0baaa9d07b@igalia.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ajsyed3ibfmsggn6" Content-Disposition: inline In-Reply-To: <4aa22e41e8ff4bab6638cf0baaa9d07b@igalia.com> --ajsyed3ibfmsggn6 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH RFC v3 03/13] sysctl, mod_devicetable: add macro MODULE_SYSCTL_TABLE MIME-Version: 1.0 Hello, On Mon, Aug 24, 2026 at 06:04:03PM -0300, Mauricio Faria de Oliveira wrote: > On 2026-08-23 19:12, Uwe Kleine-K=F6nig wrote: > > On Sat, Aug 22, 2026 at 01:57:24PM -0300, Mauricio Faria de Oliveira wr= ote: > >> On 2026-08-22 10:41, Uwe Kleine-K=F6nig wrote: > >> > On Wed, Aug 19, 2026 at 03:16:16PM -0300, Mauricio Faria de Oliveira= wrote: > >> >> The MODULE_SYSCTL_TABLE macro emits a struct module_sysctl_table va= riable > >> >> with pointers to a sysctl table's path and entries, and table/entry= sizes. > >> >=20 > >> > That new struct doesn't seem to contain any pointer? > >>=20 > >> The struct module_sysctl_table fields .path and .table are pointers, > >> although with kernel_ulong_t type so that the same 32/64-bit size is > >> used in file2alias.c based on KERNEL_ELFCLASS (and not on the host, > >> which might differ with CROSS_COMPILE). > >=20 > > Cross compilation isn't an issue for the already existing device id > > structures; many of them also contain pointers. > > (While modpost doesn't use the pointers, the size of the structures must > > be known to correctly interpret the arrays.) >=20 > Indeed. I missed some device_id structures with pointers, and that > devicetable-offsets.c is cross-compiled to generate > devicetable-offsets.h for file2alias.c to use offsets and sizes of the > target architecture. >=20 > I'll change .path and .table to pointers in the next version. I *think* the existing device-id structs use char[] for strings that are relevant for modpost. I look forward to you finding out if there is still a justification for that :-D > > I would be great if your series didn't introduce a new obstacle for > > [CHERI]. >=20 > Absolutely. I'll be happy to adjust the series and testing for that. >=20 > Could you please confirm one should just follow [1], which uses [2] to > build the LLVM toolchain, and use it to build the kernel [3]? >=20 > [1] https://github.com/cheri-linux#building-and-running > [2] https://github.com/cheri-linux/buildroot > [3] https://github.com/CHERI-Alliance/linux/tree/codasip-cheri-riscv-7.1 I used https://github.com/CHERI-Alliance/meta-cheri/tree/codasip-scarthgap and didn't care about toolchain and rootfs. It also has qemu integrated, so you can actually test it. Best regards Uwe --ajsyed3ibfmsggn6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqNUSoACgkQj4D7WH0S /k5rHwf/eQKyjSm4dfYOnpO+kyESzhGSDXacrU0BK/nrQ7Z3BN+QipNdHe9BZ4f7 k+3uxaB8pZmyHeh98alfg/5Bq9HBt62YSsVo0f1LrxdEuw+otojZstZ5BajlC1fB uCZWsGYJ1lROqcGUkm3WTuwmO+VkI4no1e0+OMnKjMkIdarwm+SRxroNmGXPxjFS 0c5XzO8ufI4T330xBhTtUCfIGtmOib0XeyZT/dCtT8wNoKlznA36ojMl4ZOArWgW VYBN9/JdmoDGTZxdbWqXoETzY//dT0yaCQF2J8+eM7vMW+ay0vkBIpxXkR9QmIGF KIDH4l3txv82X35T5GJP5y9myooT6g== =Ph6i -----END PGP SIGNATURE----- --ajsyed3ibfmsggn6--