From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3EE846EC64 for ; Fri, 9 Oct 2026 10:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791540928; cv=none; b=CynaHzsJf0CQ8BIcJSyQb4N46TFPkcxiJqhlcaEzFsTzUAzX6f3hBBUe6N8pdq0jLYS0sUuVQ4PTHSiW1CbKI77BilZYV742O0q4gXoOEdlflEX6TmNi6D7FVSUQ9pf63JThXrrJCHN/7oW0S/vQgQOuqseM72D5hAuqsP+AjmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791540928; c=relaxed/simple; bh=jyDEhNWEktcDeVA66O0x0HheikRt8+3NMW3l44bD31Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=a3GxDNqN6SWvalVoMKuaaq0GNp7VSNO917X3fkdxKmCl8FMsqUrIQjH0KnDhiWyuonsWnFnztoicFFQj+c4wG6HdE/inmOACE6H0kUFAZ6gxfDFjLEqujOoQr46seff7fKUMSwSMtIsCuW2P0F370EmddkqOGdBFin8QSDo9bfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YR9lUCsA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YR9lUCsA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791540923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8qjpcfD3LG1eZs8VSpA9jEQmEOMfOU2B/T9s4mzaz2E=; b=YR9lUCsAExcPNjoNYfo2P79M1+v6Q6fA40V3z5ir7T6I5ynYnrKTqloRtWlyy6HosSqV1n syvhZ8qCNUpv9ObcG3YMd2xYxzjq8MOwpvPXYPgsiuMlaYCgzaKdF2GaOJ3maDwAuQthb5 ey5W3LjJ5MAp9g80RxGm5U+pKF/v8nQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-0hYZybGRNW2IK8cVkyaDKA-1; Fri, 09 Oct 2026 06:15:22 -0400 X-MC-Unique: 0hYZybGRNW2IK8cVkyaDKA-1 X-Mimecast-MFC-AGG-ID: 0hYZybGRNW2IK8cVkyaDKA_1791540921 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48b0679906dso3751430f8f.3 for ; Fri, 09 Oct 2026 03:15:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791540921; x=1792145721; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8qjpcfD3LG1eZs8VSpA9jEQmEOMfOU2B/T9s4mzaz2E=; b=ZVBwf1DDy6CQTPlSLKdf8CVaPIpXttjZUrGzt1msbmtL9lMcT3jr3Q60TFvEURlVZh AO6gaH1U/XK+CnCrEoueCqgyYtTMXdnxdrbJLSOlVN6aq3K4s4U73QaN10jWPpooj9tO zdx8BLsPDs3R2bLglp0FFazIrA7zQsVcNdUEV0pghTfPIZ10tfPL2/H1kl80W6GltMiM uokXujFpcNWaT7jWQaCVvozLHRzoBwCqYJ6CeXjySJRTrSp2ZHA8JUzSUcUYHStJcE9V X5hFzo9/DC8vKYZrF+dpNFnaBGBeGQS8PJjNkK+8neqfXdysyPDcupzRkZYwK6nQs5c0 BKSA== X-Forwarded-Encrypted: i=1; AKwUvBwUOGB+oCex/gokMc1EgGAwWzDXITqSFmpErrtzqWzoT0S383bfjKuXecvF5sRpvdVIKhXA7JkqByjWkRGG0A==@lists.linux.dev X-Gm-Message-State: AFuF++m6RUXX2XyEV+IgSYTbyGbgu5J/dMrpd33WGzszWJ1iIvmIECa+ 7RGKZP502vwCjffVf2Q2zO2drR8OxFGpzdCw6a4CAOeeo0UymS7sEyMaIooWK48SvGFxdhfX+zP ARKVzLCb9dUok4aarix1WMgtbFpzyPPkRaUFAo7MdtzAEBQlV7VxZKMsrQWnH8frMskd2 X-Gm-Gg: AYBFou2uEbMbTeHiA5+oSEWiWnh8SOVnPkCEDI4dZ1x9Rc02LSPvmAHYARWsfbL1OiG 6Aj1BHXFr5J+cG+/TcTb5nGjQqI1eJvWARxgyPRXqnHHa5BZjwmunPAYSCxr6RkzHPwJ2kAugJl E5DXvgaV8A+Si5waKi++eKDytMU/nfJfocag5Ewx6rO5GXtsJngD1622nbC0/dMmHDLG+IYo968 iOx4Uiq35OOTe3nQddlZQNDLEi9HJb7Oel5dI07OV6N26G0uOZeRf3x0EtS2tfFO736Jt/9eQqS /bxMLk+vwqjbzJT45uCzAICy3aflFT8VJvVq3fS9nRVyb+9xfDtQXENUKfc8egbK4awVDVxaugo M X-Received: by 2002:a05:600c:6989:b0:4a0:1f9e:5f7d with SMTP id 5b1f17b1804b1-4a18e4a0030mr24138465e9.7.1791540921034; Fri, 09 Oct 2026 03:15:21 -0700 (PDT) X-Received: by 2002:a05:600c:6989:b0:4a0:1f9e:5f7d with SMTP id 5b1f17b1804b1-4a18e4a0030mr24137885e9.7.1791540920563; Fri, 09 Oct 2026 03:15:20 -0700 (PDT) Received: from sgarzare-redhat ([5.11.115.77]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a18bea0f1csm80901885e9.9.2026.10.09.03.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2026 03:15:19 -0700 (PDT) Date: Fri, 9 Oct 2026 12:15:16 +0200 From: Stefano Garzarella To: Michal Luczaj Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= , "David S. Miller" , Xuan Zhuo , Jakub Kicinski , Paolo Abeni , Simon Horman , Eric Dumazet , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hyunwoo Kim Subject: Re: [PATCH net v4] vsock: treat TCP_CLOSING as once-established Message-ID: References: <20261005-vsock-connect-reset-closing-v4-0-15d41cfda3ed@rbox.co> <20261005-vsock-connect-reset-closing-v4-1-15d41cfda3ed@rbox.co> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20261005-vsock-connect-reset-closing-v4-1-15d41cfda3ed@rbox.co> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HUNOwcBYle8i23Bdwc52mmp0CypiAE6cNOL_G8cudeE_1791540921 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Mon, Oct 05, 2026 at 02:26:22AM +0200, Michal Luczaj wrote: >Handle the TCP_ESTABLISHED -> TCP_CLOSING transition on OP_RST, which can >race with the connect loop. Immediately break and return 0 on >ESTABLISHED/CLOSING. The return value of connect() should reflect what >happened up to the point the connection was established or failed. Events >that occur afterwards must not affect it. E.g. even if OP_RW has already >set sk_err, connect() should still return 0, not ENOBUFS because of it. >Adapt the inaccurate comment above signal_pending(). > >Resetting a socket that is still present in connected_table can lead to >memory corruption. The reporter noted lost transports for in-flight skbs, >and I have reproduced crashes caused by re-insertion into connected_table. > > list_add double add: new=, prev=, next=. > kernel BUG at lib/list_debug.c:35! > Oops: invalid opcode: 0000 [#1] SMP KASAN NOPTI > Workqueue: vsock-loopback vsock_loopback_work > RIP: 0010:__list_add_valid_or_report+0x11f/0x130 > Call Trace: > vsock_insert_connected.cold+0xe/0x13 > virtio_transport_recv_pkt+0x10e9/0x1460 > vsock_loopback_work+0x305/0x480 > process_one_work+0xe4c/0x1560 > worker_thread+0x4f1/0xd60 > kthread+0x36e/0x470 > ret_from_fork+0x47b/0x6b0 > ret_from_fork_asm+0x1a/0x30 > >This fix is supplementary to commit 002541ef650b ("vsock: Ignore >signal/timeout on connect() if already established"). Details under Link. > >Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") >Reported-by: Hyunwoo Kim >Link: https://lore.kernel.org/netdev/anzT1fREOSyHT99k@v4bel/ >Signed-off-by: Michal Luczaj >--- > net/vmw_vsock/af_vsock.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) LGTM! Thanks! Reviewed-by: Stefano Garzarella > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 9b71479a2b29..14fe24b05f9c 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1834,23 +1834,22 @@ static int vsock_connect(struct socket *sock, struct sockaddr_unsized *addr, > timeout = schedule_timeout(timeout); > lock_sock(sk); > >- /* Connection established. Whatever happens to socket once we >- * release it, that's not connect()'s concern. No need to go >+ /* Connection was established. Whatever happens to socket once >+ * we release it, that's not connect()'s concern. No need to go > * into signal and timeout handling. Call it a day. > * > * Note that allowing to "reset" an already established socket > * here is racy and insecure. > */ >- if (sk->sk_state == TCP_ESTABLISHED) >- break; >+ if (sk->sk_state == TCP_ESTABLISHED || >+ sk->sk_state == TCP_CLOSING) { >+ err = 0; >+ goto out_wait; >+ } > > /* If connection was _not_ established and a signal/timeout came > * to be, we want the socket's state reset. User space may want >- * to retry. >- * >- * sk_state != TCP_ESTABLISHED implies that socket is not on >- * vsock_connected_table. We keep the binding and the transport >- * assigned. >+ * to retry, so we keep the binding and the transport assigned. > */ > if (signal_pending(current) || timeout == 0) { > err = timeout == 0 ? -ETIMEDOUT : sock_intr_errno(timeout); > >-- >2.56.0 >