From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.47 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792608568; b=ZKqMnL/SiM5q4FkwFuYqp2VN+cTdCp0otyI+KwCKIQphk2DDRxZ3qNML32fkq/u5Gpqe UagSEYPTnWyZLBK+7rVq1R4jyDUXz4qUS0H4zZGack7yJQ/RvhFGpC+tuXD+K4CFC6Dwp Xf7DtUqKSFBloLLGKjWcO37kC0Msn2PlaSZQiJx1sNIXS8jJfJYD9YTge19aKUcPQsFqs 5EriERX7pzPd4cQi2UpOBwp5EOmtCgQJUG8E8FXTI1uQRM8xxWNKM0XHWeP3wlNYa7xhF XqfNWQJCGcMoFxGWXmPXEPFF5ZSuZAg9io8jSWxkQMYwMsK6b9N1Vx9kWxb0vRD8Bsg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792608568; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=wq1/fUbSP408+1Q3Fl5D/AoNlkMMVExemigFlptzFc8=; b=3bbd1puK1qeQ4A47vw57xv/ZcxxbSYYKDR/NFSr8aEQ24qouklnzSghOFNo+GTlT5ARJ r2Oh1axsPbzMDaPUDkjkkerspmPaa9e7bMS8dE7olo+WdLNZqU2TquqQE7g1mTbZ9amMI hgTsrR5wVEpTtRAtA2BSGK/pwkg5whhoHYbnfwwTuESY2+LdhBJFYJ+WJab2WC6CuU4Wm zlHa8qCv0R4HcnRaaWy98OBSdv0eLiuP+/tc28HW4Cs2sadv6xQ7qnNTk0NnxhLdqy9yD szxpp1TTYUek/4BFK23ikt583iTfo3+b//H1Jr2BL4WiAixBxvwn0t7vF+gs6r2WxvA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=XdYEPi+6; arc=none smtp.remote-ip=209.85.210.47 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEB07606A31A for ; Wed, 21 Oct 2026 18:49:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EEB07606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=XdYEPi+6 Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-84d5e56f876so483391a34.3 for ; Wed, 21 Oct 2026 11:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1792608566; x=1793213366; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wq1/fUbSP408+1Q3Fl5D/AoNlkMMVExemigFlptzFc8=; b=XdYEPi+6LieH0bWR2AyOb6nagBDyMIzQlWydvRBjIkYNQAqyieZtJ7u2RkENJGRLs3 sqE7MvPmfbKkoJYOxVkHxQ7RUs9S9aaHSxfKfnzl8Ggznj56zCgZ+TxvCzFb7vYqfXsK WWss4rUZv1IE/+ojn622rOtMMGBo0/oLn+Igv+38ktxriqzlSClogL/p6zyLkJQzId8w 8rXJFEQVfdRDKb83rexlTl50gtcCVN17KbRveggqhQJFogF2WlywfcNJyXf1ucaqQAU3 gCINB9Za9XaOu7zOmliO+URFf42oNuToz2ewGMknVUKy3UMFHfLDGEH0+159wAHKX+aq D7gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792608566; x=1793213366; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=wq1/fUbSP408+1Q3Fl5D/AoNlkMMVExemigFlptzFc8=; b=FXGnijf2Jc0n+TU2i3XWClabUkzNHjqMtvCxtM3DELMfpuZZQGjvapk47691JBnxsQ Q3EoLXSI/C1QfibSjSbcKbhbVw+2RMPNcQ3iDGlnzZbc+4JPEbMC0tRnWVShU+bMIuvz FnG0RGMxahPxS7wAKlZnnAqnptwHz9EsS/pfILfJCLv9vKJbbOhpRReKZ844CmwTh3/W dVSPsfqXp+a5Vqy0qDYGZhZHbGk4QGWs57Zo0CDtTHcmAzQWt3Ptadl2aVzZoTCuYw2+ T00uHIlSisct25f/LD+8J8qSIb1PHxO3AfzFskJQpNYrrYb08JWKdHPiBSevMt8Mqnmq YpmA== X-Forwarded-Encrypted: i=1; AKwUvBzN+t9t9V2vxu8YGsdkUTQ2MV74L4bOg/asA19MCtamF+IEwRD+sYCaR1nP8smjJzaW1Q8zbQlNLBkzWFXUhA==@lists.linux.dev X-Gm-Message-State: AFq9FYKfpRdMqMtPfAbGUpelymPUknGd8EkMrdVBgMv7JxLHv8kqsL98 xkiKYy3g5B5xrU0x/tkhNCTMLJkJbmjZeDbVvywXuBoqFXCKRumTYzDSKO0LDlWQYr0= X-Gm-Gg: AYBFou3gpqT0eowQ3Cu4QZ3rwzyr4YQl58uhXHVXCNnM96uFKSlTLDHUjOBY3IYr+s0 22FZJrVme6mxPmc/yefqPdXzBB3C6ZZJBT5o5aq0kBiQsFEM4Nr63E0ziSDuJoWwFvPgnbX6l8M 7Ik8F45cFrTNQofHUBxJtCa2PSDdknGUZdSaM50T5XSsBDYhnCMh+Hsfvd3U5R/5AufItiUUC5f CCnNCPKB8/f6Zw5oYeBeNmfo8DXNu6g2uiDkZKJF1aBb3MFUilAVKT/KAQZDUtCRddV1ZOsGsX+ bfpQM7tzSl5xzdVd1E2YeQGW6S3tmGgXARiXysN7qQ1munr677voQPkezfDsvTy3X+CLe/R25HT nh627bf8geSapfgntXofr0vMvNf/UgWNBCptTFW/RPlOMSW/HCwYT+uuxhOTeID5VFCBSeWOElX kNFYNrdFfAs11u86RQCPEkSUPgqfLLvSlH96fNYoR83GWl6dOfBhprUXNjO8+H9IzedCg0lhPGQ GlAKHVOyAqUWu4+YDDEE4qvf1DXwEWSvMaRou8= X-Received: by 2002:a05:6808:1903:b0:4b3:3e1:4a25 with SMTP id 5614622812f47-553559a2395mr2044396b6e.11.1792608565668; Wed, 21 Oct 2026 11:49:25 -0700 (PDT) Received: from 20HS2G4 ([2a09:bac6:bf21:15e1::22e:5d]) by smtp.gmail.com with ESMTPSA id 5614622812f47-552b583fd57sm2528069b6e.8.2026.10.21.11.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 11:49:24 -0700 (PDT) Date: Wed, 21 Oct 2026 13:49:21 -0500 From: Chris Arges To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Willem de Bruijn , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Phil Sutter , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Max Krasnyansky , Rusty Russell Subject: Re: [PATCH net v4 0/7] more virtio-net csum hardening Message-ID: References: X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-10-21 03:50:20, Michael S. Tsirkin wrote: > v4 and I'm pretty tired of this family of issues. > > Willem suggested more cleanups, but I don't think I will > be able to dedicate much more time to this, there's a pile of > fixes I queued that need to get tested and go into rc2, and a bunch > of qemu features that need review. > > Hopefully if any changes are required this can be done by patches on > top, or if someone wants to take over this, very welcome. > Happy to help if needed. Again, I was able to test this patchset minus the UM portions and verify that it fixes my tests. --chris > ------ > > As reported first by Paulos Yibelo (after which > others, credited below, found more ways the bug can affect users): > > allowing untrusted hardware to specify csum start/offset for > CHECKSUM_PARTIAL was not a good idea, because, if it edits the packet > outside the actual checksum, and depending on the setup, the networking > stack could be looking at the packet both before and after the edit, and > seeing different results. > > Previously, commit 6785011f8b16 ("ipv4: validate checksum_start before > completing checksum") validated all known instances where this > causes the most grief, but the real fix is to make sure > that either only actual checksum fields are ever edited, > or the checksum is completed before the net stack looks at it, > so it is always consistent. > > > This basically goes back to > what we did before f43798c27684 ("tun: Allow GSO using virtio_net_hdr"), > except in a narrow list of specified known good cases. > > > Summary of the patchset: > > These are probabably net material (and seem to be too big for stable, > or I would recommend backporting there, too): > > net: account for ingress-resolved virtio net hdr state > - accounting, not the fix itself, dependency of the fix > um: vector: trim skbs before verifying the header > - fixes the um receive path: without it the checksum would be > completed over the unreceived tail of the buffer > virtio_net: parse tunnel csum_start little-endian > - bugfix, a dependency of validating the header > net: resolve uncommon partial checksums at ingress > - fix itself > net: add a sysctl to opt out of virtio net hdr checksum validation > - reducing risk of the fix by adding a sysctl to disable it > > These are cleanups, can be deferred to net-next, too: > > net: add ip4_parse() > virtio_net: cleanup protocol calculation > - cleanup resulting code duplication > (kept separate to simplify backporting) > > Fixes: f43798c27684 ("tun: Allow GSO using virtio_net_hdr") > > Changes since v1: > - reorder patches to fix bisectability, addressing > a comment by Björn Töpel. > - code refactoring, different patch splitup, > a sysctl knob to disable as suggested by Willem de Bruijn. > - fix a bunch of minor issues spotted by LLMs > > > Changes since v2: > > virtio_net: parse tunnel csum_start little-endian > - new patch. correctly parsing the header is a dependency > of validating it, otherwise i do not know what to validate > > net: account for ingress-resolved virtio net hdr state > - make rx_csum_sw counter 64 bit so it won't wrap > (spotted by LLM review) > > net: resolve uncommon partial checksums at ingress > - tunnel fixes to bugs noticed by Willem de Bruijn and > Chris Arges > - restore the csum_offset checks as suggested by Willem > > net: add a sysctl to opt out of virtio net hdr checksum validation > - the knob is no longer writable by root inside a user > namespace: changing it now requires capable(CAP_NET_ADMIN) > suggested by Willem de Bruijn > > net: add ip4_parse() > - comment converted to kernel-doc format (Willem de Bruijn) > > um: vector: trim skbs before verifying the header > - new patch, found by code review > > > Changes since v3: > > net: account for ingress-resolved virtio net hdr state > - um: vector: honor virtio net hdr conversion failures > folded in (Björn Töpel) > - count on tap and virtio_net, too (Willem de Bruijn) > > net: resolve uncommon partial checksums at ingress > - walk the frame on loopback, too: loopback_xmit() runs > eth_type_trans() on it (Willem de Bruijn) > - return the mismatch handling directly, GSO is implied in > the tunnel path so drop there outright, and fold the helper > into its one remaining caller (Willem de Bruijn) > - read the IP version through struct iphdr (Willem de Bruijn) > - document the ipv6_find_hdr() flags choice > > net: add a sysctl to opt out of virtio net hdr checksum validation > - renamed to virtio_net_hdr_validate, in case more validation > is gated by the same knob later (Willem de Bruijn) > - point .data at the value like the neighboring entries, > the per-netns registration rebases it, and the handler reads > the value directly - no ctl_table copy (Björn Töpel, > Willem de Bruijn) > - check the opt-out before parsing: with the knob off, packets > the parser cannot handle were still dropped (Willem de Bruijn) > - include virtio_net.h in net/core/dev.c so the static key > definition sees its declaration (build warning reported by > Jakub Kicinski) > > net: add ip4_parse() > - add the missing kernel-doc Return: section > (Jakub Kicinski) > > Tested: full suite on the final tree, tunnel included. > um part compiled only. > > > Michael S. Tsirkin (7): > net: account for ingress-resolved virtio net hdr state > um: vector: trim skbs before verifying the header > virtio_net: parse tunnel csum_start little-endian > net: resolve uncommon partial checksums at ingress > net: add a sysctl to opt out of virtio net hdr checksum validation > net: add ip4_parse() > virtio_net: cleanup protocol calculation > > Documentation/admin-guide/sysctl/net.rst | 19 +++ > arch/um/drivers/vector_kern.c | 6 +- > arch/um/drivers/vector_transports.c | 4 +- > drivers/net/ipvlan/ipvtap.c | 36 ++++ > drivers/net/macvtap.c | 36 ++++ > drivers/net/tap.c | 8 +- > drivers/net/tun.c | 41 ++++- > drivers/net/virtio_net.c | 14 +- > include/linux/if_tap.h | 1 + > include/linux/ip.h | 30 ++++ > include/linux/virtio_net.h | 279 ++++++++++++++++++++++++++++++- > include/net/netns/core.h | 1 + > net/bridge/br_netfilter_hooks.c | 15 +- > net/core/dev.c | 7 + > net/core/net_namespace.c | 1 + > net/core/sysctl_net_core.c | 50 ++++++ > net/ipv4/ip_input.c | 13 +- > net/ipv4/netfilter/nf_reject_ipv4.c | 13 +- > net/packet/af_packet.c | 4 +- > 19 files changed, 533 insertions(+), 45 deletions(-) > > -- > MST >