From: Bobby Eshleman <bobbyeshleman@meta.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev-bot+sinfo@kernel.org,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowangio@gmail.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Simon Horman" <horms@kernel.org>,
kvm@vger.kernel.org, virtualization@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] vsock: only deliver taps to namespaces that can reach the device
Date: Thu, 19 Nov 2026 09:25:57 -0800 [thread overview]
Message-ID: <av8xJb3skp2S9a1D@devvm29614.prn0.facebook.com> (raw)
In-Reply-To: <a3049b70-fae9-488c-9de7-0c1613e6c480@redhat.com>
On Thu, Nov 19, 2026 at 10:03:10AM +0100, Paolo Abeni wrote:
> On 11/17/26 02:20, Bobby Eshleman wrote:
> > On Mon, Nov 16, 2026 at 11:52:38PM +0000, netdev-bot+sinfo@kernel.org wrote:
> > > Hi!
> > >
> > > This is an automated message. This series looks like a fix, but its
> > > commit messages seem to be missing some information:
> > >
> > > - How the issue was discovered, e.g. hit in production, hit during
> > > development, syzbot report, manual code inspection, LLM or static
> > > analysis tool scan.
> > >
> > > - Whether the issue was actually triggered, or is only theoretical
> > > (e.g. found by LLM and not proven at runtime). If it was triggered
> > > please include the symptoms, like the stack trace or kernel messages.
> > >
> > > Please do not repost the series just to address the above. Instead,
> > > reply to this email with the missing information, so that reviewers
> > > can take it into account.
> > >
> > > *IMPORTANT*: If you do repost (for other reasons) - please include
> > > the relevant info in the cover letter or commit messages.
> > > --
> > > The evaluation is done by an LLM so it may be wrong, if you think
> > > that is the case please reply and explain.
> >
> > This is a known issue and has come up in review of the guest netns
> > series (so via code inspection).
> My reading of the above is this feels like more an improvement than a
> regression fix. As such I'll move this to net-next. Please scream out
> loudly very soon if you disagree.
>
> /P
>
My net-next guest ns series actually needs this to build, maybe I should
pull it back into that series?
My rationale for sending to net was that it also fixes the issue for the
already merged vhost-vsock ns support. I don't have a strong opinion
either way.
Best,
Bobby
next prev parent reply other threads:[~2026-11-19 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 23:46 [PATCH net] vsock: only deliver taps to namespaces that can reach the device Bobby Eshleman
2026-11-16 23:52 ` netdev-bot+sinfo
2026-11-17 1:20 ` Bobby Eshleman
2026-11-19 9:03 ` Paolo Abeni
2026-11-19 17:25 ` Bobby Eshleman [this message]
2026-11-16 23:53 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8xJb3skp2S9a1D@devvm29614.prn0.facebook.com \
--to=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowangio@gmail.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox