From: Jason Wang <jasowang@redhat.com>
To: Liming Wu <liming.wu@jaguarmicro.com>, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] tools/virtio: fix vrinth_test hang
Date: Thu, 17 Nov 2022 13:41:21 +0800 [thread overview]
Message-ID: <b7dc0077-aa27-7802-c30e-ec87e172ecbb@redhat.com> (raw)
In-Reply-To: <20221115111746.858-1-liming.wu@jaguarmicro.com>
在 2022/11/15 19:17, Liming Wu 写道:
> vringh_test hangs on __vring_new_virtqueue() because `vqs_list_lock`
> is not initialized.
>
> Let's initialize it before call __vring_new_virtqueue()
>
> Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
> ---
> tools/virtio/vringh_test.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
> index fa87b58bd5fa..98ff808d6f0c 100644
> --- a/tools/virtio/vringh_test.c
> +++ b/tools/virtio/vringh_test.c
> @@ -308,6 +308,7 @@ static int parallel_test(u64 features,
>
> gvdev.vdev.features = features;
> INIT_LIST_HEAD(&gvdev.vdev.vqs);
> + spin_lock_init(&gvdev.vdev.vqs_list_lock);
> gvdev.to_host_fd = to_host[1];
> gvdev.notifies = 0;
>
> @@ -455,6 +456,7 @@ int main(int argc, char *argv[])
> getrange = getrange_iov;
> vdev.features = 0;
> INIT_LIST_HEAD(&vdev.vqs);
> + spin_lock_init(&vdev.vqs_list_lock);
>
> while (argv[1]) {
> if (strcmp(argv[1], "--indirect") == 0)
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
parent reply other threads:[~2022-11-17 5:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221115111746.858-1-liming.wu@jaguarmicro.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7dc0077-aa27-7802-c30e-ec87e172ecbb@redhat.com \
--to=jasowang@redhat.com \
--cc=liming.wu@jaguarmicro.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).