From: "Deng, Jie" <jie.deng@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Sergey.Semin@baikalelectronics.ru"
<Sergey.Semin@baikalelectronics.ru>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"loic.poulain@linaro.org" <loic.poulain@linaro.org>,
"Wang, Yu1" <yu1.wang@intel.com>,
"mst@redhat.com" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"krzk@kernel.org" <krzk@kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"wsa@kernel.org" <wsa@kernel.org>,
"wsa+renesas@sang-engineering.com"
<wsa+renesas@sang-engineering.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"rppt@kernel.org" <rppt@kernel.org>,
"Liu, Shuo A" <shuo.a.liu@intel.com>,
"tali.perry1@gmail.com" <tali.perry1@gmail.com>,
"Chen, Conghui" <conghui.chen@intel.com>,
"jdelvare@suse.de" <jdelvare@suse.de>
Subject: Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver
Date: Wed, 23 Sep 2020 07:34:35 +0000 [thread overview]
Message-ID: <bbd9d177f1974908aaae996ca110e17c@intel.com> (raw)
In-Reply-To: <20200922112348.GL3956970@smile.fi.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]
On 2020/9/22 19:23, Andy Shevchenko wrote:
+ if ((!vmsg) || (vmsg != &vi->vmsg)) {
This is a bit difficult to read (esp. taking into account the above comment)
besides the fact of redundant parentheses. Why not simply:
if (!(vmsg && vmsg == &vi->vmsg)) {
?
Thanks Andy. It looks better.
--
2.7.4
[-- Attachment #1.2: Type: text/html, Size: 3042 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-09-23 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 2:58 [PATCH v3] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2020-09-22 11:23 ` Andy Shevchenko
2020-09-23 7:30 ` Deng, Jie
2020-09-23 7:34 ` Deng, Jie [this message]
2020-10-10 3:14 ` Jason Wang
2020-10-12 2:45 ` Jie Deng
2020-10-12 3:43 ` Jason Wang
2020-10-13 7:16 ` Jie Deng
2020-10-13 8:00 ` Jason Wang
2020-10-14 8:37 ` Jie Deng
2020-10-15 7:06 ` Jason Wang
[not found] ` <20201008140151.GE897@ninjato>
2020-10-12 3:18 ` Jie Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbd9d177f1974908aaae996ca110e17c@intel.com \
--to=jie.deng@intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=conghui.chen@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mst@redhat.com \
--cc=rppt@kernel.org \
--cc=shuo.a.liu@intel.com \
--cc=tali.perry1@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).