From: Ferry Meng <mengferry@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Jingbo Xu <jefflexu@linux.alibaba.com>,
Christoph Hellwig <hch@infradead.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
linux-block@vger.kernel.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, io-uring@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for virtio-blk
Date: Wed, 18 Dec 2024 11:35:19 +0800 [thread overview]
Message-ID: <bcc94e61-d4ce-4a33-a7cd-0cb61a516bf9@linux.alibaba.com> (raw)
In-Reply-To: <92eafd0f-943a-4595-8df3-45128cac5ee9@kernel.dk>
On 12/18/24 5:07 AM, Jens Axboe wrote:
> On 12/17/24 2:00 PM, Stefan Hajnoczi wrote:
>> On Tue, 17 Dec 2024 at 12:54, Jens Axboe <axboe@kernel.dk> wrote:
>>> On 12/16/24 11:08 PM, Jingbo Xu wrote:
>>>>> That's why I asked Jens to weigh in on whether there is a generic
>>>>> block layer solution here. If uring_cmd is faster then maybe a generic
>>>>> uring_cmd I/O interface can be defined without tying applications to
>>>>> device-specific commands. Or maybe the traditional io_uring code path
>>>>> can be optimized so that bypass is no longer attractive.
>>> It's not that the traditional io_uring code path is slower, it's in fact
>>> basically the same thing. It's that all the other jazz that happens
>>> below io_uring slows things down, which is why passthrough ends up being
>>> faster.
>> Are you happy with virtio_blk passthrough or do you want a different approach?
> I think it looks fine.
>
OK, thx. I will submit the official patch for review soon after
resolving the test bot warning.
prev parent reply other threads:[~2024-12-18 3:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 12:14 [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for virtio-blk Ferry Meng
2024-12-03 12:14 ` [PATCH 1/3] virtio-blk: add virtio-blk chardev support Ferry Meng
2024-12-03 12:14 ` [PATCH 2/3] virtio-blk: add uring_cmd support for I/O passthru on chardev Ferry Meng
2024-12-04 15:19 ` kernel test robot
2024-12-03 12:14 ` [PATCH 3/3] virtio-blk: add uring_cmd iopoll support Ferry Meng
2024-12-04 21:47 ` [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for virtio-blk Stefan Hajnoczi
2024-12-05 9:51 ` [Resend]Re: " Ferry Meng
2024-12-16 2:01 ` Ferry Meng
2024-12-16 7:38 ` Jason Wang
2024-12-16 12:07 ` Ferry Meng
2024-12-17 2:08 ` Jason Wang
2024-12-17 6:04 ` Ferry Meng
2024-12-16 15:54 ` Christoph Hellwig
2024-12-16 16:13 ` Stefan Hajnoczi
2024-12-17 2:12 ` Jason Wang
2024-12-17 6:08 ` Jingbo Xu
2024-12-17 17:54 ` Jens Axboe
2024-12-17 21:00 ` Stefan Hajnoczi
2024-12-17 21:07 ` Jens Axboe
2024-12-18 3:35 ` Ferry Meng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcc94e61-d4ce-4a33-a7cd-0cb61a516bf9@linux.alibaba.com \
--to=mengferry@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=io-uring@vger.kernel.org \
--cc=jasowang@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@gmail.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox