From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1322614A62B for ; Wed, 18 Dec 2024 03:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734492934; cv=none; b=GEUe+d1xugwVObagZ7pZ5ZqQ/5pfhmboz6h5uHO/9SzQoHFvfF0dKY7JkAhf8qMyejxc9El5lxLhejqgVrBAuVuftkrPFDYWdbQxmidMF5vBo1RaSuZ+d66aVe4XKsw6m1qg+Wq93lQvYbH9iIyyPYA/lfjIuZY/TwZG4bKsEp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734492934; c=relaxed/simple; bh=vgO1U/Y8Tyjoq8LUVxkUz+j2i9Ufx61wGRhxHLFOONU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j7m5voheifHV7mYfk4zvQWpMdYPxvP1RKKh4E+ouSnCVgOSrL3eSKE5HEFA9wQblIdUskKL4u40fctSIsfaYA40ggvjlgHCg4CdCk4jWP8QPC9zsTQk5MBV8KhXilPNV696UFrGgWDItQ7Ys/aEPSXV/0+Z0qhRPrXHiLjpvciQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=aVra/Rpd; arc=none smtp.client-ip=115.124.30.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="aVra/Rpd" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1734492923; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=YGzuGWLAUDC0mlrmUfaEpO0oU9ym4tO687kSt9C3jc0=; b=aVra/Rpd+Q7SyqA3GgTngsfIML51prCBzKpA9yEahMzjtC+Pp4SHq6u8/75K0Y1f6uSQWuQC3XEJW4xA42M+bGojTiu3NLBjZDRdcdOuZxMGv/ovRfL25EgSAXhtumAwxYVeJxk776S5+Xbm0e0lWXsZQxXFI4UVnyz15PDVOCc= Received: from 30.221.131.238(mailfrom:mengferry@linux.alibaba.com fp:SMTPD_---0WLl5IBE_1734492921 cluster:ay36) by smtp.aliyun-inc.com; Wed, 18 Dec 2024 11:35:22 +0800 Message-ID: Date: Wed, 18 Dec 2024 11:35:19 +0800 Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for virtio-blk To: Jens Axboe , Stefan Hajnoczi Cc: Jingbo Xu , Christoph Hellwig , "Michael S . Tsirkin" , Jason Wang , linux-block@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, Joseph Qi References: <20241203121424.19887-1-mengferry@linux.alibaba.com> <0535520b-a6a6-4578-9aca-c698e148004e@linux.alibaba.com> <92eafd0f-943a-4595-8df3-45128cac5ee9@kernel.dk> Content-Language: en-US From: Ferry Meng In-Reply-To: <92eafd0f-943a-4595-8df3-45128cac5ee9@kernel.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/18/24 5:07 AM, Jens Axboe wrote: > On 12/17/24 2:00 PM, Stefan Hajnoczi wrote: >> On Tue, 17 Dec 2024 at 12:54, Jens Axboe wrote: >>> On 12/16/24 11:08 PM, Jingbo Xu wrote: >>>>> That's why I asked Jens to weigh in on whether there is a generic >>>>> block layer solution here. If uring_cmd is faster then maybe a generic >>>>> uring_cmd I/O interface can be defined without tying applications to >>>>> device-specific commands. Or maybe the traditional io_uring code path >>>>> can be optimized so that bypass is no longer attractive. >>> It's not that the traditional io_uring code path is slower, it's in fact >>> basically the same thing. It's that all the other jazz that happens >>> below io_uring slows things down, which is why passthrough ends up being >>> faster. >> Are you happy with virtio_blk passthrough or do you want a different approach? > I think it looks fine. > OK, thx. I will submit the official patch for review soon after resolving the test bot warning.